From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C44C19F2C for ; Tue, 16 Aug 2022 06:17:47 +0000 (UTC) Received: from localhost ([::1]:41616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNpta-0003cn-JF for qemu-devel@archiver.kernel.org; Tue, 16 Aug 2022 02:17:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNpqL-0002pn-6b for qemu-devel@nongnu.org; Tue, 16 Aug 2022 02:14:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:52280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNpqH-0001no-C0 for qemu-devel@nongnu.org; Tue, 16 Aug 2022 02:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660630460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kk8jY9r8f0sj2Wvk2ewf3rwTzVbLVLRt6pHL+2TZ/7c=; b=f9UujU6pYSUAsOj2ZADqGDyaUil7KuSWusqBm8XThK9UeaokpYRYTCJ637QJXA9bLIXeyE T+6LSoVpso9nbLwfzXW8sPUi5aspjD2pXJRWTUyIH/Z3GAf45YuRFj+1+zG1s6V2YJwRGu m2yuo6wQz36JFdTCVVtS2VdKOG09Ewk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-219-uZgUQ1QaN9KzVHhk6EyrWg-1; Tue, 16 Aug 2022 02:14:17 -0400 X-MC-Unique: uZgUQ1QaN9KzVHhk6EyrWg-1 Received: by mail-wm1-f70.google.com with SMTP id a17-20020a05600c349100b003a545125f6eso9771468wmq.4 for ; Mon, 15 Aug 2022 23:14:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Kk8jY9r8f0sj2Wvk2ewf3rwTzVbLVLRt6pHL+2TZ/7c=; b=eskpnnBmib3718Poe0IZhyqR3AkwP7C0i3wjZpElAOdVW7lsYozv6m417fBOpm/bbz AoHIaj5UK3z4AkG1KvkFiCToBqW0K6NQSAjh6Sasn+tjSNMyTbb3zG0cSZEIRY5/tGQY BZfkIC5lMVnzTN6za3n6jYH8pQPhtrvvRUqv2LSa2zU5iJJGkXR/TGUdDxtNoldI+Lc7 L06k3fI+tokLRczFANzmIC2f5Z2XAam3mpq71JOMgXmAXLUFDAp+IfnGw30osevilnVH wmmQhUfk/1LMidXmG4io8yKyAw+2NasAtSd6vxxmx8dv2yS3tZ9lVveltNPSheOpMHDI j6pQ== X-Gm-Message-State: ACgBeo3h6TITjNnZ/FDNMB4nkUztvMqYV4S7pufDDuKfslDE9Mk8++jz 8FGvGK7QT0VyP9ozI4lSAyNt0CHNKB/m6v4fl9uqHXoi4pUWma/MxBVZx87EwCSM0sGK6cSvOQl RU/clGvy/Jyj+icI= X-Received: by 2002:a5d:5a0f:0:b0:220:5930:dc65 with SMTP id bq15-20020a5d5a0f000000b002205930dc65mr10208580wrb.229.1660630455866; Mon, 15 Aug 2022 23:14:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR5cfL7Ic6nZl+PQImQNJ8yVtCf/33ohngQIc/W983L4Z+Y5xelVvpxh7dVjNvf3330fAQpdXQ== X-Received: by 2002:a5d:5a0f:0:b0:220:5930:dc65 with SMTP id bq15-20020a5d5a0f000000b002205930dc65mr10208572wrb.229.1660630455634; Mon, 15 Aug 2022 23:14:15 -0700 (PDT) Received: from redhat.com ([2.55.4.37]) by smtp.gmail.com with ESMTPSA id l9-20020a5d5609000000b0021f1ec8776fsm8983407wrv.61.2022.08.15.23.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 23:14:14 -0700 (PDT) Date: Tue, 16 Aug 2022 02:14:10 -0400 From: "Michael S. Tsirkin" To: Kangjie Xu Cc: qemu-devel@nongnu.org, jasowang@redhat.com, eduardo@habkost.net, marcel.apfelbaum@gmail.com, f4bug@amsat.org, wangyanan55@huawei.com, hengqi@linux.alibaba.com, xuanzhuo@linux.alibaba.com Subject: Re: [PATCH 00/24] Support VIRTIO_F_RING_RESET for virtio-net, vhost-user, vhost-kernel in virtio pci-modern Message-ID: <20220816021322-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 16, 2022 at 09:06:12AM +0800, Kangjie Xu wrote: > The virtio queue reset function has already been defined in the virtio spec 1.2. > The relevant virtio spec information is here: > > https://github.com/oasis-tcs/virtio-spec/issues/124 > https://github.com/oasis-tcs/virtio-spec/issues/139 > > This patch set is to support this function in QEMU. It consists of several parts: > 1. Patches 1-7 are the basic interfaces for vq reset in virtio and virtio-pci. > 2. Patches 8-12 support vq stop and vq restart for vhost-kernel. > 3. Patches 13-19 support vq stop and vq restart for vhost-user. > 4. Patches 20-22 support vq reset and re-enable for virtio-net. > 5. Patches 23-24 enable the vq reset feature for vhost-kernel and vhost-user. > > The process of virtqueue reset can be concluded as: > 1. The virtqueue is disabled when VIRTIO_PCI_COMMON_Q_RESET is written. > 2. Then the virtqueue can be optionally restarted(re-enabled). > > Since this patch set involves multiple modules and seems a bit messy, we briefly describe the > calling process for different modes below. > virtio-net: > 1. VIRTIO_PCI_COMMON_Q_RESET is written [virtio-pci] > -> virtio_queue_reset() [virtio] > -> virtio_net_queue_reset() [virtio-net] > -> __virtio_queue_reset() > 2. VIRTIO_PCI_COMMON_Q_ENABLE is written [virtio-pci] > -> set enabled, reset status of vq. > > vhost-kernel: > 1. VIRTIO_PCI_COMMON_Q_RESET is written [virtio-pci] > -> virtio_queue_reset() [virtio] > -> virtio_net_queue_reset() [virtio-net] > -> vhost_net_virtqueue_stop() [vhost-net] > -> vhost_net_set_backend() [vhost] > -> vhost_dev_virtqueue_stop() > -> vhost_virtqueue_unmap() > -> __virtio_queue_reset() > 2. VIRTIO_PCI_COMMON_Q_ENABLE is written [virtio-pci] > -> virtio_queue_enable() [virtio] > -> virtio_net_queue_enable() [virtio-net] > -> vhost_net_virtqueue_restart() [vhost-net] > -> vhost_dev_virtqueue_restart() [vhost] > -> vhost_virtqueue_start() > -> vhost_net_set_backend() > -> set enabled, reset status of vq. > > vhost-user: > 1. VIRTIO_PCI_COMMON_Q_RESET is written [virtio-pci] > -> virtio_queue_reset() [virtio] > -> virtio_net_queue_reset() [virtio-net] > -> vhost_net_virtqueue_stop() [vhost-net] > -> vhost_dev_virtqueue_stop() [vhost] > -> vhost_user_reset_vring() [vhost-user] > -> send VHOST_USER_RESET_VRING to the device > -> vhost_virtqueue_unmap() > -> __virtio_queue_reset() > 2. VIRTIO_PCI_COMMON_Q_ENABLE is written [virtio-pci] > -> virtio_queue_enable() [virtio] > -> virtio_net_queue_enable() [virtio-net] > -> vhost_net_virtqueue_restart() [vhost-net] > -> vhost_dev_virtqueue_restart() [vhost] > -> vhost_virtqueue_start() > -> vhost_user_set_single_vring_enable [vhost-user] > -> send VHOST_USER_SET_VRING_ENABLE to the device > -> set enabled, reset status of vq. > > > Test environment: > Host: 5.19.0-rc3 (With vq reset support) > Qemu: QEMU emulator version 7.0.50 > Guest: 5.19.0-rc3 (With vq reset support) > DPDK: 22.07-rc1 (With vq reset support) > Test Cmd: ethtool -g eth1; ethtool -G eth1 rx $1 tx $2; ethtool -g eth1; > > The drvier can resize the virtio queue, then virtio queue reset function should > be triggered. > > The default is split mode, modify Qemu virtio-net to add PACKED feature to > test packed mode. legacy mode testing? > Guest Kernel Patch: > https://lore.kernel.org/bpf/20220801063902.129329-1-xuanzhuo@linux.alibaba.com/ > > DPDK Patch: > https://github.com/middaywords/dpdk/compare/72206323a5dd3182b13f61b25a64abdddfee595c...eabadfac7953da66bc10ffb8284b490d09bb7ec7 > > Host Kernel Patch: > https://github.com/middaywords/linux/commit/19a91e0d7167b2031e46078c6215c213b89cb2c3 > > Looking forward to your review and comments. Thanks. > > Kangjie Xu (19): > virtio: introduce virtio_queue_enable() > virtio: core: vq reset feature negotation support > virtio-pci: support queue enable > vhost: extract the logic of unmapping the vrings and desc > vhost: introduce vhost_dev_virtqueue_stop() > vhost: introduce vhost_dev_virtqueue_restart() > vhost-net: vhost-kernel: introduce vhost_net_virtqueue_stop() > vhost-net: vhost-kernel: introduce vhost_net_virtqueue_restart() > docs: vhost-user: add VHOST_USER_RESET_VRING message > vhost-user: introduce vhost_reset_vring() interface > vhost-user: add op to enable or disable a single vring > vhost: vhost-user: update vhost_dev_virtqueue_stop() > vhost: vhost-user: update vhost_dev_virtqueue_restart() > vhost-net: vhost-user: update vhost_net_virtqueue_stop() > vhost-net: vhost-user: update vhost_net_virtqueue_restart() > virtio-net: introduce flush_or_purge_queued_packets() > virtio-net: support queue_enable > vhost: vhost-kernel: enable vq reset feature > vhost: vhost-user: enable vq reset feature > > Xuan Zhuo (5): > virtio: sync relevant definitions with linux > virtio: introduce __virtio_queue_reset() > virtio: introduce virtio_queue_reset() > virtio-pci: support queue reset > virtio-net: support queue reset > > docs/interop/vhost-user.rst | 10 +++ > hw/core/machine.c | 1 + > hw/net/vhost_net.c | 79 +++++++++++++++++++ > hw/net/virtio-net.c | 58 ++++++++++++-- > hw/virtio/vhost-user.c | 67 ++++++++++++++-- > hw/virtio/vhost.c | 79 +++++++++++++++++-- > hw/virtio/virtio-pci.c | 20 +++++ > hw/virtio/virtio.c | 62 +++++++++++---- > include/hw/virtio/vhost-backend.h | 6 ++ > include/hw/virtio/vhost.h | 5 ++ > include/hw/virtio/virtio-pci.h | 1 + > include/hw/virtio/virtio.h | 8 +- > include/net/vhost_net.h | 4 + > .../standard-headers/linux/virtio_config.h | 5 ++ > include/standard-headers/linux/virtio_pci.h | 2 + > 15 files changed, 371 insertions(+), 36 deletions(-) > > -- > 2.32.0