All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Xie Yongji <xieyongji@bytedance.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vduse:  Remove include of rwlock.h
Date: Tue, 16 Aug 2022 04:26:59 -0400	[thread overview]
Message-ID: <20220816042557-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220816074816.173227-1-bigeasy@linutronix.de>

On Tue, Aug 16, 2022 at 09:48:16AM +0200, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. Including it directly will break the RT build.
> 
> Remove the rwlock.h include.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

in fact


#ifndef __LINUX_SPINLOCK_H
# error "please don't include this file directly"
#endif

I wonder how does it build.


> ---
>  drivers/vdpa/vdpa_user/iova_domain.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/vdpa/vdpa_user/iova_domain.h b/drivers/vdpa/vdpa_user/iova_domain.h
> index 4e0e50e7ac153..173e979b84a93 100644
> --- a/drivers/vdpa/vdpa_user/iova_domain.h
> +++ b/drivers/vdpa/vdpa_user/iova_domain.h
> @@ -14,7 +14,6 @@
>  #include <linux/iova.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/vhost_iotlb.h>
> -#include <linux/rwlock.h>
>  
>  #define IOVA_START_PFN 1
>  
> -- 
> 2.37.2

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2022-08-16  8:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  7:48 [PATCH] vduse: Remove include of rwlock.h Sebastian Andrzej Siewior
2022-08-16  8:26 ` Michael S. Tsirkin [this message]
2022-08-16  8:33   ` Sebastian Andrzej Siewior
2022-08-16  8:39     ` Michael S. Tsirkin
2022-08-16 10:45       ` Sebastian Andrzej Siewior
2022-08-16 11:59         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816042557-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.