From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93903C25B0E for ; Tue, 16 Aug 2022 12:01:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M6V9F651yz3brF for ; Tue, 16 Aug 2022 22:01:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i92FOHFV; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NbJAAGXa; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=mst@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i92FOHFV; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NbJAAGXa; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M6V8T4ydTz3bZY for ; Tue, 16 Aug 2022 22:00:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660651218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=i92FOHFVbf9bU9evkFdsmwSNSBf6HWh9IEQMDNtx7Cy2RwialXFTcaak8fl8Zi6oQfZphC Gs9HEVI36fq29EFPDuIqQL70q09fn9vJC/O+B3Qs7UkKjT177RljsHzkfa+nVsgKwcy9dO vWH5/qAfO8RvmxEMcjhgKEx3tq0Z/Zo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660651219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=NbJAAGXaDePzXDLNZgOvKqwsf6Rui8Qm0mgh69MGXNlX5r39Y7XWmlQsC8l/EdntJQYYDm zL9i6uKuydP+SQVdMorsZQ2UV3gCh8YZy6j1GV0FY4i4FlgPiGzlwiMqvkaGW4kXgFAZpT R2aHa9JUCbJLX9WwuBEig2b/QESkTHw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-669-p1T1oVFYO5e8oBTmWaZ5mQ-1; Tue, 16 Aug 2022 08:00:17 -0400 X-MC-Unique: p1T1oVFYO5e8oBTmWaZ5mQ-1 Received: by mail-wm1-f72.google.com with SMTP id 203-20020a1c02d4000000b003a5f5bce876so1561027wmc.2 for ; Tue, 16 Aug 2022 05:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=QAjjj3TEiRjHOci93k6LAOmhy1Y2gtNKNyYAJja+kPsP6PJrwML1qgsQUlDLFnkGsF /1xzJB4e73MwAXFRhuiu/Uv/VYguu5tRQT1WEd34SnRPWxsS4GlJCLorRehZ8Mygtt5k kgr6EIrGdygmxXd3VE49FLl2Ql2odJWPw9nAAG/nmyTyl2/Bfc4pbROFaZItu5B+WQwv Ae2RjAkS4CW6gBr+tSpgqcJIcpBjpGBY3xi/LKht2Qq26z8XjDMRznlwLGLgHxvH7b/n cL3uJnY7pLPBHk/4nvWyu32zjmyhFkR6QCqROFes1Cqv7XG1z22bdE72cAqSjQu6RbaO TCwQ== X-Gm-Message-State: ACgBeo08tXD8kpQZX9AicqIg/3ntZE9zx+gnQnhngjow9cgVS6rXQ7R8 I4MV2rQ/Q+1Uqj+WT4t8o7XIHi4sX1MsrgWuGq1yRPT4IBtIxP+rCv2ZavjSEpnF/FTSqkpU+oD XClKD8IAzoAeT0EJ9OVNTJjoLog== X-Received: by 2002:a05:6000:2a8:b0:220:6893:4ff6 with SMTP id l8-20020a05600002a800b0022068934ff6mr11805880wry.170.1660651216642; Tue, 16 Aug 2022 05:00:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+lxy72X0p8q1N/VA1caBeK9MeCyZ3upRXQRZYRJDWig+QRJxJ+nox5XWYdcFyrgUtFuIZyQ== X-Received: by 2002:a05:6000:2a8:b0:220:6893:4ff6 with SMTP id l8-20020a05600002a800b0022068934ff6mr11805859wry.170.1660651216420; Tue, 16 Aug 2022 05:00:16 -0700 (PDT) Received: from redhat.com ([2.55.4.37]) by smtp.gmail.com with ESMTPSA id cl5-20020a5d5f05000000b00224f7c1328dsm8312482wrb.67.2022.08.16.05.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 05:00:15 -0700 (PDT) Date: Tue, 16 Aug 2022 08:00:10 -0400 From: "Michael S. Tsirkin" To: Greg Kroah-Hartman Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: <20220816075953-mutt-send-email-mst@kernel.org> References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , David Hildenbrand , VMware PV-Drivers Reviewers , Jason Wang , Alexander Atanasov , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Nadav Amit , Nicholas Piggin , kernel@openvz.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > > Hello, > > > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > > > Why rename the .h file? It still handles the "balloon compaction" > > > logic. > > > > File contains code that is common to balloon drivers, > > compaction is only part of it. Series add more code to it. > > Since it was suggested to use it for such common code. > > I find that common becomes a better name for it so the rename. > > I can drop the rename easy on next iteration if you suggest to. > > "balloon_common.h" is very vague, you should only need one balloon.h > file in the include/linux/ directory, right, so of course it is "common" > :) > > thanks, > > greg "naming is hard" k-h Yea, just call it balloon.h and balloon.c then. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77E64C32773 for ; Tue, 16 Aug 2022 12:00:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E660840A81; Tue, 16 Aug 2022 12:00:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E660840A81 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i92FOHFV X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KTIAdqgn-Vxw; Tue, 16 Aug 2022 12:00:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5984340A63; Tue, 16 Aug 2022 12:00:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5984340A63 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 30F95C0078; Tue, 16 Aug 2022 12:00:23 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06840C002D for ; Tue, 16 Aug 2022 12:00:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9F8ED40B3C for ; Tue, 16 Aug 2022 12:00:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9F8ED40B3C X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yWMq3s9GgBEK for ; Tue, 16 Aug 2022 12:00:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E40A440A81 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id E40A440A81 for ; Tue, 16 Aug 2022 12:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660651218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=i92FOHFVbf9bU9evkFdsmwSNSBf6HWh9IEQMDNtx7Cy2RwialXFTcaak8fl8Zi6oQfZphC Gs9HEVI36fq29EFPDuIqQL70q09fn9vJC/O+B3Qs7UkKjT177RljsHzkfa+nVsgKwcy9dO vWH5/qAfO8RvmxEMcjhgKEx3tq0Z/Zo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-313-0-tlVozgO4qcDP28VNwGBg-1; Tue, 16 Aug 2022 08:00:17 -0400 X-MC-Unique: 0-tlVozgO4qcDP28VNwGBg-1 Received: by mail-wm1-f70.google.com with SMTP id a17-20020a05600c349100b003a545125f6eso10125377wmq.4 for ; Tue, 16 Aug 2022 05:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=ajgL2pffZcOkzNdP8uVECI3A2QOMFqZ8auUUE8l135jReRGv3If/t+uFfGtNRjLe0e 4ZMwhsjBUga1+ICl3Kdgalud1OnV2LM5K2K+2wPl1Gx9BpTLMy2ZXn+eXou4F0ftG5eb r5gTRY5HMMZvID0L4TVG9hG1m/HdUS7L3Cw1flhu55u6pDyeyd8WLJYQbA2IUUv2Rql5 MhcE5yX9xgcPHyu8m9eP82495nGrH8ijE6pnNASarw1iF6X5dBytV5RhWumZ33MUSAxF Zjp9ncBuSrkvH81CZbttVtJ/+5+ZXAY28m9C1MMh7IsLTtF/oSP8gEed0MPHP8OFVA5P vQxg== X-Gm-Message-State: ACgBeo36HHHAl4sRQNuU3s+5udu54v6nNhhYPAmyo3xVd2x+KaRAz6Df HMrffVtgWv8V4lXyBypvZsYug5qQV74U/tXSXTxkN625P0TRMJORTAcIOmBpZC6ue2lNy/ghM8W pPcYj5v48cIsCSLoxCJGgw8y/pltgtwzMEmOXp9Tt3Q== X-Received: by 2002:a05:6000:2a8:b0:220:6893:4ff6 with SMTP id l8-20020a05600002a800b0022068934ff6mr11805878wry.170.1660651216641; Tue, 16 Aug 2022 05:00:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+lxy72X0p8q1N/VA1caBeK9MeCyZ3upRXQRZYRJDWig+QRJxJ+nox5XWYdcFyrgUtFuIZyQ== X-Received: by 2002:a05:6000:2a8:b0:220:6893:4ff6 with SMTP id l8-20020a05600002a800b0022068934ff6mr11805859wry.170.1660651216420; Tue, 16 Aug 2022 05:00:16 -0700 (PDT) Received: from redhat.com ([2.55.4.37]) by smtp.gmail.com with ESMTPSA id cl5-20020a5d5f05000000b00224f7c1328dsm8312482wrb.67.2022.08.16.05.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 05:00:15 -0700 (PDT) Date: Tue, 16 Aug 2022 08:00:10 -0400 From: "Michael S. Tsirkin" To: Greg Kroah-Hartman Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: <20220816075953-mutt-send-email-mst@kernel.org> References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Arnd Bergmann , VMware PV-Drivers Reviewers , Michael Ellerman , Alexander Atanasov , linux-kernel@vger.kernel.org, Christophe Leroy , virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Nadav Amit , Nicholas Piggin , kernel@openvz.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > > Hello, > > > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > > > Why rename the .h file? It still handles the "balloon compaction" > > > logic. > > > > File contains code that is common to balloon drivers, > > compaction is only part of it. Series add more code to it. > > Since it was suggested to use it for such common code. > > I find that common becomes a better name for it so the rename. > > I can drop the rename easy on next iteration if you suggest to. > > "balloon_common.h" is very vague, you should only need one balloon.h > file in the include/linux/ directory, right, so of course it is "common" > :) > > thanks, > > greg "naming is hard" k-h Yea, just call it balloon.h and balloon.c then. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B341C32773 for ; Tue, 16 Aug 2022 12:00:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3A608D0001; Tue, 16 Aug 2022 08:00:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9C16B0075; Tue, 16 Aug 2022 08:00:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB9DC8D0001; Tue, 16 Aug 2022 08:00:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C7F826B0073 for ; Tue, 16 Aug 2022 08:00:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9584D1A101B for ; Tue, 16 Aug 2022 12:00:21 +0000 (UTC) X-FDA: 79805313042.13.A5AA5B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id B734A1801A3 for ; Tue, 16 Aug 2022 12:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660651219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=NbJAAGXaDePzXDLNZgOvKqwsf6Rui8Qm0mgh69MGXNlX5r39Y7XWmlQsC8l/EdntJQYYDm zL9i6uKuydP+SQVdMorsZQ2UV3gCh8YZy6j1GV0FY4i4FlgPiGzlwiMqvkaGW4kXgFAZpT R2aHa9JUCbJLX9WwuBEig2b/QESkTHw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-475-flIlyqvzMzqrAt0SEE4e0g-1; Tue, 16 Aug 2022 08:00:17 -0400 X-MC-Unique: flIlyqvzMzqrAt0SEE4e0g-1 Received: by mail-wm1-f72.google.com with SMTP id h62-20020a1c2141000000b003a4f57eaeaaso4822111wmh.8 for ; Tue, 16 Aug 2022 05:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=WL/YsFTrWX5XvDLPqvb2TGXYygIh+NpcWZdrQQtTk2G929tJXtmaFy1RjsqhUc2Q0m MGIQZouK8nvspuZLO0pfxmMNQbxiQSk9cga+2CkbFCfU817gv4cDJZlSfziDldEK6/9R 8pxKBaZGh5t20R6ybe0cphWyk4eqNpiqdUiM7DEstkVN+yH/s4WZn5pi/nTqYWI8GH+W Ym6xKIHlVDULa7VPm79jFEs4wO+c8wlqMwSvquUxdyJYRxJWowM7BZWiAmyhLnM2aF0s EQ+XBDHzqsE++9Bk+bmFjFWmjKvcVLMOdhv2fhvWxh5jRfsSQAlrr06B1j0EwxUuKHjK PvaA== X-Gm-Message-State: ACgBeo2ms4H6e/ORY1PejYrSwyIfB/OSL0pfQVQ79cN//MVGxbVv8/lp FXCUe3IM3qjiNv/6vAtdLYfV+wPwev4dSB6jeWh20Nx8vah2KRehSaESh+qVEqx3TXCqooeaQDN eUXDM9xEzoWI= X-Received: by 2002:a05:6000:2a8:b0:220:6893:4ff6 with SMTP id l8-20020a05600002a800b0022068934ff6mr11805875wry.170.1660651216640; Tue, 16 Aug 2022 05:00:16 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+lxy72X0p8q1N/VA1caBeK9MeCyZ3upRXQRZYRJDWig+QRJxJ+nox5XWYdcFyrgUtFuIZyQ== X-Received: by 2002:a05:6000:2a8:b0:220:6893:4ff6 with SMTP id l8-20020a05600002a800b0022068934ff6mr11805859wry.170.1660651216420; Tue, 16 Aug 2022 05:00:16 -0700 (PDT) Received: from redhat.com ([2.55.4.37]) by smtp.gmail.com with ESMTPSA id cl5-20020a5d5f05000000b00224f7c1328dsm8312482wrb.67.2022.08.16.05.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 05:00:15 -0700 (PDT) Date: Tue, 16 Aug 2022 08:00:10 -0400 From: "Michael S. Tsirkin" To: Greg Kroah-Hartman Cc: Alexander Atanasov , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nadav Amit , VMware PV-Drivers Reviewers , Arnd Bergmann , David Hildenbrand , Jason Wang , Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: <20220816075953-mutt-send-email-mst@kernel.org> References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660651220; a=rsa-sha256; cv=none; b=cTMqBheZt90jFEu+Wgz5KybJTSrB3neNxNGKCsemCh2wgJAqFTuV8RolI3zbZqvb4LK8ox bcoGLEs5HFqWqwTmxOhESkoc7gpJcHV2v+CzYVTefbeknmOiAZHqdxj0hWzAXd6RBkoAbi j8GcZzjXugJjy/14tBobqnXeiS8fRAw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NbJAAGXa; spf=pass (imf06.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660651220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pwz8sbWeHrkfuw7TlrsGXqGQd9GZSL1nvueVrYuNuZ0=; b=JfdzWYQRXBV1DcP7mFU3eJbfK5E7hOouGRJX/E8sYyreFJ3VcY+RzrrltP7lRZDTwAaAfL Lm3yr+9vmk7Rntvu5zlHmk1MuAEOJ5B4yCFBcN1k7nj5WQ5uEwWjOXnItqyUIFrYJWCg/V /GZfQtTIPX7FSAfLeDIMajMmhQMYiY0= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B734A1801A3 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NbJAAGXa; spf=pass (imf06.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: jnfpbzpukmnou8jmiy8jhyjo81ehsb1q X-HE-Tag: 1660651219-119813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote: > > Hello, > > > > On 16.08.22 12:49, Greg Kroah-Hartman wrote: > > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote: > > > > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%) > > > > > > Why rename the .h file? It still handles the "balloon compaction" > > > logic. > > > > File contains code that is common to balloon drivers, > > compaction is only part of it. Series add more code to it. > > Since it was suggested to use it for such common code. > > I find that common becomes a better name for it so the rename. > > I can drop the rename easy on next iteration if you suggest to. > > "balloon_common.h" is very vague, you should only need one balloon.h > file in the include/linux/ directory, right, so of course it is "common" > :) > > thanks, > > greg "naming is hard" k-h Yea, just call it balloon.h and balloon.c then. -- MST