From: Jakub Kicinski <kuba@kernel.org>
To: shaozhengchao <shaozhengchao@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next,0/3] cleanup of qdisc offload function
Date: Tue, 16 Aug 2022 11:13:05 -0700 [thread overview]
Message-ID: <20220816111305.4851a510@kernel.org> (raw)
In-Reply-To: <694f07e3-d5ad-1bc5-1cdb-ae814b1a12f7@huawei.com>
On Tue, 16 Aug 2022 11:32:03 +0800 shaozhengchao wrote:
> On 2022/8/16 11:10, Jakub Kicinski wrote:
> > On Tue, 16 Aug 2022 10:04:20 +0800 Zhengchao Shao wrote:
> >> Some qdiscs don't care return value of qdisc offload function, so make
> >> function void.
> >
> > How many of these patches do you have? Is there a goal you're working
> > towards? I don't think the pure return value removals are worth the
> > noise. They don't even save LoC:
> >
> > 3 files changed, 9 insertions(+), 9 deletions(-)
>
> Thank you for your reply. Recently I've been studying the kernel code
> related to qdisc, and my goal is to understand how qdisc works. If the
> code can be optimized, I do what I can to modify the optimization. Is it
> more appropriate to add warning to the offload return value? I look
> forward to your reply. Thank you.
Understood. Please stop sending the cleanups removing return values
unless the patches materially improve the code.
next prev parent reply other threads:[~2022-08-16 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 2:04 [PATCH net-next,0/3] cleanup of qdisc offload function Zhengchao Shao
2022-08-16 2:04 ` [PATCH net-next,1/3] net: sched: make mq_offload() void Zhengchao Shao
2022-08-16 2:04 ` [PATCH net-next,2/3] net: sched: make prio_offload() void Zhengchao Shao
2022-08-16 2:04 ` [PATCH net-next,3/3] net: sched: make red_offload() void Zhengchao Shao
2022-08-16 3:10 ` [PATCH net-next,0/3] cleanup of qdisc offload function Jakub Kicinski
2022-08-16 3:32 ` shaozhengchao
2022-08-16 18:13 ` Jakub Kicinski [this message]
2022-08-17 13:19 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816111305.4851a510@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.