From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E92BC25B0E for ; Tue, 16 Aug 2022 16:10:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36AC484899; Tue, 16 Aug 2022 18:10:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foundries.io header.i=@foundries.io header.b="ToNnLBOO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40D11848F0; Tue, 16 Aug 2022 18:10:30 +0200 (CEST) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77542844A8 for ; Tue, 16 Aug 2022 18:10:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jorge@foundries.io Received: by mail-wm1-x332.google.com with SMTP id k6-20020a05600c1c8600b003a54ecc62f6so5612569wms.5 for ; Tue, 16 Aug 2022 09:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundries.io; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc; bh=SQicr7i3ZbMnaJGHLMN98VXFsaBFwXBkZ0R1oi0YQdQ=; b=ToNnLBOOqikRz2bu81swxkIorrGJsv66LAJl7mBHlitBGncUx6bTbcmFgkJydvQLQu tBngx/jUt412Cfn1zMlmCoPFfxNdAlgFnWcDEOxC0MjQHTb6V1a+GnO5W0+pMymRNASW irk71W7w+nxfkZuQMcLtA+gz15BI3Pr9f4YwJNnTSccnzcKGLeTVQ81zCNaj6O4xkE0M DSJ8bMP1p0ybMdknWAFiTa7llBFmt9UHz0qYcL1mhe1VA/4cpUud6QDxDgWnXNOtpUph OtPXl21QMJtmnHVZsj82Mte3zdjmC4NL+u2j8IBmHnLQhbKAYZIFdztYGAd8YdnXZYYr 1N3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc; bh=SQicr7i3ZbMnaJGHLMN98VXFsaBFwXBkZ0R1oi0YQdQ=; b=U8s8Esq5tk3KEeSbmIa/U2qECPseIF5NEcy/vqYIbm/JvZvRv63pfhJ+Um37LK+zfj 5Wd9ekUtyYWmaWHYupzEpGPlwT++NbFWO8P6Fikap7kBu//GoyOz9GfeYZJLaLbL4keg cRtqzROg6w5oBEm5+F1Dy4geCEbaKiZHudP7HPwTGcdPqJPkbj+cqA7hSM0JhnMAb5+r pEYd3/tNo1QjZ6DjrkDNA8+RvYb8mna4TAyvxeJTCuYNJ+YAzXE3QBMa5o2via00aqId aOESMkb8ZL9HAblk1gqe89lz+VuJ/BwGBDITP8vW9BjzKPYfnVVz3SweFKdqIrcRYRZX pr1A== X-Gm-Message-State: ACgBeo0a3TqXz71kGG9RWnAI1iFL4wKe9sJyRzZ+pb6kVFQaK8JjEdkG 1/L6bNuPplp8OHTKLDgzi6Xcug== X-Google-Smtp-Source: AA6agR712izfB5KzEt86ANv07qpiPT6u5pxx9Srbu/P0eqOoHlMgZ3JQkB23ziQ5TauLIvg/VyVe4w== X-Received: by 2002:a7b:cb0a:0:b0:3a4:eafc:367d with SMTP id u10-20020a7bcb0a000000b003a4eafc367dmr14080608wmj.0.1660666226906; Tue, 16 Aug 2022 09:10:26 -0700 (PDT) Received: from trex (78.red-83-60-92.dynamicip.rima-tde.net. [83.60.92.78]) by smtp.gmail.com with ESMTPSA id h2-20020adfe982000000b0021e30e9e44asm10443242wrm.53.2022.08.16.09.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 09:10:26 -0700 (PDT) From: "Jorge Ramirez-Ortiz, Foundries" X-Google-Original-From: "Jorge Ramirez-Ortiz, Foundries" Date: Tue, 16 Aug 2022 18:10:25 +0200 To: Oleksandr Suvorov Cc: Jorge Ramirez-Ortiz , jens.wiklander@linaro.org, u-boot@lists.denx.de Subject: Re: [PATCH] drivers: tee: i2c: support the NXP SE05x probe errata Message-ID: <20220816161025.GA1036449@trex> References: <20220816112840.857563-1-jorge@foundries.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 16/08/22, Oleksandr Suvorov wrote: > Hi Jorge, > > On Tue, Aug 16, 2022 at 2:28 PM Jorge Ramirez-Ortiz wrote: > > > > Early instantiation of this I2C device would lock up when being > > probed. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > With a small note below, > Acked-by: Oleksandr Suvorov > > > --- > > drivers/tee/optee/Kconfig | 14 +++++++++++++ > > drivers/tee/optee/i2c.c | 44 +++++++++++++++++++++++++++++++++++---- > > 2 files changed, 54 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig > > index d03028070b..05dfe2c9a8 100644 > > --- a/drivers/tee/optee/Kconfig > > +++ b/drivers/tee/optee/Kconfig > > @@ -37,6 +37,20 @@ config OPTEE_TA_SCP03 > > help > > Enables support for controlling (enabling, provisioning) the > > Secure Channel Protocol 03 operation in the OP-TEE SCP03 TA. > > + > > +config TEE_I2C_NXP_SE05X_ERRATA > > + bool "Enable NXP SE05X Errata" > > + select TEE_I2C_NXP_SE05X_ERRATA_IN_BUS > > + default y > > I doubt this should be enabled by default. you are probably right (was just fixing the problem as was being reported by some user). will remove the active default > > > + help > > + This config prevents the I2C trampoline driver from probing > > + on every transfer. > > + > > +config TEE_I2C_NXP_SE05X_ERRATA_IN_BUS > > + int "I2C bus where to apply the NXP SE05X errata" > > + depends on TEE_I2C_NXP_SE05X_ERRATA > > + default 0 > > + > > endmenu > > > > endif > > diff --git a/drivers/tee/optee/i2c.c b/drivers/tee/optee/i2c.c > > index ef4e10f991..a3ea34d4a2 100644 > > --- a/drivers/tee/optee/i2c.c > > +++ b/drivers/tee/optee/i2c.c > > @@ -3,13 +3,18 @@ > > * Copyright (c) 2020 Foundries.io Ltd > > */ > > > > +#define LOG_CATEGORY UCLASS_I2C > > + > > #include > > #include > > #include > > +#include > > #include > > #include "optee_msg.h" > > #include "optee_private.h" > > > > +#define NXP_SE05X_ADDR 0x48 > > + > > static int check_xfer_flags(struct udevice *chip, uint tee_flags) > > { > > uint flags; > > @@ -30,6 +35,30 @@ static int check_xfer_flags(struct udevice *chip, uint tee_flags) > > return 0; > > } > > > > +static struct udevice *get_chip_dev(int bnum, int addr) > > +{ > > + struct udevice *chip; > > + struct udevice *bus; > > + > > + if (IS_ENABLED(CONFIG_TEE_I2C_NXP_SE05X_ERRATA)) { > > + if (bnum == CONFIG_TEE_I2C_NXP_SE05X_ERRATA_IN_BUS && > > + addr == NXP_SE05X_ADDR) { > > + if (uclass_get_device_by_seq(UCLASS_I2C, bnum, &bus)) > > + return NULL; > > + > > + if (i2c_get_chip(bus, addr, 0, &chip)) > > + return NULL; > > + > > + return chip; > > + } > > + } > > + > > + if (i2c_get_chip_for_busnum(bnum, addr, 0, &chip)) > > + return NULL; > > + > > + return chip; > > +} > > + > > void optee_suppl_cmd_i2c_transfer(struct optee_msg_arg *arg) > > { > > const u8 attr[] = { > > @@ -38,7 +67,8 @@ void optee_suppl_cmd_i2c_transfer(struct optee_msg_arg *arg) > > OPTEE_MSG_ATTR_TYPE_RMEM_INOUT, > > OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT, > > }; > > - struct udevice *chip_dev; > > + struct udevice *chip_dev = NULL; > > + > > struct tee_shm *shm; > > u8 *buf; > > int ret; > > @@ -56,9 +86,9 @@ void optee_suppl_cmd_i2c_transfer(struct optee_msg_arg *arg) > > if (!buf) > > goto bad; > > > > - if (i2c_get_chip_for_busnum((int)arg->params[0].u.value.b, > > - (int)arg->params[0].u.value.c, > > - 0, &chip_dev)) > > + chip_dev = get_chip_dev((int)arg->params[0].u.value.b, > > + (int)arg->params[0].u.value.c); > > + if (!chip_dev) > > goto bad; > > > > if (check_xfer_flags(chip_dev, arg->params[1].u.value.a)) > > @@ -66,10 +96,16 @@ void optee_suppl_cmd_i2c_transfer(struct optee_msg_arg *arg) > > > > switch (arg->params[0].u.value.a) { > > case OPTEE_MSG_RPC_CMD_I2C_TRANSFER_RD: > > + log_debug("OPTEE_MSG_RPC_CMD_I2C_TRANSFER_RD %d\n", > > + (size_t)arg->params[2].u.rmem.size); > > + > > ret = dm_i2c_read(chip_dev, 0, buf, > > (size_t)arg->params[2].u.rmem.size); > > break; > > case OPTEE_MSG_RPC_CMD_I2C_TRANSFER_WR: > > + log_debug("OPTEE_MSG_RPC_CMD_I2C_TRANSFER_WR %d\n", > > + (size_t)arg->params[2].u.rmem.size); > > + > > ret = dm_i2c_write(chip_dev, 0, buf, > > (size_t)arg->params[2].u.rmem.size); > > break; > > -- > > 2.34.1 > > > > > -- > Best regards > Oleksandr > > Oleksandr Suvorov > cryosay@gmail.com