From: Rob Herring <robh@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] of: fdt: fix off-by-one error in unflatten_dt_nodes()
Date: Tue, 16 Aug 2022 11:29:40 -0600 [thread overview]
Message-ID: <20220816172940.GA2417741-robh@kernel.org> (raw)
In-Reply-To: <7c354554-006f-6b31-c195-cdfe4caee392@omp.ru>
On Sat, 13 Aug 2022 23:34:16 +0300, Sergey Shtylyov wrote:
> Commit 78c44d910d3e ("drivers/of: Fix depth when unflattening devicetree")
> forgot to fix up the depth check in the loop body in unflatten_dt_nodes()
> which makes it possible to overflow the nps[] buffer...
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
>
> Fixes: 78c44d910d3e ("drivers/of: Fix depth when unflattening devicetree")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> ---
> The patch is against the 'master' branch of Rob Herring's 'linux-git' repo...
>
> drivers/of/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
prev parent reply other threads:[~2022-08-16 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 20:34 [PATCH] of: fdt: fix off-by-one error in unflatten_dt_nodes() Sergey Shtylyov
2022-08-16 17:29 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816172940.GA2417741-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.