From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8D11C25B0E for ; Tue, 16 Aug 2022 20:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EzR+Z4kxn7o2P/WW6PzrWm03607DFyihBAzL1aumsm4=; b=2qVAxWdeeoiwQbMh8EIAfQsMEj +9bWvJJNAaQMMeICfoUTcj388HTyLzgPhXT3J1ywiBheRZ4eisTV8uw4qHb1V48iXxSK5TVvgHDpW 1meW+PVGGoDb6O6/j4RdJTcXxyE4qdVZydbyW5HE2XayaO7lzy6i+Q5sBa9oJPWk+2P0WvY6lb8dZ keNbvZnHAoOrhDzuLUAEjpxZ8vRZZZhsCW8OkLYdD/X825m38KcGBCVenzIdIG/fXmGtanc1ptdvQ Q1cn6ziItDsgV3oIN0qlJ2ug5Ffb8ZUTjr542A2phIgWKeXGkrVbnbr8UolFx+9sNSMH1eqh2JuyJ AQ3UkSbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3YN-006vCP-RM; Tue, 16 Aug 2022 20:52:47 +0000 Received: from mail-il1-f179.google.com ([209.85.166.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3YB-006v49-DL; Tue, 16 Aug 2022 20:52:36 +0000 Received: by mail-il1-f179.google.com with SMTP id k12so1982482ilq.10; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=EzR+Z4kxn7o2P/WW6PzrWm03607DFyihBAzL1aumsm4=; b=09g+a3tcmQOOtO779ACHi1k2NyhR67f9j1SBhlcGX7Ea5NsCfflM4OLOU+cpHWc76y 06KiA3XVNJx7phgW0Fx8Oha+RI/8Mo29WBAvHZ5mDzi/mE+q5+LilgPt52+sCHLbl5jn hZNxP4cKziKGrwGkHc43F72p4UxTM/1L2tivJfS6V8cjmqCKFJOO5mmJw5BS4/x3BZFz GrJMz9JmwlWKChBSJoVnwYgW9MXHNtv2RPKiP87aq0oSqd7nKGSztN/GzJT65iLiBF+5 hXl9xJP3XdDN8n+q7Itvk1C5I2aYSJ1HQ8PcaYI1Aw1Kk82tfjrmg6bULT44mLTmSkje TQkg== X-Gm-Message-State: ACgBeo0Qh4kxrPFNjWYcjU5EgAWEoYXQDNj8FGwhgITAg3DQKL6Nfri2 Zev3hSX/8JONt5MUAEelpg== X-Google-Smtp-Source: AA6agR4sGyiJKaOIlOFFnF0gqYNlu2XfR46u2ykdYGuFEEDs2T7qsaoxAPvnZ50uBGOOW7Z0yR8c2A== X-Received: by 2002:a05:6e02:18cd:b0:2de:73e8:3f0 with SMTP id s13-20020a056e0218cd00b002de73e803f0mr10622659ilu.69.1660683151102; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id v30-20020a02b09e000000b00339dbd4c8d7sm4780229jah.45.2022.08.16.13.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:52:30 -0700 (PDT) Received: (nullmailer pid 2713686 invoked by uid 1000); Tue, 16 Aug 2022 20:52:28 -0000 Date: Tue, 16 Aug 2022 14:52:28 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Subject: Re: [PATCH v2 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines Message-ID: <20220816205228.GA2709277-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220813154415.349091-3-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_135235_507031_301E48CB X-CRM114-Status: GOOD ( 22.93 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sander Vanheule , linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Ren=E9?= van Dorst , Eric Dumazet , Krzysztof Kozlowski , erkin.bozoglu@xeront.com, Florian Fainelli , Sergio Paracuellos , Jakub Kicinski , Paolo Abeni , Vivien Didelot , devicetree@vger.kernel.org, Landen Chao , Sean Wang , Luiz Angelo Daros de Luca , DENG Qingfang , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Daniel Golle , Vladimir Oltean , "David S . Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Aug 13, 2022 at 06:44:10PM +0300, Arınç ÜNAL wrote: > - Fix description of mediatek,mcm. mediatek,mcm is not used on MT7623NI. > - Add description for reset-gpios. > - Invalidate reset-gpios if mediatek,mcm is used. > - Invalidate mediatek,mcm if the compatible device is mediatek,mt7531. > - Require mediatek,mcm for the described MT7621 SoCs as the compatible > string is only used for MT7530 which is a part of the multi-chip module. The commit message should answer 'why is this change needed/wanted?' not 'what changed'. I can read the diff to see what changed. d> > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 31 +++++++++++++++++-- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index edf48e917173..4c99266ce82a 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -110,11 +110,15 @@ properties: > mediatek,mcm: > type: boolean > description: > - if defined, indicates that either MT7530 is the part on multi-chip > - module belong to MT7623A has or the remotely standalone chip as the > - function MT7623N reference board provided for. > + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530 > + switch is a part of the multi-chip module. > > reset-gpios: > + description: > + GPIO to reset the switch. Use this if mediatek,mcm is not used. > + This property is optional because some boards share the reset line with > + other components which makes it impossible to probe the switch if the > + reset line is used. > maxItems: 1 > > reset-names: > @@ -165,6 +169,9 @@ allOf: > required: > - mediatek,mcm > then: > + properties: > + reset-gpios: false > + > required: > - resets > - reset-names > @@ -182,6 +189,24 @@ allOf: > - core-supply > - io-supply > > + - if: > + properties: > + compatible: > + items: > + - const: mediatek,mt7531 > + then: > + properties: > + mediatek,mcm: false > + > + - if: > + properties: > + compatible: > + items: > + - const: mediatek,mt7621 > + then: > + required: > + - mediatek,mcm > + > unevaluatedProperties: false > > examples: > -- > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39A7AC25B0E for ; Tue, 16 Aug 2022 20:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1AUEoZWMsFONrHoQ2LeRKJi2VVapgAEiT9UoQ6DtK14=; b=0Pm3XWlmckpQzs V3vknZ/9vRnn6hGkTtjszb+gHsmPEe7FtNbJCYMNMk0G7Lf5djWbJMYy2Ea5wQJGkRRzJgoJJg27V GMoh8dy09b3i/FVap4Kz+6HUsMRVoJYS54QjxHtNrXwqcsEUtX1MHXhqP7Uibs5/Awezvr0BVtLQx xFQaqDLQc57s5xxv1ijKRCtkCPiTS7nXjyndkDFJzQASYrrVd+5o82tmSVoENPTWlwE5zaU7oRZ48 N4Q2xENq8IpqmteYlUUBWgAibJaJ2o4r8LRGMGFQ5VkaZjraBgPWwmga7UOYICgC7QcPPl3OJH7aS uYyB5i32QSzMIq0xHg8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3YF-006v9Q-1Z; Tue, 16 Aug 2022 20:52:39 +0000 Received: from mail-il1-f179.google.com ([209.85.166.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3YB-006v49-DL; Tue, 16 Aug 2022 20:52:36 +0000 Received: by mail-il1-f179.google.com with SMTP id k12so1982482ilq.10; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=EzR+Z4kxn7o2P/WW6PzrWm03607DFyihBAzL1aumsm4=; b=09g+a3tcmQOOtO779ACHi1k2NyhR67f9j1SBhlcGX7Ea5NsCfflM4OLOU+cpHWc76y 06KiA3XVNJx7phgW0Fx8Oha+RI/8Mo29WBAvHZ5mDzi/mE+q5+LilgPt52+sCHLbl5jn hZNxP4cKziKGrwGkHc43F72p4UxTM/1L2tivJfS6V8cjmqCKFJOO5mmJw5BS4/x3BZFz GrJMz9JmwlWKChBSJoVnwYgW9MXHNtv2RPKiP87aq0oSqd7nKGSztN/GzJT65iLiBF+5 hXl9xJP3XdDN8n+q7Itvk1C5I2aYSJ1HQ8PcaYI1Aw1Kk82tfjrmg6bULT44mLTmSkje TQkg== X-Gm-Message-State: ACgBeo0Qh4kxrPFNjWYcjU5EgAWEoYXQDNj8FGwhgITAg3DQKL6Nfri2 Zev3hSX/8JONt5MUAEelpg== X-Google-Smtp-Source: AA6agR4sGyiJKaOIlOFFnF0gqYNlu2XfR46u2ykdYGuFEEDs2T7qsaoxAPvnZ50uBGOOW7Z0yR8c2A== X-Received: by 2002:a05:6e02:18cd:b0:2de:73e8:3f0 with SMTP id s13-20020a056e0218cd00b002de73e803f0mr10622659ilu.69.1660683151102; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id v30-20020a02b09e000000b00339dbd4c8d7sm4780229jah.45.2022.08.16.13.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:52:30 -0700 (PDT) Received: (nullmailer pid 2713686 invoked by uid 1000); Tue, 16 Aug 2022 20:52:28 -0000 Date: Tue, 16 Aug 2022 14:52:28 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?iso-8859-1?Q?Ren=E9?= van Dorst , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines Message-ID: <20220816205228.GA2709277-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220813154415.349091-3-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_135235_507031_301E48CB X-CRM114-Status: GOOD ( 22.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBBdWcgMTMsIDIwMjIgYXQgMDY6NDQ6MTBQTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB3 cm90ZToKPiAtIEZpeCBkZXNjcmlwdGlvbiBvZiBtZWRpYXRlayxtY20uIG1lZGlhdGVrLG1jbSBp cyBub3QgdXNlZCBvbiBNVDc2MjNOSS4KPiAtIEFkZCBkZXNjcmlwdGlvbiBmb3IgcmVzZXQtZ3Bp b3MuCj4gLSBJbnZhbGlkYXRlIHJlc2V0LWdwaW9zIGlmIG1lZGlhdGVrLG1jbSBpcyB1c2VkLgo+ IC0gSW52YWxpZGF0ZSBtZWRpYXRlayxtY20gaWYgdGhlIGNvbXBhdGlibGUgZGV2aWNlIGlzIG1l ZGlhdGVrLG10NzUzMS4KPiAtIFJlcXVpcmUgbWVkaWF0ZWssbWNtIGZvciB0aGUgZGVzY3JpYmVk IE1UNzYyMSBTb0NzIGFzIHRoZSBjb21wYXRpYmxlCj4gc3RyaW5nIGlzIG9ubHkgdXNlZCBmb3Ig TVQ3NTMwIHdoaWNoIGlzIGEgcGFydCBvZiB0aGUgbXVsdGktY2hpcCBtb2R1bGUuCgpUaGUgY29t bWl0IG1lc3NhZ2Ugc2hvdWxkIGFuc3dlciAnd2h5IGlzIHRoaXMgY2hhbmdlIG5lZWRlZC93YW50 ZWQ/JyBub3QgCid3aGF0IGNoYW5nZWQnLiBJIGNhbiByZWFkIHRoZSBkaWZmIHRvIHNlZSB3aGF0 IGNoYW5nZWQuCgpkPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFs QGFyaW5jOS5jb20+Cj4gLS0tCj4gIC4uLi9iaW5kaW5ncy9uZXQvZHNhL21lZGlhdGVrLG10NzUz MC55YW1sICAgICB8IDMxICsrKysrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI4 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvZHNhL21lZGlhdGVrLG10NzUzMC55YW1sIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9kc2EvbWVkaWF0ZWssbXQ3NTMw LnlhbWwKPiBpbmRleCBlZGY0OGU5MTcxNzMuLjRjOTkyNjZjZTgyYSAxMDA2NDQKPiAtLS0gYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2RzYS9tZWRpYXRlayxtdDc1MzAu eWFtbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvZHNhL21l ZGlhdGVrLG10NzUzMC55YW1sCj4gQEAgLTExMCwxMSArMTEwLDE1IEBAIHByb3BlcnRpZXM6Cj4g ICAgbWVkaWF0ZWssbWNtOgo+ICAgICAgdHlwZTogYm9vbGVhbgo+ICAgICAgZGVzY3JpcHRpb246 Cj4gLSAgICAgIGlmIGRlZmluZWQsIGluZGljYXRlcyB0aGF0IGVpdGhlciBNVDc1MzAgaXMgdGhl IHBhcnQgb24gbXVsdGktY2hpcAo+IC0gICAgICBtb2R1bGUgYmVsb25nIHRvIE1UNzYyM0EgaGFz IG9yIHRoZSByZW1vdGVseSBzdGFuZGFsb25lIGNoaXAgYXMgdGhlCj4gLSAgICAgIGZ1bmN0aW9u IE1UNzYyM04gcmVmZXJlbmNlIGJvYXJkIHByb3ZpZGVkIGZvci4KPiArICAgICAgVXNlZCBmb3Ig TVQ3NjIxQVQsIE1UNzYyMURBVCwgTVQ3NjIxU1QgYW5kIE1UNzYyM0FJIFNvQ3Mgd2hpY2ggdGhl IE1UNzUzMAo+ICsgICAgICBzd2l0Y2ggaXMgYSBwYXJ0IG9mIHRoZSBtdWx0aS1jaGlwIG1vZHVs ZS4KPiAgCj4gICAgcmVzZXQtZ3Bpb3M6Cj4gKyAgICBkZXNjcmlwdGlvbjoKPiArICAgICAgR1BJ TyB0byByZXNldCB0aGUgc3dpdGNoLiBVc2UgdGhpcyBpZiBtZWRpYXRlayxtY20gaXMgbm90IHVz ZWQuCj4gKyAgICAgIFRoaXMgcHJvcGVydHkgaXMgb3B0aW9uYWwgYmVjYXVzZSBzb21lIGJvYXJk cyBzaGFyZSB0aGUgcmVzZXQgbGluZSB3aXRoCj4gKyAgICAgIG90aGVyIGNvbXBvbmVudHMgd2hp Y2ggbWFrZXMgaXQgaW1wb3NzaWJsZSB0byBwcm9iZSB0aGUgc3dpdGNoIGlmIHRoZQo+ICsgICAg ICByZXNldCBsaW5lIGlzIHVzZWQuCj4gICAgICBtYXhJdGVtczogMQo+ICAKPiAgICByZXNldC1u YW1lczoKPiBAQCAtMTY1LDYgKzE2OSw5IEBAIGFsbE9mOgo+ICAgICAgICByZXF1aXJlZDoKPiAg ICAgICAgICAtIG1lZGlhdGVrLG1jbQo+ICAgICAgdGhlbjoKPiArICAgICAgcHJvcGVydGllczoK PiArICAgICAgICByZXNldC1ncGlvczogZmFsc2UKPiArCj4gICAgICAgIHJlcXVpcmVkOgo+ICAg ICAgICAgIC0gcmVzZXRzCj4gICAgICAgICAgLSByZXNldC1uYW1lcwo+IEBAIC0xODIsNiArMTg5 LDI0IEBAIGFsbE9mOgo+ICAgICAgICAgIC0gY29yZS1zdXBwbHkKPiAgICAgICAgICAtIGlvLXN1 cHBseQo+ICAKPiArICAtIGlmOgo+ICsgICAgICBwcm9wZXJ0aWVzOgo+ICsgICAgICAgIGNvbXBh dGlibGU6Cj4gKyAgICAgICAgICBpdGVtczoKPiArICAgICAgICAgICAgLSBjb25zdDogbWVkaWF0 ZWssbXQ3NTMxCj4gKyAgICB0aGVuOgo+ICsgICAgICBwcm9wZXJ0aWVzOgo+ICsgICAgICAgIG1l ZGlhdGVrLG1jbTogZmFsc2UKPiArCj4gKyAgLSBpZjoKPiArICAgICAgcHJvcGVydGllczoKPiAr ICAgICAgICBjb21wYXRpYmxlOgo+ICsgICAgICAgICAgaXRlbXM6Cj4gKyAgICAgICAgICAgIC0g Y29uc3Q6IG1lZGlhdGVrLG10NzYyMQo+ICsgICAgdGhlbjoKPiArICAgICAgcmVxdWlyZWQ6Cj4g KyAgICAgICAgLSBtZWRpYXRlayxtY20KPiArCj4gIHVuZXZhbHVhdGVkUHJvcGVydGllczogZmFs c2UKPiAgCj4gIGV4YW1wbGVzOgo+IC0tIAo+IDIuMzQuMQo+IAo+IAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26C6C25B0E for ; Tue, 16 Aug 2022 20:52:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237326AbiHPUwd (ORCPT ); Tue, 16 Aug 2022 16:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237243AbiHPUwc (ORCPT ); Tue, 16 Aug 2022 16:52:32 -0400 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB61489CE3; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) Received: by mail-il1-f181.google.com with SMTP id w8so2717511ilj.5; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=EzR+Z4kxn7o2P/WW6PzrWm03607DFyihBAzL1aumsm4=; b=GjShtAUEc0BZSPQ9pNFMz/GraxfeASnqn1kuCqNwxLjoztR7FgLf3yeeR7ghBJyfrp 5XT2kjcRTnWaDMektSjx1DrmqfRVXXTO/jRPV1EKMEDXq4Z1XEqEXMGCqfd92kR1p/4/ xurHAUmPl40+FuZoT8XzL+Nt+YKhQFir05g+7XbiNkDq1PguKqh8WFWYQy1RtLl1h9rr hmF0JrKKFUQNnjfTYmq7YkyfU40l/KZ+/ZjfTf0RTKqi6KYD+LL+gFPNApGBfB13TO2p eCSKdgazRkKnSbu+1ewhj6OZCk3EcXj9CfU9OWojGItGQgNEXjDSTT4E+iDp5i8KkZLD koxg== X-Gm-Message-State: ACgBeo0wirYwWXsJoahyphfgZmAvcOIC3DtYwX5EmeyyVGWfkmBiW1dA aQRHsyuRxbK7nmbqpJD+tg== X-Google-Smtp-Source: AA6agR4sGyiJKaOIlOFFnF0gqYNlu2XfR46u2ykdYGuFEEDs2T7qsaoxAPvnZ50uBGOOW7Z0yR8c2A== X-Received: by 2002:a05:6e02:18cd:b0:2de:73e8:3f0 with SMTP id s13-20020a056e0218cd00b002de73e803f0mr10622659ilu.69.1660683151102; Tue, 16 Aug 2022 13:52:31 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id v30-20020a02b09e000000b00339dbd4c8d7sm4780229jah.45.2022.08.16.13.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 13:52:30 -0700 (PDT) Received: (nullmailer pid 2713686 invoked by uid 1000); Tue, 16 Aug 2022 20:52:28 -0000 Date: Tue, 16 Aug 2022 14:52:28 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?iso-8859-1?Q?Ren=E9?= van Dorst , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines Message-ID: <20220816205228.GA2709277-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220813154415.349091-3-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Aug 13, 2022 at 06:44:10PM +0300, Arınç ÜNAL wrote: > - Fix description of mediatek,mcm. mediatek,mcm is not used on MT7623NI. > - Add description for reset-gpios. > - Invalidate reset-gpios if mediatek,mcm is used. > - Invalidate mediatek,mcm if the compatible device is mediatek,mt7531. > - Require mediatek,mcm for the described MT7621 SoCs as the compatible > string is only used for MT7530 which is a part of the multi-chip module. The commit message should answer 'why is this change needed/wanted?' not 'what changed'. I can read the diff to see what changed. d> > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 31 +++++++++++++++++-- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index edf48e917173..4c99266ce82a 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -110,11 +110,15 @@ properties: > mediatek,mcm: > type: boolean > description: > - if defined, indicates that either MT7530 is the part on multi-chip > - module belong to MT7623A has or the remotely standalone chip as the > - function MT7623N reference board provided for. > + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530 > + switch is a part of the multi-chip module. > > reset-gpios: > + description: > + GPIO to reset the switch. Use this if mediatek,mcm is not used. > + This property is optional because some boards share the reset line with > + other components which makes it impossible to probe the switch if the > + reset line is used. > maxItems: 1 > > reset-names: > @@ -165,6 +169,9 @@ allOf: > required: > - mediatek,mcm > then: > + properties: > + reset-gpios: false > + > required: > - resets > - reset-names > @@ -182,6 +189,24 @@ allOf: > - core-supply > - io-supply > > + - if: > + properties: > + compatible: > + items: > + - const: mediatek,mt7531 > + then: > + properties: > + mediatek,mcm: false > + > + - if: > + properties: > + compatible: > + items: > + - const: mediatek,mt7621 > + then: > + required: > + - mediatek,mcm > + > unevaluatedProperties: false > > examples: > -- > 2.34.1 > >