From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F3C4C25B0E for ; Tue, 16 Aug 2022 21:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+IOZgKwOUJ0yyXI/vD5VmeYlLJhpEL4ag2WpyQni1K8=; b=kYwLCcbaTdzDphX9KRsy6OEr4F JiqSiRDeYoDAOrHnZ/c9NGmQ+apNQ0w7POMbwoaYP1ior84yy4uKLgEmIMVYVFXOEx10I8rKAwmoZ SNcm3cKKpiUywtemQQ0DapbNp2A8OiHOB0Fq+u/LBYqb77SsMxiqPO2uJQSp98YZQLmRZU1QzfLiB HNzsH9z0vHrFxgtxmedBWC4lrxJdoTAceiWnlzFBSs/DOnMCtOEgHKIWxMz/HhJ5GtuONC51V4hyR 2FWVn/C3m3fgMmEhPE8f69KOXWaQfWapybbdSAw9KGqURQFVWTSNKcDxxvX3PjZwGVGmSUU0cHqgn PxDdUZlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3u6-0073Lq-DR; Tue, 16 Aug 2022 21:15:14 +0000 Received: from mail-io1-f41.google.com ([209.85.166.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3tv-0073Ck-EI; Tue, 16 Aug 2022 21:15:04 +0000 Received: by mail-io1-f41.google.com with SMTP id z72so506009iof.12; Tue, 16 Aug 2022 14:14:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=+IOZgKwOUJ0yyXI/vD5VmeYlLJhpEL4ag2WpyQni1K8=; b=66c8dihPl8SdybwOEyChlcgJfny7Wj6oQlhi6z4NmU0xCvQ/F3CLbIED2tGY1AyweQ h2db59wvQeGS+MPy6JW5l44vGdpQusuGqy5qVP+AhhsWIb1zYH/wIQbmU4tKaM+UYN+r 020Ib+qOACSiCQg6eT9gD6Q6lJrsLyqdeLNpTjRX4lyHsN2Wy3qKjnE8ZiZ+fD3VZh5v g/TdCZ/Q2QScPJ6Lu6VH7mcY/uIy1VHtJP6ky/JqyBVbFYcwSbLNAt/E0ejI197iDxaC kl6Lt6NDN/wabdMVZe+xlrsC3JqcqtozE1FDAFA4yTui50xWucSIPZictEkbyYw4Sy2C 6yBA== X-Gm-Message-State: ACgBeo23BwM7eVADEydZIIDhoE41O23EBR+382MNt07m+S7Dr6/AKyyv siZPqfVcNpTCP51NYj1l4fpgtbYxBw== X-Google-Smtp-Source: AA6agR6EQ8bauAwsr4ENQXhnGEColpXLl7hTdDigEdxvjsKeYgVLQhBqtACdoLlYH97bXvEZuHHIgQ== X-Received: by 2002:a05:6602:2b14:b0:67b:8976:2945 with SMTP id p20-20020a0566022b1400b0067b89762945mr9685592iov.82.1660684499157; Tue, 16 Aug 2022 14:14:59 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id o130-20020a022288000000b00343429c9cb6sm4841082jao.139.2022.08.16.14.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 14:14:58 -0700 (PDT) Received: (nullmailer pid 2744716 invoked by uid 1000); Tue, 16 Aug 2022 21:14:54 -0000 Date: Tue, 16 Aug 2022 15:14:54 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Subject: Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines Message-ID: <20220816211454.GA2734299-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-6-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220813154415.349091-6-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_141503_546182_875B18CC X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sander Vanheule , linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Ren=E9?= van Dorst , Eric Dumazet , Krzysztof Kozlowski , erkin.bozoglu@xeront.com, Florian Fainelli , Sergio Paracuellos , Jakub Kicinski , Paolo Abeni , Vivien Didelot , devicetree@vger.kernel.org, Landen Chao , Sean Wang , Luiz Angelo Daros de Luca , DENG Qingfang , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Daniel Golle , Vladimir Oltean , "David S . Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Aug 13, 2022 at 06:44:13PM +0300, Arınç ÜNAL wrote: > Remove unnecessary lines as they are already included from the referred > dsa.yaml. You are duplicating the schema and then removing parts twice. I would combine patches 4 and 5 or reverse the order. > > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 27 ------------------- > 1 file changed, 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index ff51a2f6875f..a27cb4fa490f 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -162,15 +162,8 @@ allOf: > > patternProperties: > "^(ethernet-)?ports$": > - type: object > - > patternProperties: > "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - > - unevaluatedProperties: false > - > properties: > reg: > description: > @@ -178,7 +171,6 @@ allOf: > 0 to 5 for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: This 'if' schema is the only part you need actually (though you have to create the node structure). > properties: > label: > @@ -186,7 +178,6 @@ allOf: > - const: cpu > then: > required: > - - reg > - phy-mode > > - if: > @@ -200,15 +191,8 @@ allOf: > > patternProperties: > "^(ethernet-)?ports$": > - type: object > - > patternProperties: > "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - > - unevaluatedProperties: false > - > properties: > reg: > description: > @@ -216,7 +200,6 @@ allOf: > 0 to 5 for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: > properties: > label: > @@ -224,7 +207,6 @@ allOf: > - const: cpu > then: > required: > - - reg > - phy-mode > > - if: > @@ -238,15 +220,8 @@ allOf: > > patternProperties: > "^(ethernet-)?ports$": > - type: object > - > patternProperties: > "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - > - unevaluatedProperties: false > - > properties: > reg: > description: > @@ -254,7 +229,6 @@ allOf: > 0 to 5 for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: > properties: > label: > @@ -262,7 +236,6 @@ allOf: > - const: cpu > then: > required: > - - reg > - phy-mode > > unevaluatedProperties: false > -- > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90C5C25B0E for ; Tue, 16 Aug 2022 21:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8GVIL2EDo+I9nduI2nOyOzS7IEMXT5q+pAbHFKn9Yns=; b=KaNO72ga9uALvi FHWDF2AUcg1ZTJNuVNtvOM3TL6IX2kaKgZd1kqrJ9s7x7fek+adaRGrf5zJ4ZRqQCb64yzLp1/H4T uEY/U2R3W4fjRdYMYAFQlRWNspzfXGaj8/j52hCnRFcAQjTcUpuUUhntTgRMxK9mRw+EsG3+IeqF4 KoZRcBr6dqeCZuM+o+tRbAhnZgjAw3Mtfyl8pkL/t/THoWj+ivQ+FQTiwwl9tZ2SOtKUjmQ5uqQ2s LEG08yrGkQ72NVSJdCA5Psgavdi2TRBv7KW3GkvgRfahqay/FU6DuLcg2YqN8ASGNrMCuxm4qmmAj 09136Uz+fISjdHRuuNKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3ty-0073Fz-DC; Tue, 16 Aug 2022 21:15:06 +0000 Received: from mail-io1-f41.google.com ([209.85.166.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oO3tv-0073Ck-EI; Tue, 16 Aug 2022 21:15:04 +0000 Received: by mail-io1-f41.google.com with SMTP id z72so506009iof.12; Tue, 16 Aug 2022 14:14:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=+IOZgKwOUJ0yyXI/vD5VmeYlLJhpEL4ag2WpyQni1K8=; b=66c8dihPl8SdybwOEyChlcgJfny7Wj6oQlhi6z4NmU0xCvQ/F3CLbIED2tGY1AyweQ h2db59wvQeGS+MPy6JW5l44vGdpQusuGqy5qVP+AhhsWIb1zYH/wIQbmU4tKaM+UYN+r 020Ib+qOACSiCQg6eT9gD6Q6lJrsLyqdeLNpTjRX4lyHsN2Wy3qKjnE8ZiZ+fD3VZh5v g/TdCZ/Q2QScPJ6Lu6VH7mcY/uIy1VHtJP6ky/JqyBVbFYcwSbLNAt/E0ejI197iDxaC kl6Lt6NDN/wabdMVZe+xlrsC3JqcqtozE1FDAFA4yTui50xWucSIPZictEkbyYw4Sy2C 6yBA== X-Gm-Message-State: ACgBeo23BwM7eVADEydZIIDhoE41O23EBR+382MNt07m+S7Dr6/AKyyv siZPqfVcNpTCP51NYj1l4fpgtbYxBw== X-Google-Smtp-Source: AA6agR6EQ8bauAwsr4ENQXhnGEColpXLl7hTdDigEdxvjsKeYgVLQhBqtACdoLlYH97bXvEZuHHIgQ== X-Received: by 2002:a05:6602:2b14:b0:67b:8976:2945 with SMTP id p20-20020a0566022b1400b0067b89762945mr9685592iov.82.1660684499157; Tue, 16 Aug 2022 14:14:59 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id o130-20020a022288000000b00343429c9cb6sm4841082jao.139.2022.08.16.14.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 14:14:58 -0700 (PDT) Received: (nullmailer pid 2744716 invoked by uid 1000); Tue, 16 Aug 2022 21:14:54 -0000 Date: Tue, 16 Aug 2022 15:14:54 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?iso-8859-1?Q?Ren=E9?= van Dorst , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines Message-ID: <20220816211454.GA2734299-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-6-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220813154415.349091-6-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_141503_546182_875B18CC X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBBdWcgMTMsIDIwMjIgYXQgMDY6NDQ6MTNQTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB3 cm90ZToKPiBSZW1vdmUgdW5uZWNlc3NhcnkgbGluZXMgYXMgdGhleSBhcmUgYWxyZWFkeSBpbmNs dWRlZCBmcm9tIHRoZSByZWZlcnJlZAo+IGRzYS55YW1sLgoKWW91IGFyZSBkdXBsaWNhdGluZyB0 aGUgc2NoZW1hIGFuZCB0aGVuIHJlbW92aW5nIHBhcnRzIHR3aWNlLiBJIHdvdWxkIApjb21iaW5l IHBhdGNoZXMgNCBhbmQgNSBvciByZXZlcnNlIHRoZSBvcmRlci4KCj4gCj4gU2lnbmVkLW9mZi1i eTogQXLEsW7DpyDDnE5BTCA8YXJpbmMudW5hbEBhcmluYzkuY29tPgo+IC0tLQo+ICAuLi4vYmlu ZGluZ3MvbmV0L2RzYS9tZWRpYXRlayxtdDc1MzAueWFtbCAgICAgfCAyNyAtLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9kc2EvbWVkaWF0ZWssbXQ3 NTMwLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2RzYS9tZWRp YXRlayxtdDc1MzAueWFtbAo+IGluZGV4IGZmNTFhMmY2ODc1Zi4uYTI3Y2I0ZmE0OTBmIDEwMDY0 NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvZHNhL21lZGlh dGVrLG10NzUzMC55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L25ldC9kc2EvbWVkaWF0ZWssbXQ3NTMwLnlhbWwKPiBAQCAtMTYyLDE1ICsxNjIsOCBAQCBhbGxP ZjoKPiAgCj4gICAgICAgIHBhdHRlcm5Qcm9wZXJ0aWVzOgo+ICAgICAgICAgICJeKGV0aGVybmV0 LSk/cG9ydHMkIjoKPiAtICAgICAgICAgIHR5cGU6IG9iamVjdAo+IC0KPiAgICAgICAgICAgIHBh dHRlcm5Qcm9wZXJ0aWVzOgo+ICAgICAgICAgICAgICAiXihldGhlcm5ldC0pP3BvcnRAWzAtOV0r JCI6Cj4gLSAgICAgICAgICAgICAgdHlwZTogb2JqZWN0Cj4gLSAgICAgICAgICAgICAgZGVzY3Jp cHRpb246IEV0aGVybmV0IHN3aXRjaCBwb3J0cwo+IC0KPiAtICAgICAgICAgICAgICB1bmV2YWx1 YXRlZFByb3BlcnRpZXM6IGZhbHNlCj4gLQo+ICAgICAgICAgICAgICAgIHByb3BlcnRpZXM6Cj4g ICAgICAgICAgICAgICAgICByZWc6Cj4gICAgICAgICAgICAgICAgICAgIGRlc2NyaXB0aW9uOgo+ IEBAIC0xNzgsNyArMTcxLDYgQEAgYWxsT2Y6Cj4gICAgICAgICAgICAgICAgICAgICAgMCB0byA1 IGZvciB1c2VyIHBvcnRzLgo+ICAKPiAgICAgICAgICAgICAgICBhbGxPZjoKPiAtICAgICAgICAg ICAgICAgIC0gJHJlZjogZHNhLXBvcnQueWFtbCMKPiAgICAgICAgICAgICAgICAgIC0gaWY6CgpU aGlzICdpZicgc2NoZW1hIGlzIHRoZSBvbmx5IHBhcnQgeW91IG5lZWQgYWN0dWFsbHkgKHRob3Vn aCB5b3UgaGF2ZSB0byAKY3JlYXRlIHRoZSBub2RlIHN0cnVjdHVyZSkuCgo+ICAgICAgICAgICAg ICAgICAgICAgIHByb3BlcnRpZXM6Cj4gICAgICAgICAgICAgICAgICAgICAgICBsYWJlbDoKPiBA QCAtMTg2LDcgKzE3OCw2IEBAIGFsbE9mOgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0g Y29uc3Q6IGNwdQo+ICAgICAgICAgICAgICAgICAgICB0aGVuOgo+ICAgICAgICAgICAgICAgICAg ICAgIHJlcXVpcmVkOgo+IC0gICAgICAgICAgICAgICAgICAgICAgLSByZWcKPiAgICAgICAgICAg ICAgICAgICAgICAgIC0gcGh5LW1vZGUKPiAgCj4gICAgLSBpZjoKPiBAQCAtMjAwLDE1ICsxOTEs OCBAQCBhbGxPZjoKPiAgCj4gICAgICAgIHBhdHRlcm5Qcm9wZXJ0aWVzOgo+ICAgICAgICAgICJe KGV0aGVybmV0LSk/cG9ydHMkIjoKPiAtICAgICAgICAgIHR5cGU6IG9iamVjdAo+IC0KPiAgICAg ICAgICAgIHBhdHRlcm5Qcm9wZXJ0aWVzOgo+ICAgICAgICAgICAgICAiXihldGhlcm5ldC0pP3Bv cnRAWzAtOV0rJCI6Cj4gLSAgICAgICAgICAgICAgdHlwZTogb2JqZWN0Cj4gLSAgICAgICAgICAg ICAgZGVzY3JpcHRpb246IEV0aGVybmV0IHN3aXRjaCBwb3J0cwo+IC0KPiAtICAgICAgICAgICAg ICB1bmV2YWx1YXRlZFByb3BlcnRpZXM6IGZhbHNlCj4gLQo+ICAgICAgICAgICAgICAgIHByb3Bl cnRpZXM6Cj4gICAgICAgICAgICAgICAgICByZWc6Cj4gICAgICAgICAgICAgICAgICAgIGRlc2Ny aXB0aW9uOgo+IEBAIC0yMTYsNyArMjAwLDYgQEAgYWxsT2Y6Cj4gICAgICAgICAgICAgICAgICAg ICAgMCB0byA1IGZvciB1c2VyIHBvcnRzLgo+ICAKPiAgICAgICAgICAgICAgICBhbGxPZjoKPiAt ICAgICAgICAgICAgICAgIC0gJHJlZjogZHNhLXBvcnQueWFtbCMKPiAgICAgICAgICAgICAgICAg IC0gaWY6Cj4gICAgICAgICAgICAgICAgICAgICAgcHJvcGVydGllczoKPiAgICAgICAgICAgICAg ICAgICAgICAgIGxhYmVsOgo+IEBAIC0yMjQsNyArMjA3LDYgQEAgYWxsT2Y6Cj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgLSBjb25zdDogY3B1Cj4gICAgICAgICAgICAgICAgICAgIHRoZW46 Cj4gICAgICAgICAgICAgICAgICAgICAgcmVxdWlyZWQ6Cj4gLSAgICAgICAgICAgICAgICAgICAg ICAtIHJlZwo+ICAgICAgICAgICAgICAgICAgICAgICAgLSBwaHktbW9kZQo+ICAKPiAgICAtIGlm Ogo+IEBAIC0yMzgsMTUgKzIyMCw4IEBAIGFsbE9mOgo+ICAKPiAgICAgICAgcGF0dGVyblByb3Bl cnRpZXM6Cj4gICAgICAgICAgIl4oZXRoZXJuZXQtKT9wb3J0cyQiOgo+IC0gICAgICAgICAgdHlw ZTogb2JqZWN0Cj4gLQo+ICAgICAgICAgICAgcGF0dGVyblByb3BlcnRpZXM6Cj4gICAgICAgICAg ICAgICJeKGV0aGVybmV0LSk/cG9ydEBbMC05XSskIjoKPiAtICAgICAgICAgICAgICB0eXBlOiBv YmplY3QKPiAtICAgICAgICAgICAgICBkZXNjcmlwdGlvbjogRXRoZXJuZXQgc3dpdGNoIHBvcnRz Cj4gLQo+IC0gICAgICAgICAgICAgIHVuZXZhbHVhdGVkUHJvcGVydGllczogZmFsc2UKPiAtCj4g ICAgICAgICAgICAgICAgcHJvcGVydGllczoKPiAgICAgICAgICAgICAgICAgIHJlZzoKPiAgICAg ICAgICAgICAgICAgICAgZGVzY3JpcHRpb246Cj4gQEAgLTI1NCw3ICsyMjksNiBAQCBhbGxPZjoK PiAgICAgICAgICAgICAgICAgICAgICAwIHRvIDUgZm9yIHVzZXIgcG9ydHMuCj4gIAo+ICAgICAg ICAgICAgICAgIGFsbE9mOgo+IC0gICAgICAgICAgICAgICAgLSAkcmVmOiBkc2EtcG9ydC55YW1s Iwo+ICAgICAgICAgICAgICAgICAgLSBpZjoKPiAgICAgICAgICAgICAgICAgICAgICBwcm9wZXJ0 aWVzOgo+ICAgICAgICAgICAgICAgICAgICAgICAgbGFiZWw6Cj4gQEAgLTI2Miw3ICsyMzYsNiBA QCBhbGxPZjoKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAtIGNvbnN0OiBjcHUKPiAgICAg ICAgICAgICAgICAgICAgdGhlbjoKPiAgICAgICAgICAgICAgICAgICAgICByZXF1aXJlZDoKPiAt ICAgICAgICAgICAgICAgICAgICAgIC0gcmVnCj4gICAgICAgICAgICAgICAgICAgICAgICAtIHBo eS1tb2RlCj4gIAo+ICB1bmV2YWx1YXRlZFByb3BlcnRpZXM6IGZhbHNlCj4gLS0gCj4gMi4zNC4x Cj4gCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0336BC32792 for ; Tue, 16 Aug 2022 21:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237483AbiHPVPC (ORCPT ); Tue, 16 Aug 2022 17:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237476AbiHPVPB (ORCPT ); Tue, 16 Aug 2022 17:15:01 -0400 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46F0A7E805; Tue, 16 Aug 2022 14:15:00 -0700 (PDT) Received: by mail-io1-f52.google.com with SMTP id b142so6345783iof.10; Tue, 16 Aug 2022 14:15:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=+IOZgKwOUJ0yyXI/vD5VmeYlLJhpEL4ag2WpyQni1K8=; b=mPZKmh6XwLy/LRLGGeF9hNHBhOxfe/wYc6vAnPLmc4E7k9waDDxLQ9+bucM9KXsBzC +dzaRW9uniY1rjM4icZ0GqAkM6avJJqimfaNu3VOKRkcMDiH15zPRs+xI+seClREwYiV BvG+Wx/hayJPRhuxtWDAAdYfgOEsMNFuN8K5nnMw32R2i/dOPOva5s1BAj1cryuPwdac C6HnAhCEIH0Kb9sCUPwhNvze+pImowJB+WmwYCJErXF0FzoMpNzU7eUYd9ZcRNR1xG56 gKOEeR3YLaD99UOiVoivUnNPr/KiraB5tnTEcyjGo+KquYzmlfMf5FmzgB0oIz4Q0iaz Sjuw== X-Gm-Message-State: ACgBeo3P1OchT96Ly8F6s/sWF49gK8eakJF1nYhWctmIgVA6Ubm8ChSU ipHGb1aalwXBqM2Nbh8Ipw== X-Google-Smtp-Source: AA6agR6EQ8bauAwsr4ENQXhnGEColpXLl7hTdDigEdxvjsKeYgVLQhBqtACdoLlYH97bXvEZuHHIgQ== X-Received: by 2002:a05:6602:2b14:b0:67b:8976:2945 with SMTP id p20-20020a0566022b1400b0067b89762945mr9685592iov.82.1660684499157; Tue, 16 Aug 2022 14:14:59 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id o130-20020a022288000000b00343429c9cb6sm4841082jao.139.2022.08.16.14.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 14:14:58 -0700 (PDT) Received: (nullmailer pid 2744716 invoked by uid 1000); Tue, 16 Aug 2022 21:14:54 -0000 Date: Tue, 16 Aug 2022 15:14:54 -0600 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?iso-8859-1?Q?Ren=E9?= van Dorst , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines Message-ID: <20220816211454.GA2734299-robh@kernel.org> References: <20220813154415.349091-1-arinc.unal@arinc9.com> <20220813154415.349091-6-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220813154415.349091-6-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Aug 13, 2022 at 06:44:13PM +0300, Arınç ÜNAL wrote: > Remove unnecessary lines as they are already included from the referred > dsa.yaml. You are duplicating the schema and then removing parts twice. I would combine patches 4 and 5 or reverse the order. > > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 27 ------------------- > 1 file changed, 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index ff51a2f6875f..a27cb4fa490f 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -162,15 +162,8 @@ allOf: > > patternProperties: > "^(ethernet-)?ports$": > - type: object > - > patternProperties: > "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - > - unevaluatedProperties: false > - > properties: > reg: > description: > @@ -178,7 +171,6 @@ allOf: > 0 to 5 for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: This 'if' schema is the only part you need actually (though you have to create the node structure). > properties: > label: > @@ -186,7 +178,6 @@ allOf: > - const: cpu > then: > required: > - - reg > - phy-mode > > - if: > @@ -200,15 +191,8 @@ allOf: > > patternProperties: > "^(ethernet-)?ports$": > - type: object > - > patternProperties: > "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - > - unevaluatedProperties: false > - > properties: > reg: > description: > @@ -216,7 +200,6 @@ allOf: > 0 to 5 for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: > properties: > label: > @@ -224,7 +207,6 @@ allOf: > - const: cpu > then: > required: > - - reg > - phy-mode > > - if: > @@ -238,15 +220,8 @@ allOf: > > patternProperties: > "^(ethernet-)?ports$": > - type: object > - > patternProperties: > "^(ethernet-)?port@[0-9]+$": > - type: object > - description: Ethernet switch ports > - > - unevaluatedProperties: false > - > properties: > reg: > description: > @@ -254,7 +229,6 @@ allOf: > 0 to 5 for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: > properties: > label: > @@ -262,7 +236,6 @@ allOf: > - const: cpu > then: > required: > - - reg > - phy-mode > > unevaluatedProperties: false > -- > 2.34.1 > >