Re: [Buildroot] [PATCH 1/3] support/testing/tests/package/test_python_boto3: use ext2 instead of cpio

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Tue, 16 Aug 2022 18:26:26 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> >  class TestPythonPy3Boto3(TestPythonPackageBase):
> > @@ -7,6 +8,17 @@ class TestPythonPy3Boto3(TestPythonPackageBase):
> >          """
> >          BR2_PACKAGE_PYTHON3=y
> >          BR2_PACKAGE_PYTHON_BOTO3=y
> > +        BR2_TARGET_ROOTFS_EXT2=y
> > +        BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> > +        # BR2_TARGET_ROOTFS_TAR is not set  
> 
> BR2_TARGET_ROOTFS_TAR is already unset in TestPythonPackageBase.config,
> so disabling it here is superfluous.

Ah indeed.

> But this will however still build the cpio archive, because it is
> enabled in TestPythonPackageBase.config.
> 
> We can disable it with:
> 
>     class TestPythonPy3Boto3(TestPythonPackageBase):
>         config = TestPythonPackageBase.config.replace('BR2_TARGET_ROOTFS_CPIO=y\n', '') + \
>             """
>             blablabla
>             """
> 
> If you believe that it is acceptable, I can fix when applying. Or we can
> continue to uselessly build the cpio archive, which does not take very
> long to assemble...

I think we can continue to uselessly build the cpio archive. As I said,
my long term proposal would rather be to switch all tests to use ext2 +
a hard drive. We still need to define an image size, but at least we
can a hard and clear error if the filesystem no longer fits rather than
these weird errors caused by initramfs being partially uncompressed.

Thanks for the review!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot