From: Francisco Iglesias <frasse.iglesias@gmail.com>
To: Anton Kochkov <anton.kochkov@proton.me>
Cc: qemu-devel@nongnu.org, Pavel Pisa <pisa@cmp.felk.cvut.cz>,
Vikram Garhwal <fnu.vikram@xilinx.com>,
Francisco Iglesias <francisco.iglesias@xilinx.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH] can: fix Xilinx ZynqMP CAN RX FIFO logic
Date: Wed, 17 Aug 2022 11:50:54 +0200 [thread overview]
Message-ID: <20220817095053.GA4571@fralle-msi> (raw)
In-Reply-To: <20220812172420.1946484-1-anton.kochkov@proton.me>
On [2022 Aug 12] Fri 17:25:28, Anton Kochkov wrote:
> Function "update_rx_fifo()" should operate on the RX FIFO
> registers, not the TX FIFO ones.
Hi Anton,
Should we update the git commit message to say this is done for readability /
keeping it consistent? (the defines have the same values)
Otherwise:
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Best regards,
Francisco Iglesias
>
> Signed-off-by: Anton Kochkov <anton.kochkov@proton.me>
> Resolves: https://gitlab.com/qemu-projects/qemu/-/issues/1123
> ---
> hw/net/can/xlnx-zynqmp-can.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/hw/net/can/xlnx-zynqmp-can.c b/hw/net/can/xlnx-zynqmp-can.c
> index 82ac48cee2..e93e6c5e19 100644
> --- a/hw/net/can/xlnx-zynqmp-can.c
> +++ b/hw/net/can/xlnx-zynqmp-can.c
> @@ -696,30 +696,30 @@ static void update_rx_fifo(XlnxZynqMPCANState *s, const qemu_can_frame *frame)
> timestamp));
>
> /* First 32 bit of the data. */
> - fifo32_push(&s->rx_fifo, deposit32(0, R_TXFIFO_DATA1_DB3_SHIFT,
> - R_TXFIFO_DATA1_DB3_LENGTH,
> + fifo32_push(&s->rx_fifo, deposit32(0, R_RXFIFO_DATA1_DB3_SHIFT,
> + R_RXFIFO_DATA1_DB3_LENGTH,
> frame->data[0]) |
> - deposit32(0, R_TXFIFO_DATA1_DB2_SHIFT,
> - R_TXFIFO_DATA1_DB2_LENGTH,
> + deposit32(0, R_RXFIFO_DATA1_DB2_SHIFT,
> + R_RXFIFO_DATA1_DB2_LENGTH,
> frame->data[1]) |
> - deposit32(0, R_TXFIFO_DATA1_DB1_SHIFT,
> - R_TXFIFO_DATA1_DB1_LENGTH,
> + deposit32(0, R_RXFIFO_DATA1_DB1_SHIFT,
> + R_RXFIFO_DATA1_DB1_LENGTH,
> frame->data[2]) |
> - deposit32(0, R_TXFIFO_DATA1_DB0_SHIFT,
> - R_TXFIFO_DATA1_DB0_LENGTH,
> + deposit32(0, R_RXFIFO_DATA1_DB0_SHIFT,
> + R_RXFIFO_DATA1_DB0_LENGTH,
> frame->data[3]));
> /* Last 32 bit of the data. */
> - fifo32_push(&s->rx_fifo, deposit32(0, R_TXFIFO_DATA2_DB7_SHIFT,
> - R_TXFIFO_DATA2_DB7_LENGTH,
> + fifo32_push(&s->rx_fifo, deposit32(0, R_RXFIFO_DATA2_DB7_SHIFT,
> + R_RXFIFO_DATA2_DB7_LENGTH,
> frame->data[4]) |
> - deposit32(0, R_TXFIFO_DATA2_DB6_SHIFT,
> - R_TXFIFO_DATA2_DB6_LENGTH,
> + deposit32(0, R_RXFIFO_DATA2_DB6_SHIFT,
> + R_RXFIFO_DATA2_DB6_LENGTH,
> frame->data[5]) |
> - deposit32(0, R_TXFIFO_DATA2_DB5_SHIFT,
> - R_TXFIFO_DATA2_DB5_LENGTH,
> + deposit32(0, R_RXFIFO_DATA2_DB5_SHIFT,
> + R_RXFIFO_DATA2_DB5_LENGTH,
> frame->data[6]) |
> - deposit32(0, R_TXFIFO_DATA2_DB4_SHIFT,
> - R_TXFIFO_DATA2_DB4_LENGTH,
> + deposit32(0, R_RXFIFO_DATA2_DB4_SHIFT,
> + R_RXFIFO_DATA2_DB4_LENGTH,
> frame->data[7]));
>
> ARRAY_FIELD_DP32(s->regs, INTERRUPT_STATUS_REGISTER, RXOK, 1);
> --
> 2.37.1
>
>
>
prev parent reply other threads:[~2022-08-17 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 17:25 [PATCH] can: fix Xilinx ZynqMP CAN RX FIFO logic Anton Kochkov
2022-08-17 9:50 ` Francisco Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817095053.GA4571@fralle-msi \
--to=frasse.iglesias@gmail.com \
--cc=anton.kochkov@proton.me \
--cc=fnu.vikram@xilinx.com \
--cc=francisco.iglesias@xilinx.com \
--cc=jasowang@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.