From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F961C32772 for ; Wed, 17 Aug 2022 20:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yhpRKXTYm6izrDe0g5H3qXluCtX/7WdRGuWEdQ3d64s=; b=hzO5+/qzjt1AH2 /O7ldo9Ehe3l3rYtQx5AB9yUTyS55Ya57Lxxu8qEP8yfRFBIvYNOJ+SfTCuonPiKGg0N2gG4EvER0 q1JNtNVubiOtqqC6mD0pv8BecRfPU9dXAWU2mrEojAzLgzA78ACKWUlf82V76SzqzrFzs1z44e9ip g8c7jkxaynstFui+ZjaABe9oRBikbIXqbE8CHKaxCiOz+5Ayf6y3zDH9Xfp9UpyffP8YLDJXr5v7p w+k2uDxtMnUUuzjUUD3eXLCvhIVPZtiErbQWqBBzldxWBpCM+GvWA2I+yRLCCBxpJYdjEwzJrt72x BTd/XvqMRJXa0DL/pILw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOPGc-0065Po-Rn; Wed, 17 Aug 2022 20:03:54 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOPGa-0065NZ-Ey for linux-phy@lists.infradead.org; Wed, 17 Aug 2022 20:03:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0848A614EE; Wed, 17 Aug 2022 20:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6340CC43470; Wed, 17 Aug 2022 20:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660766631; bh=SNZ70vt4bNjbtH48RRhcFsT0HkyKYDhAfV/NNF8Sj9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=taN9Qch78MvSeXbDyWhIPR+suwZFNPzyZmAzLyaR8NSXf4mh7CdyLT7HVxlXTnPNq T/i1I8SetYLuOCZkc2llJ3tcbeIPqTr0ehmxYsJOjjVvF0c8+a7ajJ3QjE+b/9e+7f r9k6dPFiBV9QJP6TypHRyedePbioXwEtckP3Qdz+fIShsVIIW2fr3W2CxSGN7stVLq 5BRjY4Te5NT9sd8GO5i4YGbKHiZc/pOGu19BP1yEHJMFNT1LcwPOX82Or3HscGafKt bbMEGjFAPBlHqKea0D5eQu6L5hWRWQ1D1nfxltwTKwJPmDm9xuV6BlO/ijoCjxnYzR mRB3pVzkAtsrw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Vinod Koul , Kishon Vijay Abraham I , Linux Phy , Gregory Clement Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Kees Cook , Sakari Ailus , linux-kernel@vger.kernel.org, pali@kernel.org, josef.schlehofer@nic.cz, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH linux-phy v2 4/4] arm64: dts: armada-3720-turris-mox: Change comphy tx amplitude for 2500base-x mode Date: Wed, 17 Aug 2022 22:03:35 +0200 Message-Id: <20220817200335.911-5-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220817200335.911-1-kabel@kernel.org> References: <20220817200335.911-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220817_130352_588190_F1E0D2EC X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Q2hhbmdlIGNvbXBoeSB0cmFuc21pdCBhbXBsaXR1ZGUgdG8gMTAyNSBtViBmb3IgMjUwMGJhc2Ut eCBtb2RlIG9uCmNvbXBoeSBjb25uZWN0ZWQgdG8gVG9wYXouCgpUaGlzIGZpeGVzIGlzc3VlIHdo ZXJlaW4gaWYgdGhlIDhiLzEwYiBlbmNvZGVkIHBhY2tldCBjb250YWlucyBhIGxvbmcKZW5vdWdo IGFsdGVybmF0aW5nIHNlcXVlbmNlIG9mIGJpdHMgKDAxMDEwMS4uLiBvciAxMDEwMTAuLi4pLCB3 aGljaApoYXBwZW5zIGlmIHRoZSBwYWNrZXQgY29udGFpbnMgYSBzZXF1ZW5jZSBvZiAnSicgb3Ig J1x4YjUnIGJ5dGVzLCB0aGUKcGFja2V0IG1heSBiZSBsb3N0IHdoZW4gc2VudCBmcm9tIEEzNzIw IHRvIFRvcGF6IGR1ZSB0byBGQ1MgZXJyb3IuIFRoZQpwcm9iYWJpbGl0eSBvZiBsb3NzIGdyb3dz IHdpdGggdGhlIG51bWJlciBvZiAnSidzIHdpdGggZGVmYXVsdCB0cmFuc21pdAphbXBsaXR1ZGUg c2V0dGluZyAtIHdpdGggMTE0ICdKJ3MgdGhlIHByb2JhYmlsaXR5IGlzIGFib3V0IDUwJSwgd2l0 aCAxMjUKJ0oncyBhbG1vc3QgMTAwJSBvZiBwYWNrZXRzICBhcmUgbG9zdC4KCkZpeGVzOiA3MTA5 ZDgxN2RiMmUgKCJhcm02NDogZHRzOiBtYXJ2ZWxsOiBhZGQgRFRTIGZvciBUdXJyaXMgTW94IikK U2lnbmVkLW9mZi1ieTogTWFyZWsgQmVow7puIDxrYWJlbEBrZXJuZWwub3JnPgotLS0KIGFyY2gv YXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyMC10dXJyaXMtbW94LmR0cyB8IDEwICsr KysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv YXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzIGIv YXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzCmlu ZGV4IGFkYTE2NGQ0MjNmMy4uNzRhN2FjMWY4ZWNiIDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2Jv b3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3MjAtdHVycmlzLW1veC5kdHMKKysrIGIvYXJjaC9hcm02 NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRzCkBAIC0xODEsNiAr MTgxLDE2IEBAICZldGgxIHsKIAlwaHlzID0gPCZjb21waHkwIDE+OwogfTsKIAorJmNvbXBoeTAg eworCS8qCisJICogU2V0IHBlYWsgdG8gcGVhayB0cmFuc21pdCBhbXBsaXR1ZGUgdG8gMTAyNSBt ViB0byBmaXggaXNzdWUgd2hlcmVpbgorCSAqIGEgcGFja2V0IG1heSBiZSBsb3N0IGlmIGl0IGNv bnRhaW5zIGEgbG9uZyBlbm91Z2ggc2VxdWVuY2Ugb2YgJ0onCisJICogb3IgJ1x4YjUnIGJ5dGVz LgorCSAqLworCXR4LXAycC1taWNyb3ZvbHQgPSA8MTAyNTAwMD47CisJdHgtcDJwLW1pY3Jvdm9s dC1uYW1lcyA9ICIyNTAwYmFzZS14IjsKK307CisKICZzZGhjaTAgewogCXdwLWludmVydGVkOwog CWJ1cy13aWR0aCA9IDw0PjsKLS0gCjIuMzUuMQoKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0 CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED6EC2BB41 for ; Wed, 17 Aug 2022 20:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241697AbiHQUED (ORCPT ); Wed, 17 Aug 2022 16:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241680AbiHQUDy (ORCPT ); Wed, 17 Aug 2022 16:03:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA1C27B05 for ; Wed, 17 Aug 2022 13:03:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68DB56151E for ; Wed, 17 Aug 2022 20:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6340CC43470; Wed, 17 Aug 2022 20:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660766631; bh=SNZ70vt4bNjbtH48RRhcFsT0HkyKYDhAfV/NNF8Sj9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=taN9Qch78MvSeXbDyWhIPR+suwZFNPzyZmAzLyaR8NSXf4mh7CdyLT7HVxlXTnPNq T/i1I8SetYLuOCZkc2llJ3tcbeIPqTr0ehmxYsJOjjVvF0c8+a7ajJ3QjE+b/9e+7f r9k6dPFiBV9QJP6TypHRyedePbioXwEtckP3Qdz+fIShsVIIW2fr3W2CxSGN7stVLq 5BRjY4Te5NT9sd8GO5i4YGbKHiZc/pOGu19BP1yEHJMFNT1LcwPOX82Or3HscGafKt bbMEGjFAPBlHqKea0D5eQu6L5hWRWQ1D1nfxltwTKwJPmDm9xuV6BlO/ijoCjxnYzR mRB3pVzkAtsrw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Vinod Koul , Kishon Vijay Abraham I , Linux Phy , Gregory Clement Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Kees Cook , Sakari Ailus , linux-kernel@vger.kernel.org, pali@kernel.org, josef.schlehofer@nic.cz, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH linux-phy v2 4/4] arm64: dts: armada-3720-turris-mox: Change comphy tx amplitude for 2500base-x mode Date: Wed, 17 Aug 2022 22:03:35 +0200 Message-Id: <20220817200335.911-5-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220817200335.911-1-kabel@kernel.org> References: <20220817200335.911-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change comphy transmit amplitude to 1025 mV for 2500base-x mode on comphy connected to Topaz. This fixes issue wherein if the 8b/10b encoded packet contains a long enough alternating sequence of bits (010101... or 101010...), which happens if the packet contains a sequence of 'J' or '\xb5' bytes, the packet may be lost when sent from A3720 to Topaz due to FCS error. The probability of loss grows with the number of 'J's with default transmit amplitude setting - with 114 'J's the probability is about 50%, with 125 'J's almost 100% of packets are lost. Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox") Signed-off-by: Marek Behún --- arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts index ada164d423f3..74a7ac1f8ecb 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts @@ -181,6 +181,16 @@ ð1 { phys = <&comphy0 1>; }; +&comphy0 { + /* + * Set peak to peak transmit amplitude to 1025 mV to fix issue wherein + * a packet may be lost if it contains a long enough sequence of 'J' + * or '\xb5' bytes. + */ + tx-p2p-microvolt = <1025000>; + tx-p2p-microvolt-names = "2500base-x"; +}; + &sdhci0 { wp-inverted; bus-width = <4>; -- 2.35.1