From: Jakub Kicinski <kuba@kernel.org>
To: Manish Chopra <manishc@marvell.com>
Cc: Bruno Goncalves <bgoncalv@redhat.com>,
Ariel Elior <aelior@marvell.com>,
LKML <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
CKI Project <cki-project@redhat.com>,
Saurav Kashyap <skashyap@marvell.com>,
Javed Hasan <jhasan@marvell.com>, Alok Prasad <palok@marvell.com>
Subject: Re: [EXT] Re: RIP: 0010:qede_load+0x128d/0x13b0 [qede] - 5.19.0
Date: Thu, 18 Aug 2022 11:26:37 -0700 [thread overview]
Message-ID: <20220818112637.58101fe6@kernel.org> (raw)
In-Reply-To: <BY3PR18MB4612295606F0C22A1863FF44AB6D9@BY3PR18MB4612.namprd18.prod.outlook.com>
On Thu, 18 Aug 2022 17:55:28 +0000 Manish Chopra wrote:
> 3. You mentioned about commit 3aa6bce9af0e ("net: watchdog: hold device global xmit lock during tx disable")
FWIW that was just my guess based on the stack trace, Bruno posted the
stacktraces with line numbers decoded here:
https://lore.kernel.org/all/CA+QYu4ob4cbh3Vnh9DWgaPpyw8nTLFG__TbBpBsYg1tWJPxygg@mail.gmail.com/
> Do you mean issue started surfacing only after this commit ? Driver calls netif_tx_disable() from these two relevant contexts -
>
> a. One in ndo_stop() flow
>
> /* Close OS Tx */
> netif_tx_disable(edev->ndev);
> netif_carrier_off(edev->ndev);
>
> b. Other in LINK events handling from the hard IRQ context
>
> DP_NOTICE(edev, "Link is down\n");
> netif_tx_disable(edev->ndev);
> netif_carrier_off(edev->ndev);
next prev parent reply other threads:[~2022-08-18 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 11:27 RIP: 0010:qede_load+0x128d/0x13b0 [qede] - 5.19.0 Bruno Goncalves
2022-08-02 19:23 ` Jakub Kicinski
2022-08-03 12:13 ` Bruno Goncalves
2022-08-03 15:37 ` Jakub Kicinski
2022-08-18 7:22 ` Bruno Goncalves
2022-08-18 15:51 ` Jakub Kicinski
2022-08-18 17:55 ` [EXT] " Manish Chopra
2022-08-18 18:26 ` Jakub Kicinski [this message]
2022-08-19 7:36 ` Bruno Goncalves
2023-02-22 21:34 ` Jakub Kicinski
2023-02-23 15:16 ` Bruno Goncalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818112637.58101fe6@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=bgoncalv@redhat.com \
--cc=cki-project@redhat.com \
--cc=jhasan@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=palok@marvell.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.