From: Florian Westphal <fw@strlen.de>
To: Xiao Liang <shaw.leon@gmail.com>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft] src: Don't parse string as verdict in map
Date: Thu, 18 Aug 2022 15:32:31 +0200 [thread overview]
Message-ID: <20220818133231.GB24008@breakpoint.cc> (raw)
In-Reply-To: <20220818100623.22601-1-shaw.leon@gmail.com>
Xiao Liang <shaw.leon@gmail.com> wrote:
> In verdict map, string values are accidentally treated as verdicts.
>
> For example:
> table ip t {
> map foo {
> type mark : verdict
> elements = {
> 0 : bar
> }
> }
> }
> The value "bar" is sent to kernel as verdict.
>
> Indeed, we don't parse verdicts during evaluation, but only chains,
> which is of type string rather than verdict.
Can you explain what this is fixing?
This reverts the commit that adds support for defines as aliases:
commit c64457cff9673fbb41f613a67e158b4d62235c09
src: Allow goto and jump to a variable
next prev parent reply other threads:[~2022-08-18 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 10:06 [PATCH nft] src: Don't parse string as verdict in map Xiao Liang
2022-08-18 13:32 ` Florian Westphal [this message]
2022-08-18 16:02 ` Xiao Liang
2022-08-18 16:34 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818133231.GB24008@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=shaw.leon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.