From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F400EC00140 for ; Thu, 18 Aug 2022 12:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244533AbiHRMWv (ORCPT ); Thu, 18 Aug 2022 08:22:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240115AbiHRMWu (ORCPT ); Thu, 18 Aug 2022 08:22:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37564B2770 for ; Thu, 18 Aug 2022 05:22:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C296761544 for ; Thu, 18 Aug 2022 12:22:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BC69C433D6; Thu, 18 Aug 2022 12:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660825368; bh=ypGy+78z9aSf176hU+tuxIxoLIa6YEaBBm70dka6Ncs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BNRiO//6a8chENw36zV6KCwIaSqWGe3dFUJRNJpE/jIlZ4mWSdcfTJCPGR7hPjDfI /4XoHJl3rTQsz0Gm1MxrDu+cmM+EuUVELuRlAH7eH7gM5DdjyzRdtLb2nMBIji+Bo3 YgaRPvSNmpYmJszFmcdq+c631NcA1efPeNGGqb/nGHDXIbPAeBQnXQSMYP6j3qC6Je Sc2ZKQafacTV7Ueo88XXbUXSVgCiy0zIZfKzh02Uk2T72K5WoaX2xbibnCduoBp7K4 MJc8zjrW4NySVdKwjATxqmTUIMBE/6mNsKCvw3bMLptqEDu4wEfycBe5p3dHx1W4Xv bIYWfnIaE+Z9A== Date: Thu, 18 Aug 2022 14:22:43 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Lukas Wunner Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof Wilczy??ski , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 06/18] PCI: pciehp: Enable DLLSC interrupt only if supported Message-ID: <20220818142243.4c046c59@dellmb> In-Reply-To: <20220514091400.GA20725@wunner.de> References: <20220220193346.23789-1-kabel@kernel.org> <20220220193346.23789-7-kabel@kernel.org> <20220509034216.GA26780@wunner.de> <20220513165729.wuaatfr2drsjwoos@pali> <20220514091400.GA20725@wunner.de> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, 14 May 2022 11:14:00 +0200 Lukas Wunner wrote: > On Fri, May 13, 2022 at 06:57:29PM +0200, Pali Roh=C3=A1r wrote: > > To answer your questions: Config space of Aardvark Root Port does not > > conform to PCIe base spec. It does not implement DLLLARC, nor DLLSCE and > > lot of other bits. Plus it has Type 0 header (not Type 1). And due to > > these reasons, pci-aardvark.c driver implements "emulation" of the > > Root Port and implements some of the functionality via custom aardvark > > registers. So Root Port would be presented to kernel and also to > > userspace as PCI Bridge device with Type 1 header and with PCIe > > registers required by linux kernel. > >=20 > > During my testing of kernel hotplug code last year, I figured out that > > kernel was waiting for event which never happened. And so it was needed > > to "fix" kernel to not try to enable DLLSCE because it did nothing. =20 >=20 > Could you please reproduce this and add the following on the command line: >=20 > log_buf_len=3D10M pciehp.pciehp_debug=3D1 dyndbg=3D"file pciehp* +p" > ignore_loglevel >=20 > Then open a bug at bugzilla.kernel.org, attach full dmesg output > as well as full "lspci -vv" output and send the bugzilla link to me. >=20 > (Obviously, revert patches 6 and 7 when trying to reproduce it.) >=20 > So a PDC event should be sufficient to bring the slot up or down, > a DLLSC event should not be necessary. Enabling DLLSC should not > make a difference on a controller which doesn't support it. > I just double-checked the code and I do not see where we'd wait > for a DLLSC event which never comes. >=20 > Don't worry, if we come to the conclusion that your proposed fix > is the only solution, I'm fine with it, but at this point I'd > like to get a better understanding what is really going on. > Perhaps there is some other issue in pciehp that this patch > just papers over. Once you provide the dmesg debug output > I'll be able to analyze that. Dear Lukas, we have tried to reproduce the bug where kernel was waiting for an event which never happend, the bug that Pali remembered from his work on the pciehp code. We have concluded that it doesn't concert the DLLSC patch (06/18), only the Command Completed Interrupt patch (07/18), and even there it seems that the patch is not needed to trigger the bug: it seems that when Pali was studying the bug, he did two things: 1. he made enabling Command Completed Interrupt conditional on NCCS bit not set 2. he made the aardvark driver report NCCS bit via emulated bridge. It turns out that only the second thing is needed, since the pciehp code checks NCCS bit in pcie_wait_cmd() and does not wait for the interrupt if NCCS is set. Anyway we still think that both patches make sense, at least so that an interrupt isn't reported as enabled and not supported at once when dumping the configuration space. So I will resend these patches with updated commit messages. Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87FDCC00140 for ; Thu, 18 Aug 2022 12:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EyRd++0N4YdLGJnCI7H21GS4q9ifcVWvd4mbPYeQ/0k=; b=KRwN/C0FotkL8i E1Z2f4H7ePmfSXstoZs7FBXNCOPzXO4sdYHbLoN0Ik1x5qIWU2iKiY30ys7hRPgP9juoprtt6Ehpc PERXnHcQVV3+mtVeTkoGsuCLz8zqZ/vRDZURdQUkYIvNRBw3/l6hFbB7wX/gy+/R/cOlUsOdX99CT abRan/EUcQS9lS8gHOHs4bH6BW9HVmN9XsdaUrbCE54BL7FKI7TYXk0Bcq28Ir5FoMxCzKiOuG9Fp qGF2SsNEEfI8HOjNbk4fhVJziA+AFCuNCZg1ewc8v/Pq2E1ZJMjvhlr9gLexWxWbkRj9L0uZsyMbe ZMmSgokly/R01khHQCwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOeY0-004UFh-1T; Thu, 18 Aug 2022 12:22:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oOeXx-004UF4-96 for linux-arm-kernel@lists.infradead.org; Thu, 18 Aug 2022 12:22:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C60F16135B; Thu, 18 Aug 2022 12:22:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BC69C433D6; Thu, 18 Aug 2022 12:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660825368; bh=ypGy+78z9aSf176hU+tuxIxoLIa6YEaBBm70dka6Ncs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BNRiO//6a8chENw36zV6KCwIaSqWGe3dFUJRNJpE/jIlZ4mWSdcfTJCPGR7hPjDfI /4XoHJl3rTQsz0Gm1MxrDu+cmM+EuUVELuRlAH7eH7gM5DdjyzRdtLb2nMBIji+Bo3 YgaRPvSNmpYmJszFmcdq+c631NcA1efPeNGGqb/nGHDXIbPAeBQnXQSMYP6j3qC6Je Sc2ZKQafacTV7Ueo88XXbUXSVgCiy0zIZfKzh02Uk2T72K5WoaX2xbibnCduoBp7K4 MJc8zjrW4NySVdKwjATxqmTUIMBE/6mNsKCvw3bMLptqEDu4wEfycBe5p3dHx1W4Xv bIYWfnIaE+Z9A== Date: Thu, 18 Aug 2022 14:22:43 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Lukas Wunner Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Lorenzo Pieralisi , Bjorn Helgaas , Krzysztof Wilczy??ski , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 06/18] PCI: pciehp: Enable DLLSC interrupt only if supported Message-ID: <20220818142243.4c046c59@dellmb> In-Reply-To: <20220514091400.GA20725@wunner.de> References: <20220220193346.23789-1-kabel@kernel.org> <20220220193346.23789-7-kabel@kernel.org> <20220509034216.GA26780@wunner.de> <20220513165729.wuaatfr2drsjwoos@pali> <20220514091400.GA20725@wunner.de> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220818_052249_439197_D6745EEA X-CRM114-Status: GOOD ( 35.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAxNCBNYXkgMjAyMiAxMToxNDowMCArMDIwMApMdWthcyBXdW5uZXIgPGx1a2FzQHd1 bm5lci5kZT4gd3JvdGU6Cgo+IE9uIEZyaSwgTWF5IDEzLCAyMDIyIGF0IDA2OjU3OjI5UE0gKzAy MDAsIFBhbGkgUm9ow6FyIHdyb3RlOgo+ID4gVG8gYW5zd2VyIHlvdXIgcXVlc3Rpb25zOiBDb25m aWcgc3BhY2Ugb2YgQWFyZHZhcmsgUm9vdCBQb3J0IGRvZXMgbm90Cj4gPiBjb25mb3JtIHRvIFBD SWUgYmFzZSBzcGVjLiBJdCBkb2VzIG5vdCBpbXBsZW1lbnQgRExMTEFSQywgbm9yIERMTFNDRSBh bmQKPiA+IGxvdCBvZiBvdGhlciBiaXRzLiBQbHVzIGl0IGhhcyBUeXBlIDAgaGVhZGVyIChub3Qg VHlwZSAxKS4gQW5kIGR1ZSB0bwo+ID4gdGhlc2UgcmVhc29ucywgcGNpLWFhcmR2YXJrLmMgZHJp dmVyIGltcGxlbWVudHMgImVtdWxhdGlvbiIgb2YgdGhlCj4gPiBSb290IFBvcnQgYW5kIGltcGxl bWVudHMgc29tZSBvZiB0aGUgZnVuY3Rpb25hbGl0eSB2aWEgY3VzdG9tIGFhcmR2YXJrCj4gPiBy ZWdpc3RlcnMuIFNvIFJvb3QgUG9ydCB3b3VsZCBiZSBwcmVzZW50ZWQgdG8ga2VybmVsIGFuZCBh bHNvIHRvCj4gPiB1c2Vyc3BhY2UgYXMgUENJIEJyaWRnZSBkZXZpY2Ugd2l0aCBUeXBlIDEgaGVh ZGVyIGFuZCB3aXRoIFBDSWUKPiA+IHJlZ2lzdGVycyByZXF1aXJlZCBieSBsaW51eCBrZXJuZWwu Cj4gPiAKPiA+IER1cmluZyBteSB0ZXN0aW5nIG9mIGtlcm5lbCBob3RwbHVnIGNvZGUgbGFzdCB5 ZWFyLCBJIGZpZ3VyZWQgb3V0IHRoYXQKPiA+IGtlcm5lbCB3YXMgd2FpdGluZyBmb3IgZXZlbnQg d2hpY2ggbmV2ZXIgaGFwcGVuZWQuIEFuZCBzbyBpdCB3YXMgbmVlZGVkCj4gPiB0byAiZml4IiBr ZXJuZWwgdG8gbm90IHRyeSB0byBlbmFibGUgRExMU0NFIGJlY2F1c2UgaXQgZGlkIG5vdGhpbmcu ICAKPiAKPiBDb3VsZCB5b3UgcGxlYXNlIHJlcHJvZHVjZSB0aGlzIGFuZCBhZGQgdGhlIGZvbGxv d2luZyBvbiB0aGUgY29tbWFuZCBsaW5lOgo+IAo+ICAgbG9nX2J1Zl9sZW49MTBNIHBjaWVocC5w Y2llaHBfZGVidWc9MSBkeW5kYmc9ImZpbGUgcGNpZWhwKiArcCIKPiAgIGlnbm9yZV9sb2dsZXZl bAo+IAo+IFRoZW4gb3BlbiBhIGJ1ZyBhdCBidWd6aWxsYS5rZXJuZWwub3JnLCBhdHRhY2ggZnVs bCBkbWVzZyBvdXRwdXQKPiBhcyB3ZWxsIGFzIGZ1bGwgImxzcGNpIC12diIgb3V0cHV0IGFuZCBz ZW5kIHRoZSBidWd6aWxsYSBsaW5rIHRvIG1lLgo+IAo+IChPYnZpb3VzbHksIHJldmVydCBwYXRj aGVzIDYgYW5kIDcgd2hlbiB0cnlpbmcgdG8gcmVwcm9kdWNlIGl0LikKPiAKPiBTbyBhIFBEQyBl dmVudCBzaG91bGQgYmUgc3VmZmljaWVudCB0byBicmluZyB0aGUgc2xvdCB1cCBvciBkb3duLAo+ IGEgRExMU0MgZXZlbnQgc2hvdWxkIG5vdCBiZSBuZWNlc3NhcnkuICBFbmFibGluZyBETExTQyBz aG91bGQgbm90Cj4gbWFrZSBhIGRpZmZlcmVuY2Ugb24gYSBjb250cm9sbGVyIHdoaWNoIGRvZXNu J3Qgc3VwcG9ydCBpdC4KPiBJIGp1c3QgZG91YmxlLWNoZWNrZWQgdGhlIGNvZGUgYW5kIEkgZG8g bm90IHNlZSB3aGVyZSB3ZSdkIHdhaXQKPiBmb3IgYSBETExTQyBldmVudCB3aGljaCBuZXZlciBj b21lcy4KPiAKPiBEb24ndCB3b3JyeSwgaWYgd2UgY29tZSB0byB0aGUgY29uY2x1c2lvbiB0aGF0 IHlvdXIgcHJvcG9zZWQgZml4Cj4gaXMgdGhlIG9ubHkgc29sdXRpb24sIEknbSBmaW5lIHdpdGgg aXQsIGJ1dCBhdCB0aGlzIHBvaW50IEknZAo+IGxpa2UgdG8gZ2V0IGEgYmV0dGVyIHVuZGVyc3Rh bmRpbmcgd2hhdCBpcyByZWFsbHkgZ29pbmcgb24uCj4gUGVyaGFwcyB0aGVyZSBpcyBzb21lIG90 aGVyIGlzc3VlIGluIHBjaWVocCB0aGF0IHRoaXMgcGF0Y2gKPiBqdXN0IHBhcGVycyBvdmVyLiAg T25jZSB5b3UgcHJvdmlkZSB0aGUgZG1lc2cgZGVidWcgb3V0cHV0Cj4gSSdsbCBiZSBhYmxlIHRv IGFuYWx5emUgdGhhdC4KCkRlYXIgTHVrYXMsCgp3ZSBoYXZlIHRyaWVkIHRvIHJlcHJvZHVjZSB0 aGUgYnVnIHdoZXJlIGtlcm5lbCB3YXMgd2FpdGluZyBmb3IgYW4KZXZlbnQgd2hpY2ggbmV2ZXIg aGFwcGVuZCwgdGhlIGJ1ZyB0aGF0IFBhbGkgcmVtZW1iZXJlZCBmcm9tIGhpcwp3b3JrIG9uIHRo ZSBwY2llaHAgY29kZS4KCldlIGhhdmUgY29uY2x1ZGVkIHRoYXQgaXQgZG9lc24ndCBjb25jZXJ0 IHRoZSBETExTQyBwYXRjaCAoMDYvMTgpLCBvbmx5CnRoZSBDb21tYW5kIENvbXBsZXRlZCBJbnRl cnJ1cHQgcGF0Y2ggKDA3LzE4KSwgYW5kIGV2ZW4gdGhlcmUgaXQgc2VlbXMKdGhhdCB0aGUgcGF0 Y2ggaXMgbm90IG5lZWRlZCB0byB0cmlnZ2VyIHRoZSBidWc6IGl0IHNlZW1zIHRoYXQgd2hlbgpQ YWxpIHdhcyBzdHVkeWluZyB0aGUgYnVnLCBoZSBkaWQgdHdvIHRoaW5nczoKMS4gaGUgbWFkZSBl bmFibGluZyBDb21tYW5kIENvbXBsZXRlZCBJbnRlcnJ1cHQgY29uZGl0aW9uYWwgb24gTkNDUyBi aXQKICAgbm90ICBzZXQKMi4gaGUgbWFkZSB0aGUgYWFyZHZhcmsgZHJpdmVyIHJlcG9ydCBOQ0NT IGJpdCB2aWEgZW11bGF0ZWQgYnJpZGdlLgoKSXQgdHVybnMgb3V0IHRoYXQgb25seSB0aGUgc2Vj b25kIHRoaW5nIGlzIG5lZWRlZCwgc2luY2UgdGhlIHBjaWVocApjb2RlIGNoZWNrcyBOQ0NTIGJp dCBpbiBwY2llX3dhaXRfY21kKCkgYW5kIGRvZXMgbm90IHdhaXQgZm9yIHRoZQppbnRlcnJ1cHQg aWYgTkNDUyBpcyBzZXQuCgpBbnl3YXkgd2Ugc3RpbGwgdGhpbmsgdGhhdCBib3RoIHBhdGNoZXMg bWFrZSBzZW5zZSwgYXQgbGVhc3Qgc28gdGhhdCBhbgppbnRlcnJ1cHQgaXNuJ3QgcmVwb3J0ZWQg YXMgZW5hYmxlZCBhbmQgbm90IHN1cHBvcnRlZCBhdCBvbmNlIHdoZW4KZHVtcGluZyB0aGUgY29u ZmlndXJhdGlvbiBzcGFjZS4KClNvIEkgd2lsbCByZXNlbmQgdGhlc2UgcGF0Y2hlcyB3aXRoIHVw ZGF0ZWQgY29tbWl0IG1lc3NhZ2VzLgoKTWFyZWsKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK