From: "Pali Rohár" <pali@kernel.org>
To: "Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Marek Behún" <kabel@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] leds: syscon: Implement support for active-low property
Date: Thu, 18 Aug 2022 19:25:28 +0200 [thread overview]
Message-ID: <20220818172528.23062-2-pali@kernel.org> (raw)
In-Reply-To: <20220818172528.23062-1-pali@kernel.org>
This new active-low property specify that LED has inverted logic
(0 - enable LED, 1 - disable LED).
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/leds/leds-syscon.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
index 7eddb8ecb44e..5e605d8438e9 100644
--- a/drivers/leds/leds-syscon.c
+++ b/drivers/leds/leds-syscon.c
@@ -29,6 +29,7 @@ struct syscon_led {
struct regmap *map;
u32 offset;
u32 mask;
+ bool active_low;
bool state;
};
@@ -41,10 +42,10 @@ static void syscon_led_set(struct led_classdev *led_cdev,
int ret;
if (value == LED_OFF) {
- val = 0;
+ val = sled->active_low ? sled->mask : 0;
sled->state = false;
} else {
- val = sled->mask;
+ val = sled->active_low ? 0 : sled->mask;
sled->state = true;
}
@@ -85,6 +86,8 @@ static int syscon_led_probe(struct platform_device *pdev)
return -EINVAL;
if (of_property_read_u32(np, "mask", &sled->mask))
return -EINVAL;
+ if (of_find_property(np, "active-low", NULL))
+ sled->active_low = true;
state = of_get_property(np, "default-state", NULL);
if (state) {
@@ -95,17 +98,20 @@ static int syscon_led_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
sled->state = !!(val & sled->mask);
+ if (sled->active_low)
+ sled->state = !sled->state;
} else if (!strcmp(state, "on")) {
sled->state = true;
ret = regmap_update_bits(map, sled->offset,
sled->mask,
- sled->mask);
+ sled->active_low ? 0 : sled->mask);
if (ret < 0)
return ret;
} else {
sled->state = false;
ret = regmap_update_bits(map, sled->offset,
- sled->mask, 0);
+ sled->mask,
+ sled->active_low ? sled->mask : 0);
if (ret < 0)
return ret;
}
--
2.20.1
next prev parent reply other threads:[~2022-08-18 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 17:25 [PATCH 1/2] dt-bindings: leds: register-bit-led: Add active-low property Pali Rohár
2022-08-18 17:25 ` Pali Rohár [this message]
2022-08-26 8:05 ` [PATCH 2/2] leds: syscon: Implement support for " Linus Walleij
2022-08-31 11:49 ` Pali Rohár
2022-10-09 11:40 ` Pali Rohár
2022-11-01 22:32 ` Pali Rohár
2022-11-08 12:42 ` Linus Walleij
2022-08-19 6:46 ` [PATCH 1/2] dt-bindings: leds: register-bit-led: Add " Krzysztof Kozlowski
2022-08-19 6:56 ` Pali Rohár
2022-08-19 8:08 ` Pavel Machek
2022-08-19 8:38 ` Krzysztof Kozlowski
2022-08-19 8:42 ` Pali Rohár
2022-08-19 9:08 ` Krzysztof Kozlowski
2022-08-19 9:11 ` Pali Rohár
2022-08-19 8:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818172528.23062-2-pali@kernel.org \
--to=pali@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.