From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, corbet@lwn.net,
stephen@networkplumber.org, sdf@google.com,
ecree.xilinx@gmail.com, benjamin.poirier@gmail.com,
idosch@idosch.org, f.fainelli@gmail.com, jiri@resnulli.us,
dsahern@kernel.org, fw@strlen.de, linux-doc@vger.kernel.org,
jhs@mojatatu.com, tgraf@suug.ch, jacob.e.keller@intel.com,
svinota.saveliev@gmail.com
Subject: Re: [PATCH net-next 2/2] docs: netlink: basic introduction to Netlink
Date: Fri, 19 Aug 2022 12:16:04 -0700 [thread overview]
Message-ID: <20220819121604.04d365c3@kernel.org> (raw)
In-Reply-To: <fa41284993d7e1c629b829ec40fdbbd4d68cbed7.camel@sipsolutions.net>
On Fri, 19 Aug 2022 21:07:36 +0200 Johannes Berg wrote:
> > The notification contains the same information as the response to the
> > ``CTRL_CMD_GETFAMILY`` request. It is most common for "new object"
> > notifications to contain the same exact data as the respective ``GET``.
>
> I might say we should remove that second sentence - this is one of those
> murky cases where it's actually sometimes not _possible_ to do due to
> message size limitations etc.
>
> That said, it's still common, so maybe that's OK, "common" doesn't mean
> "always" and some notifications might obviously differ even if it's
> common.
I'll rephrase, I'll just say that in this case it's the same message.
> > The socket will now receive notifications. It is recommended to use
> > a separate sockets for receiving notifications and sending requests
> > to the kernel. The asynchronous nature of notifications means that
> > they may get mixed in with the responses making the parsing much
> > harder.
>
> Not sure I'd say "parsing" here, maybe "message handling"? I mean, it's
> not really about parsing the messages, more about the potentially
> interleaved sequence of handling them. But maybe I'm splitting hairs :)
Yup, that's better. Let me revisit this paragraph, it doesn't read too
smoothly :S
next prev parent reply other threads:[~2022-08-19 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 2:35 [PATCH net-next 1/2] net: improve and fix netlink kdoc Jakub Kicinski
2022-08-18 2:35 ` [PATCH net-next 2/2] docs: netlink: basic introduction to Netlink Jakub Kicinski
2022-08-18 4:05 ` Stanislav Fomichev
2022-08-19 3:13 ` Jakub Kicinski
2022-08-18 7:36 ` Johannes Berg
2022-08-19 16:20 ` Jakub Kicinski
2022-08-19 16:57 ` Johannes Berg
2022-08-19 17:54 ` Jakub Kicinski
2022-08-19 19:07 ` Johannes Berg
2022-08-19 19:16 ` Jakub Kicinski [this message]
2022-08-19 19:16 ` Jakub Kicinski
2022-08-19 19:20 ` Johannes Berg
2022-08-18 21:01 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819121604.04d365c3@kernel.org \
--to=kuba@kernel.org \
--cc=benjamin.poirier@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=idosch@idosch.org \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=stephen@networkplumber.org \
--cc=svinota.saveliev@gmail.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.