From: Jakub Kicinski <kuba@kernel.org>
To: Sean Anderson <sean.anderson@seco.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net] net: phy: Warn if phy is attached when removing
Date: Fri, 19 Aug 2022 16:45:19 -0700 [thread overview]
Message-ID: <20220819164519.2c71823e@kernel.org> (raw)
In-Reply-To: <20220816163701.1578850-1-sean.anderson@seco.com>
On Tue, 16 Aug 2022 12:37:01 -0400 Sean Anderson wrote:
> netdevs using phylib can be oopsed from userspace in the following
> manner:
>
> $ ip link set $iface up
> $ echo $(basename $(readlink /sys/class/net/$iface/phydev)) > \
> /sys/class/net/$iface/phydev/driver/unbind
> $ ip link set $iface down
>
> However, the traceback provided is a bit too late, since it does not
> capture the root of the problem (unbinding the driver). It's also
> possible that the memory has been reallocated if sufficient time passes
> between when the phy is detached and when the netdev touches the phy
> (which could result in silent memory corruption). Add a warning at the
> source of the problem. A future patch could make this more robust by
> calling dev_close.
FWIW, I think DaveM marked this patch as changes requested.
I don't really know enough to have an opinion.
PHY maintainers, anyone willing to cast a vote?
next prev parent reply other threads:[~2022-08-19 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 16:37 [PATCH net] net: phy: Warn if phy is attached when removing Sean Anderson
2022-08-18 17:24 ` Jakub Kicinski
2022-08-18 17:32 ` Sean Anderson
2022-08-19 23:45 ` Jakub Kicinski [this message]
2022-08-20 0:20 ` Russell King (Oracle)
2022-08-22 16:00 ` Sean Anderson
2022-08-22 16:32 ` Russell King (Oracle)
2022-08-22 17:02 ` Sean Anderson
2022-08-22 17:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819164519.2c71823e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.