From: Florian Westphal <fw@strlen.de>
To: Balazs Scheidler <bazsi77@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>,
Shell Chen <xierch@gmail.com>
Subject: Re: [PATCH nf] nefilter: nft_tproxy: restrict to prerouting hook
Date: Sat, 20 Aug 2022 21:21:59 +0200 [thread overview]
Message-ID: <20220820192159.GA27967@breakpoint.cc> (raw)
In-Reply-To: <CAKcfE+ZnxmsecpZe5V3jmBT9W6UC52UjDBt78L7jMK9ujHn3wA@mail.gmail.com>
Balazs Scheidler <bazsi77@gmail.com> wrote:
> I think this is not correct. TPROXY can be used from output as well to
> divert locally generated traffic. I didn't look into the output null
> reference case posted earlier but that's also a use case to redirect local
> output to a proxy.
Are you sure?
The upstreamed TPROXY doesn't support this.
xt_TPROXY sets:
.hooks = 1 << NF_INET_PRE_ROUTING,
and the backend code assumes that the inout device in the hook state is
available, which is only guaranteed in prerouting and input hooks.
prev parent reply other threads:[~2022-08-20 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 14:04 [BUG] nft_tproxy: Null pointer dereference on local-send UDP Shell Chen
2022-08-20 15:54 ` [PATCH nf] nefilter: nft_tproxy: restrict to prerouting hook Florian Westphal
[not found] ` <CAKcfE+ZnxmsecpZe5V3jmBT9W6UC52UjDBt78L7jMK9ujHn3wA@mail.gmail.com>
2022-08-20 19:21 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820192159.GA27967@breakpoint.cc \
--to=fw@strlen.de \
--cc=bazsi77@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=xierch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.