[meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Andrei Gherzan]

From: Andrei Gherzan <andrei.gherzan@huawei.com>

This recipe explicitely rdepends on glibc so trying to build this with
musl will break world builds.

Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
---
 recipes-containers/singularity/singularity_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/recipes-containers/singularity/singularity_git.bb b/recipes-containers/singularity/singularity_git.bb
index 321a9a6..8e7ab76 100644
--- a/recipes-containers/singularity/singularity_git.bb
+++ b/recipes-containers/singularity/singularity_git.bb
@@ -28,3 +28,5 @@ pkg_postinst:${PN}() {
     rm -r $D${libdir}/ssl/certs
     ln -sr $D${sysconfdir}/ssl/certs $D${libdir}/ssl
 }
+
+COMPATIBLE_HOST:libc-musl:class-target = "null"
-- 
2.25.1

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Khem Raj]

On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>
> From: Andrei Gherzan <andrei.gherzan@huawei.com>
>
> This recipe explicitely rdepends on glibc so trying to build this with
> musl will break world builds.
>

do you know why is it marked as glibc only.

> Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
> ---
>  recipes-containers/singularity/singularity_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/recipes-containers/singularity/singularity_git.bb b/recipes-containers/singularity/singularity_git.bb
> index 321a9a6..8e7ab76 100644
> --- a/recipes-containers/singularity/singularity_git.bb
> +++ b/recipes-containers/singularity/singularity_git.bb
> @@ -28,3 +28,5 @@ pkg_postinst:${PN}() {
>      rm -r $D${libdir}/ssl/certs
>      ln -sr $D${sysconfdir}/ssl/certs $D${libdir}/ssl
>  }
> +
> +COMPATIBLE_HOST:libc-musl:class-target = "null"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7526): https://lists.yoctoproject.org/g/meta-virtualization/message/7526
> Mute This Topic: https://lists.yoctoproject.org/mt/93078736/1997914
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Andrei Gherzan]

On Wed, 17 Aug 2022, at 15:09, Khem Raj wrote:
> On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>>
>> From: Andrei Gherzan <andrei.gherzan@huawei.com>
>>
>> This recipe explicitely rdepends on glibc so trying to build this with
>> musl will break world builds.
>>
>
> do you know why is it marked as glibc only.

I've tried to figure it out but I couldn't find anything obvious.

https://git.yoctoproject.org/meta-virtualization/commit/recipes-containers/singularity/singularity_git.bb?id=06bc17d1f0650ad2cb134b09b25133bcd641d473

Andrei

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Khem Raj]

On Wed, Aug 17, 2022 at 7:15 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>
> On Wed, 17 Aug 2022, at 15:09, Khem Raj wrote:
> > On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> >>
> >> From: Andrei Gherzan <andrei.gherzan@huawei.com>
> >>
> >> This recipe explicitely rdepends on glibc so trying to build this with
> >> musl will break world builds.
> >>
> >
> > do you know why is it marked as glibc only.
>
> I've tried to figure it out but I couldn't find anything obvious.
>
> https://git.yoctoproject.org/meta-virtualization/commit/recipes-containers/singularity/singularity_git.bb?id=06bc17d1f0650ad2cb134b09b25133bcd641d473
>

maybe that rdep on glibc is bogus. Its not normal to depends on glibc
like that, in some cases e.g. locales etc it maybe that we need them
but thats usually for ptests etc.
can you try to remove the rdep and see if it builds ok with musl too ?

> Andrei

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Andrei Gherzan]

On Wed, 17 Aug 2022, at 15:59, Khem Raj wrote:
> On Wed, Aug 17, 2022 at 7:15 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>>
>> On Wed, 17 Aug 2022, at 15:09, Khem Raj wrote:
>> > On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>> >>
>> >> From: Andrei Gherzan <andrei.gherzan@huawei.com>
>> >>
>> >> This recipe explicitely rdepends on glibc so trying to build this with
>> >> musl will break world builds.
>> >>
>> >
>> > do you know why is it marked as glibc only.
>>
>> I've tried to figure it out but I couldn't find anything obvious.
>>
>> https://git.yoctoproject.org/meta-virtualization/commit/recipes-containers/singularity/singularity_git.bb?id=06bc17d1f0650ad2cb134b09b25133bcd641d473
>>
>
> maybe that rdep on glibc is bogus. Its not normal to depends on glibc
> like that, in some cases e.g. locales etc it maybe that we need them
> but thats usually for ptests etc.
> can you try to remove the rdep and see if it builds ok with musl too ?

It built alright but I didn't check any runtime behaviour. I do find this a bit orthogonal at this point but I've sent both patches so Bruce can pick any - both approaches are working for me.

Andrei

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Khem Raj]

On Wed, Aug 17, 2022 at 9:38 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>
> On Wed, 17 Aug 2022, at 15:59, Khem Raj wrote:
> > On Wed, Aug 17, 2022 at 7:15 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> >>
> >> On Wed, 17 Aug 2022, at 15:09, Khem Raj wrote:
> >> > On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> >> >>
> >> >> From: Andrei Gherzan <andrei.gherzan@huawei.com>
> >> >>
> >> >> This recipe explicitely rdepends on glibc so trying to build this with
> >> >> musl will break world builds.
> >> >>
> >> >
> >> > do you know why is it marked as glibc only.
> >>
> >> I've tried to figure it out but I couldn't find anything obvious.
> >>
> >> https://git.yoctoproject.org/meta-virtualization/commit/recipes-containers/singularity/singularity_git.bb?id=06bc17d1f0650ad2cb134b09b25133bcd641d473
> >>
> >
> > maybe that rdep on glibc is bogus. Its not normal to depends on glibc
> > like that, in some cases e.g. locales etc it maybe that we need them
> > but thats usually for ptests etc.
> > can you try to remove the rdep and see if it builds ok with musl too ?
>
> It built alright but I didn't check any runtime behaviour. I do find this a bit orthogonal at this point but I've sent both patches so Bruce can pick any - both approaches are working for me.
>

Well not orthogonal I would say but alternate solution to what this
patch is trying to fix, if you remove glibc from the rdeps then this
patch is not needed

> Andrei
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7538): https://lists.yoctoproject.org/g/meta-virtualization/message/7538
> Mute This Topic: https://lists.yoctoproject.org/mt/93078736/1997914
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Bruce Ashfield]

In message: Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds
on 17/08/2022 Andrei Gherzan wrote:

> On Wed, 17 Aug 2022, at 15:59, Khem Raj wrote:
> > On Wed, Aug 17, 2022 at 7:15 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> >>
> >> On Wed, 17 Aug 2022, at 15:09, Khem Raj wrote:
> >> > On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> >> >>
> >> >> From: Andrei Gherzan <andrei.gherzan@huawei.com>
> >> >>
> >> >> This recipe explicitely rdepends on glibc so trying to build this with
> >> >> musl will break world builds.
> >> >>
> >> >
> >> > do you know why is it marked as glibc only.
> >>
> >> I've tried to figure it out but I couldn't find anything obvious.
> >>
> >> https://git.yoctoproject.org/meta-virtualization/commit/recipes-containers/singularity/singularity_git.bb?id=06bc17d1f0650ad2cb134b09b25133bcd641d473
> >>
> >
> > maybe that rdep on glibc is bogus. Its not normal to depends on glibc
> > like that, in some cases e.g. locales etc it maybe that we need them
> > but thats usually for ptests etc.
> > can you try to remove the rdep and see if it builds ok with musl too ?
> 
> It built alright but I didn't check any runtime behaviour. I do find this a bit orthogonal at this point but I've sent both patches so Bruce can pick any - both approaches are working for me.

I've gone for the removal of the glibc dep, singluarity needs quite a bit of
runtime work .. so we'll do with that, and see if anyone notices.

merged to master and kirkstone.

Bruce

> 
> Andrei

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7538): https://lists.yoctoproject.org/g/meta-virtualization/message/7538
> Mute This Topic: https://lists.yoctoproject.org/mt/93078736/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [meta-virtualization][PATCH] singularity: Skip recipe on musl builds

[Andrei Gherzan]

On Sun, 21 Aug 2022, at 04:21, Bruce Ashfield wrote:
> In message: Re: [meta-virtualization][PATCH] singularity: Skip recipe 
> on musl builds
> on 17/08/2022 Andrei Gherzan wrote:
>
>> On Wed, 17 Aug 2022, at 15:59, Khem Raj wrote:
>> > On Wed, Aug 17, 2022 at 7:15 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>> >>
>> >> On Wed, 17 Aug 2022, at 15:09, Khem Raj wrote:
>> >> > On Wed, Aug 17, 2022 at 4:51 AM Andrei Gherzan <andrei@gherzan.com> wrote:
>> >> >>
>> >> >> From: Andrei Gherzan <andrei.gherzan@huawei.com>
>> >> >>
>> >> >> This recipe explicitely rdepends on glibc so trying to build this with
>> >> >> musl will break world builds.
>> >> >>
>> >> >
>> >> > do you know why is it marked as glibc only.
>> >>
>> >> I've tried to figure it out but I couldn't find anything obvious.
>> >>
>> >> https://git.yoctoproject.org/meta-virtualization/commit/recipes-containers/singularity/singularity_git.bb?id=06bc17d1f0650ad2cb134b09b25133bcd641d473
>> >>
>> >
>> > maybe that rdep on glibc is bogus. Its not normal to depends on glibc
>> > like that, in some cases e.g. locales etc it maybe that we need them
>> > but thats usually for ptests etc.
>> > can you try to remove the rdep and see if it builds ok with musl too ?
>> 
>> It built alright but I didn't check any runtime behaviour. I do find this a bit orthogonal at this point but I've sent both patches so Bruce can pick any - both approaches are working for me.
>
> I've gone for the removal of the glibc dep, singluarity needs quite a bit of
> runtime work .. so we'll do with that, and see if anyone notices.
>
> merged to master and kirkstone.

Thanks, Bruce.

Andrei