From: Christoph Hellwig <hch@lst.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH blktests v3 2/6] nbd/rc: load nbd module explicitly
Date: Sun, 21 Aug 2022 07:48:26 +0200 [thread overview]
Message-ID: <20220821054826.GA25878@lst.de> (raw)
In-Reply-To: <20220819093920.84992-3-shinichiro.kawasaki@wdc.com>
On Fri, Aug 19, 2022 at 06:39:16PM +0900, Shin'ichiro Kawasaki wrote:
> After the commit "common/rc: avoid module load in _have_driver()",
> _have_driver() no longer loads specified module. However, nbd test cases
> and _have_nbd_netlink() function assume that the module is loaded by
> calling _have_driver(). This causes test case failures and unexpected
> skips. To fix them, load and unload modules explicitly in functions
> _start_nbd_server*(), _stop_nbd_server*() and _have_nbd_netlink().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-08-21 5:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 9:39 [PATCH blktests v3 0/6] fix module check issues Shin'ichiro Kawasaki
2022-08-19 9:39 ` [PATCH blktests v3 1/6] common/rc: avoid module load in _have_driver() Shin'ichiro Kawasaki
2022-08-19 14:54 ` Bart Van Assche
2022-08-19 9:39 ` [PATCH blktests v3 2/6] nbd/rc: load nbd module explicitly Shin'ichiro Kawasaki
2022-08-21 5:48 ` Christoph Hellwig [this message]
2022-08-19 9:39 ` [PATCH blktests v3 3/6] common/rc: ensure modules are loadable in _have_modules() Shin'ichiro Kawasaki
2022-08-21 5:48 ` Christoph Hellwig
2022-08-19 9:39 ` [PATCH blktests v3 4/6] common,tests: replace _have_driver() with _have_drivers() Shin'ichiro Kawasaki
2022-08-21 5:49 ` Christoph Hellwig
2022-08-22 6:25 ` Shinichiro Kawasaki
2022-08-19 9:39 ` [PATCH blktests v3 5/6] block/001: use _have_drivers() in place of _have_modules() Shin'ichiro Kawasaki
2022-08-19 9:39 ` [PATCH blktests v3 6/6] srp/rc: allow test with built-in sd_mod and sg drivers Shin'ichiro Kawasaki
2022-08-19 14:54 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821054826.GA25878@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.