From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, abhishek.shah@columbia.edu
Subject: Re: [PATCH nf] netfilter: nf_tables: make table handle allocation per-netns friendly
Date: Sun, 21 Aug 2022 11:44:58 +0200 [thread overview]
Message-ID: <20220821094458.GC11586@breakpoint.cc> (raw)
In-Reply-To: <20220821085939.571378-1-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> mutex is per-netns, move table_netns to the pernet area.
>
> *read-write* to 0xffffffff883a01e8 of 8 bytes by task 6542 on cpu 0:
> nf_tables_newtable+0x6dc/0xc00 net/netfilter/nf_tables_api.c:1221
> nfnetlink_rcv_batch net/netfilter/nfnetlink.c:513 [inline]
> nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:634 [inline]
> nfnetlink_rcv+0xa6a/0x13a0 net/netfilter/nfnetlink.c:652
> netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
> netlink_unicast+0x652/0x730 net/netlink/af_netlink.c:1345
> netlink_sendmsg+0x643/0x740 net/netlink/af_netlink.c:1921
> sock_sendmsg_nosec net/socket.c:705 [inline]
> sock_sendmsg net/socket.c:725 [inline]
> ____sys_sendmsg+0x348/0x4c0 net/socket.c:2413
> ___sys_sendmsg net/socket.c:2467 [inline]
> __sys_sendmsg+0x159/0x1f0 net/socket.c:2496
> __do_sys_sendmsg net/socket.c:2505 [inline]
> __se_sys_sendmsg net/socket.c:2503 [inline]
> __x64_sys_sendmsg+0x47/0x50 net/socket.c:2503
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x3d/0x90 arch/x86/entry/c
>
> Fixes: f102d66b335a ("netfilter: nf_tables: use dedicated mutex to guard transactions")
Ah, that makes sense.
Reviewed-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2022-08-21 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 8:59 [PATCH nf] netfilter: nf_tables: make table handle allocation per-netns friendly Pablo Neira Ayuso
2022-08-21 9:44 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821094458.GC11586@breakpoint.cc \
--to=fw@strlen.de \
--cc=abhishek.shah@columbia.edu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.