All of lore.kernel.org
 help / color / mirror / Atom feed
From: Siddh Raman Pant <code@siddh.me>
To: code@siddh.me
Cc: david@fromorbit.com, djwong@kernel.org, fgheet255t@gmail.com,
	hch@infradead.org, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-xfs@vger.kernel.org, riteshh@linux.ibm.com,
	syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com, willy@infradead.org
Subject: Re: [syzbot] WARNING in iomap_iter
Date: Sun, 21 Aug 2022 17:18:16 +0530	[thread overview]
Message-ID: <20220821114816.24193-1-code@siddh.me> (raw)
In-Reply-To: <182c028abf0.2dc6f7c973088.2963173753499991828@siddh.me>

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

---
 drivers/block/loop.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index e3c0ba93c1a3..a3d9af0a2077 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -979,9 +979,15 @@ loop_set_status_from_info(struct loop_device *lo,
 
 	lo->lo_offset = info->lo_offset;
 	lo->lo_sizelimit = info->lo_sizelimit;
+	lo->lo_flags = info->lo_flags;
+
+	/* loff_t/int vars are assigned __u64/__u32 vars (respectively) */
+	if (lo->lo_offset < 0 || lo->lo_sizelimit < 0 || lo->lo_flags < 0)
+		return -EOVERFLOW;
+
 	memcpy(lo->lo_file_name, info->lo_file_name, LO_NAME_SIZE);
 	lo->lo_file_name[LO_NAME_SIZE-1] = 0;
-	lo->lo_flags = info->lo_flags;
+
 	return 0;
 }
 
-- 
2.35.1



  reply	other threads:[~2022-08-21 11:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 23:46 [syzbot] WARNING in iomap_iter syzbot
2021-11-09  7:20 ` Christoph Hellwig
2022-02-12 20:41 ` syzbot
2022-02-13 14:34   ` Ritesh Harjani
2022-02-14  2:58     ` Dave Chinner
2022-08-18 11:00       ` Siddh Raman Pant
2022-08-18 11:11         ` Siddh Raman Pant
2022-08-18 14:50           ` Matthew Wilcox
2022-08-18 15:21             ` Siddh Raman Pant
2022-08-21  6:29               ` hch
2022-08-21 11:27                 ` Siddh Raman Pant
2022-08-21 11:48                   ` Siddh Raman Pant [this message]
2022-08-21 20:59                     ` syzbot
2022-08-22 14:45                     ` Matthew Wilcox
2022-08-22 14:49                       ` Siddh Raman Pant
2022-08-22 14:52                         ` Matthew Wilcox
2022-08-22 15:02                           ` Siddh Raman Pant
2022-08-23 15:21                             ` Siddh Raman Pant
2022-08-23 15:28                               ` Matthew Wilcox
2022-08-23 15:35                                 ` Siddh Raman Pant
2022-08-23 15:42                                   ` Matthew Wilcox
2022-08-23 15:54                                   ` syzbot
2022-08-23 15:38                               ` syzbot
2022-08-18 19:30           ` syzbot
2022-08-18 19:09         ` syzbot
2022-11-14 11:50 ` Siddh Raman Pant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220821114816.24193-1-code@siddh.me \
    --to=code@siddh.me \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=fgheet255t@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=riteshh@linux.ibm.com \
    --cc=syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.