From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building
Date: Sun, 21 Aug 2022 21:31:41 +0200 [thread overview]
Message-ID: <20220821193141.GS2167049@scaer> (raw)
In-Reply-To: <20220821190153.233016-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2022-08-21 21:01 +0200, Thomas Petazzoni via buildroot spake thusly:
> Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in:
> add detection for the lack of C library") added an $(error ...)
> message when no C library is available for the currently selected
> architecture.
>
> However, this error message pops up not just when building, so for
> example, the command:
>
> make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars
>
> no longer works (this command is used by the pkg-stats script).
>
> We restore a functional behavior by doing the check only when
> BR_BUILDING=y.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index ff60f85092..43d214bcbe 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -53,7 +53,7 @@ else ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
> LIBC = musl
> else ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
> LIBC = gnu
> -else
> +else ifeq ($(BR_BUILDING),y)
> # This happens if there is a bug in Buildroot that allows an
> # architecture configuration that isn't supported by any library.
> $(error No C library enabled, this is not possible.)
> --
> 2.37.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-21 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 19:01 [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building Thomas Petazzoni via buildroot
2022-08-21 19:31 ` Yann E. MORIN [this message]
2022-09-17 9:59 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821193141.GS2167049@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.