Re: [Buildroot] [PATCH v8 4/5] package/qt5/qt5base: disable broken qmake sysrootify

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Peter Seiderer" <ps.report@gmx.net>,
	buildroot@buildroot.org, "Julien Corjon" <corjon.j@ecagroup.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v8 4/5] package/qt5/qt5base: disable broken qmake sysrootify
Date: Sun, 21 Aug 2022 22:18:40 +0200	[thread overview]
Message-ID: <20220821201840.GU2167049@scaer> (raw)
In-Reply-To: <CADvTj4rvcKW-av9ajcrR0hEarYxbSfJqE2P2-1Zj7qj8NBoMQA@mail.gmail.com>

James, All,

On 2022-08-02 16:44 -0600, James Hilliard spake thusly:
> On Wed, Jul 27, 2022 at 2:31 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > On Mon, 14 Feb 2022 18:53:06 -0700
> > James Hilliard <james.hilliard1@gmail.com> wrote:
> > > Currently the qmake gcc sysrootify path logic causes issues with
> > > per-package directories, disable automatic gcc sysroot for qt5base
> > > install and override all qt.conf paths manually to point to their
> > > correct locations.
> > Could you clarify which "issues" this is fixing? I am now looking at
> > this patch because it is the only one that has not been applied, 6
> > months after it has been posted, and the commit log is very fuzzy about
> > what the problem is, and how the commit fixes it.
> >
> > I have just built the following defconfig successfully:
[--SNIP--]
> > Basically building with PPD, qt5base, and a limited set of qt5
> > packages. Could you describe the problem that you encountered, together
> > with a defconfig that allows to reproduce it?
> I recall it helped with qtwebengine's gn build system integration dependency
> resolution logic which was mixing up host/target deps a bit.

So, this is still very fuzzy, and it lacks concrete explanations, and a
defconfig and setup that exhibits the issue which this patch supposedly
fixes.

I've marked this patch as rejected.

If you believe there realyl is an issue that needs fixing, please do not
hesitate to respin this change with a commit log that explains exactly
how the issue manifests itself, what causes the issue, and why the way
you fix it is good (or at least, better thatn the crrent situation).

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot