Re: [Buildroot] [PATCH 1/1] package/lshw: fix NLS build

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Romain Naour <romain.naour@smile.fr>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/lshw: fix NLS build
Date: Sun, 21 Aug 2022 23:10:16 +0200	[thread overview]
Message-ID: <20220821231016.197b4422@windsurf> (raw)
In-Reply-To: <20220815163456.31474-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

+Romain, Yann and Alexey

On Mon, 15 Aug 2022 18:34:56 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following NLS build failure:
> 
> In file included from hw.cc:5:
> config.h:10:10: fatal error: libintl.h: No such file or directory
>    10 | #include <libintl.h>
>       |          ^~~~~~~~~~~
> 
> Strangely enough this build failure is only raised by the autobuilders
> since bump to latest head in commit
> 72a009fa98a37825624f70dc2a1cf825a5999a0a. However,libintl.h is
> unconditionally used since version B.02.15 and
> https://github.com/lyonel/lshw/commit/792eba3da1c38a164ddde999d188b11bc0e5abb0
> so the build failure can be reproduced even when
> 72a009fa98a37825624f70dc2a1cf825a5999a0a is reverted
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/09fbc4948650f8f756cb5a9ca4b5c687cd2edc6c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

So, I had a look at what's happening here. You're right, there is
something "special".

What is "special" is that this build failure happens with the
pre-compiled ARC toolchain provided by Synopsys, and this uClibc-based
toolchain is built without the libintl stub (UCLIBC_HAS_LIBINTL is
disabled). However, in Buildroot, we assume that uClibc toolchains have
the libintl stub enabled (UCLIBC_HAS_LIBINTL is enabled).

This explains a lot of build failures caused by this toolchain:

  http://autobuild.buildroot.net/index.php?status=NOK&symbols%5BBR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC%5D=y

My suggestion would be to drop support for this pre-built toolchain,
and replace it with the glibc-based toolchain provided by Synopsys:
https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/tag/arc-2021.09-release

Of course, if Synopsys adjusts the uClibc toolchains to enable the
libintl stub, we will be able to again use those toolchains in the
future. That is why I have added Alexey in Cc.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot