diff for duplicates of <202208221817.t5uzfegL-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index eca0fdc..d5fcacb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,40 @@ +BCC: lkp(a)intel.com +CC: kbuild-all(a)lists.01.org +In-Reply-To: <20220818170005.747015-3-dima@arista.com> +References: <20220818170005.747015-3-dima@arista.com> +TO: Dmitry Safonov <dima@arista.com> +TO: Eric Dumazet <edumazet@google.com> +TO: "David S. Miller" <davem@davemloft.net> +CC: netdev(a)vger.kernel.org +TO: linux-kernel(a)vger.kernel.org +CC: Dmitry Safonov <dima@arista.com> +CC: Andy Lutomirski <luto@amacapital.net> +CC: Ard Biesheuvel <ardb@kernel.org> +CC: Bob Gilligan <gilligan@arista.com> +CC: David Ahern <dsahern@kernel.org> +CC: Eric Biggers <ebiggers@kernel.org> +CC: Francesco Ruggeri <fruggeri@arista.com> +CC: Herbert Xu <herbert@gondor.apana.org.au> +CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> +CC: Ivan Delalande <colona@arista.com> +CC: Jakub Kicinski <kuba@kernel.org> +CC: Leonard Crestez <cdleonard@gmail.com> +CC: Paolo Abeni <pabeni@redhat.com> +CC: Salam Noureddine <noureddine@arista.com> +CC: Shuah Khan <skhan@linuxfoundation.org> +CC: linux-crypto(a)vger.kernel.org + Hi Dmitry, +Thank you for the patch! Perhaps something to improve: + +[auto build test WARNING on e34cfee65ec891a319ce79797dda18083af33a76] + url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 base: e34cfee65ec891a319ce79797dda18083af33a76 -config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp@intel.com/config) +:::::: branch date: 4 days ago +:::::: commit date: 4 days ago +config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp(a)intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable @@ -12,8 +44,16 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> New smatch warnings: crypto/crypto_pool.c:203 crypto_pool_alloc_ahash() error: uninitialized symbol 'err'. +Old smatch warnings: +crypto/crypto_pool.c:193 crypto_pool_alloc_ahash() error: testing array offset 'i' after use. + vim +/err +203 crypto/crypto_pool.c +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 166 +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 167 /** +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 168 * crypto_pool_alloc_ahash - allocates pool for ahash requests +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 169 * @alg: name of async hash algorithm +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 170 */ f4c3873630fc8c4 Dmitry Safonov 2022-08-18 171 int crypto_pool_alloc_ahash(const char *alg) f4c3873630fc8c4 Dmitry Safonov 2022-08-18 172 { f4c3873630fc8c4 Dmitry Safonov 2022-08-18 173 unsigned int i; @@ -26,13 +66,6 @@ f4c3873630fc8c4 Dmitry Safonov 2022-08-18 179 if (cpool[i].alg && !strcmp(cp f4c3873630fc8c4 Dmitry Safonov 2022-08-18 180 if (kref_read(&cpool[i].kref) > 0) { f4c3873630fc8c4 Dmitry Safonov 2022-08-18 181 kref_get(&cpool[i].kref); f4c3873630fc8c4 Dmitry Safonov 2022-08-18 182 goto out; - -"err" not set. It was supposed to be set to zero at the start. But -better to say "ret = i;" here maybe? - -Why is i unsigned? It leads to unsightly casts. Presumably some static -checker insists on this... :/ - f4c3873630fc8c4 Dmitry Safonov 2022-08-18 183 } else { f4c3873630fc8c4 Dmitry Safonov 2022-08-18 184 break; f4c3873630fc8c4 Dmitry Safonov 2022-08-18 185 } @@ -55,6 +88,8 @@ f4c3873630fc8c4 Dmitry Safonov 2022-08-18 201 out: f4c3873630fc8c4 Dmitry Safonov 2022-08-18 202 mutex_unlock(&cpool_mutex); f4c3873630fc8c4 Dmitry Safonov 2022-08-18 @203 return err ?: (int)i; f4c3873630fc8c4 Dmitry Safonov 2022-08-18 204 } +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 205 EXPORT_SYMBOL_GPL(crypto_pool_alloc_ahash); +f4c3873630fc8c4 Dmitry Safonov 2022-08-18 206 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 4ec0bc0..e3a9893 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,38 +1,46 @@ - "ref\020220818170005.747015-3-dima@arista.com\0" - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH 02/31] crypto_pool: Add crypto_pool_reserve_scratch()\0" - "Date\0Mon, 22 Aug 2022 13:45:25 +0300\0" - "To\0kbuild@lists.01.org" - Dmitry Safonov <dima@arista.com> - Eric Dumazet <edumazet@google.com> - David S. Miller <davem@davemloft.net> - " linux-kernel@vger.kernel.org\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - netdev@vger.kernel.org - Dmitry Safonov <dima@arista.com> - Andy Lutomirski <luto@amacapital.net> - Ard Biesheuvel <ardb@kernel.org> - Bob Gilligan <gilligan@arista.com> - David Ahern <dsahern@kernel.org> - Eric Biggers <ebiggers@kernel.org> - Francesco Ruggeri <fruggeri@arista.com> - Herbert Xu <herbert@gondor.apana.org.au> - Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> - Ivan Delalande <colona@arista.com> - Jakub Kicinski <kuba@kernel.org> - Leonard Crestez <cdleonard@gmail.com> - Paolo Abeni <pabeni@redhat.com> - Salam Noureddine <noureddine@arista.com> - Shuah Khan <skhan@linuxfoundation.org> - " linux-crypto@vger.kernel.org\0" - "\00:1\0" + "Date\0Mon, 22 Aug 2022 18:21:02 +0800\0" + "To\0kbuild@lists.01.org\0" + "\01:1\0" "b\0" + "BCC: lkp(a)intel.com\n" + "CC: kbuild-all(a)lists.01.org\n" + "In-Reply-To: <20220818170005.747015-3-dima@arista.com>\n" + "References: <20220818170005.747015-3-dima@arista.com>\n" + "TO: Dmitry Safonov <dima@arista.com>\n" + "TO: Eric Dumazet <edumazet@google.com>\n" + "TO: \"David S. Miller\" <davem@davemloft.net>\n" + "CC: netdev(a)vger.kernel.org\n" + "TO: linux-kernel(a)vger.kernel.org\n" + "CC: Dmitry Safonov <dima@arista.com>\n" + "CC: Andy Lutomirski <luto@amacapital.net>\n" + "CC: Ard Biesheuvel <ardb@kernel.org>\n" + "CC: Bob Gilligan <gilligan@arista.com>\n" + "CC: David Ahern <dsahern@kernel.org>\n" + "CC: Eric Biggers <ebiggers@kernel.org>\n" + "CC: Francesco Ruggeri <fruggeri@arista.com>\n" + "CC: Herbert Xu <herbert@gondor.apana.org.au>\n" + "CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>\n" + "CC: Ivan Delalande <colona@arista.com>\n" + "CC: Jakub Kicinski <kuba@kernel.org>\n" + "CC: Leonard Crestez <cdleonard@gmail.com>\n" + "CC: Paolo Abeni <pabeni@redhat.com>\n" + "CC: Salam Noureddine <noureddine@arista.com>\n" + "CC: Shuah Khan <skhan@linuxfoundation.org>\n" + "CC: linux-crypto(a)vger.kernel.org\n" + "\n" "Hi Dmitry,\n" "\n" + "Thank you for the patch! Perhaps something to improve:\n" + "\n" + "[auto build test WARNING on e34cfee65ec891a319ce79797dda18083af33a76]\n" + "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628\n" "base: e34cfee65ec891a319ce79797dda18083af33a76\n" - "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp@intel.com/config)\n" + ":::::: branch date: 4 days ago\n" + ":::::: commit date: 4 days ago\n" + "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp(a)intel.com/config)\n" "compiler: gcc-11 (Debian 11.3.0-5) 11.3.0\n" "\n" "If you fix the issue, kindly add following tag where applicable\n" @@ -42,8 +50,16 @@ "New smatch warnings:\n" "crypto/crypto_pool.c:203 crypto_pool_alloc_ahash() error: uninitialized symbol 'err'.\n" "\n" + "Old smatch warnings:\n" + "crypto/crypto_pool.c:193 crypto_pool_alloc_ahash() error: testing array offset 'i' after use.\n" + "\n" "vim +/err +203 crypto/crypto_pool.c\n" "\n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 166 \n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 167 /**\n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 168 * crypto_pool_alloc_ahash - allocates pool for ahash requests\n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 169 * @alg: name of async hash algorithm\n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 170 */\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 171 int crypto_pool_alloc_ahash(const char *alg)\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 172 {\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 173 \tunsigned int i;\n" @@ -56,13 +72,6 @@ "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 180 \t\t\tif (kref_read(&cpool[i].kref) > 0) {\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 181 \t\t\t\tkref_get(&cpool[i].kref);\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 182 \t\t\t\tgoto out;\n" - "\n" - "\"err\" not set. It was supposed to be set to zero at the start. But\n" - "better to say \"ret = i;\" here maybe?\n" - "\n" - "Why is i unsigned? It leads to unsightly casts. Presumably some static\n" - "checker insists on this... :/\n" - "\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 183 \t\t\t} else {\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 184 \t\t\t\tbreak;\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 185 \t\t\t}\n" @@ -85,9 +94,11 @@ "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 202 \tmutex_unlock(&cpool_mutex);\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 @203 \treturn err ?: (int)i;\n" "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 204 }\n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 205 EXPORT_SYMBOL_GPL(crypto_pool_alloc_ahash);\n" + "f4c3873630fc8c4 Dmitry Safonov 2022-08-18 206 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://01.org/lkp -f53309a74d02bc85e962cd551a869ce189d525dd6ba62dec393377b793407a0f +880ad43fb768d100b8ca8c44f2d35ff783a72a032c87bc8822fc64e3cab73b18
diff --git a/a/1.txt b/N2/1.txt index eca0fdc..ac1dcb3 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ Hi Dmitry, url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 base: e34cfee65ec891a319ce79797dda18083af33a76 -config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp@intel.com/config) +config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp(a)intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable diff --git a/a/content_digest b/N2/content_digest index 4ec0bc0..c6ce4d1 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,37 +2,14 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH 02/31] crypto_pool: Add crypto_pool_reserve_scratch()\0" "Date\0Mon, 22 Aug 2022 13:45:25 +0300\0" - "To\0kbuild@lists.01.org" - Dmitry Safonov <dima@arista.com> - Eric Dumazet <edumazet@google.com> - David S. Miller <davem@davemloft.net> - " linux-kernel@vger.kernel.org\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - netdev@vger.kernel.org - Dmitry Safonov <dima@arista.com> - Andy Lutomirski <luto@amacapital.net> - Ard Biesheuvel <ardb@kernel.org> - Bob Gilligan <gilligan@arista.com> - David Ahern <dsahern@kernel.org> - Eric Biggers <ebiggers@kernel.org> - Francesco Ruggeri <fruggeri@arista.com> - Herbert Xu <herbert@gondor.apana.org.au> - Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> - Ivan Delalande <colona@arista.com> - Jakub Kicinski <kuba@kernel.org> - Leonard Crestez <cdleonard@gmail.com> - Paolo Abeni <pabeni@redhat.com> - Salam Noureddine <noureddine@arista.com> - Shuah Khan <skhan@linuxfoundation.org> - " linux-crypto@vger.kernel.org\0" - "\00:1\0" + "To\0kbuild-all@lists.01.org\0" + "\01:1\0" "b\0" "Hi Dmitry,\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628\n" "base: e34cfee65ec891a319ce79797dda18083af33a76\n" - "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp@intel.com/config)\n" + "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221817.t5uzfegL-lkp(a)intel.com/config)\n" "compiler: gcc-11 (Debian 11.3.0-5) 11.3.0\n" "\n" "If you fix the issue, kindly add following tag where applicable\n" @@ -90,4 +67,4 @@ "0-DAY CI Kernel Test Service\n" https://01.org/lkp -f53309a74d02bc85e962cd551a869ce189d525dd6ba62dec393377b793407a0f +4af22decf77f35b4aeacc3edbbed15c3703f957c4888765c0405fa0e7b240985
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.