diff for duplicates of <202208221901.Fs6wW5Jd-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index f7513de..7a6abcd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,40 @@ +BCC: lkp(a)intel.com +CC: kbuild-all(a)lists.01.org +In-Reply-To: <20220818170005.747015-12-dima@arista.com> +References: <20220818170005.747015-12-dima@arista.com> +TO: Dmitry Safonov <dima@arista.com> +TO: Eric Dumazet <edumazet@google.com> +TO: "David S. Miller" <davem@davemloft.net> +CC: netdev(a)vger.kernel.org +TO: linux-kernel(a)vger.kernel.org +CC: Dmitry Safonov <dima@arista.com> +CC: Andy Lutomirski <luto@amacapital.net> +CC: Ard Biesheuvel <ardb@kernel.org> +CC: Bob Gilligan <gilligan@arista.com> +CC: David Ahern <dsahern@kernel.org> +CC: Eric Biggers <ebiggers@kernel.org> +CC: Francesco Ruggeri <fruggeri@arista.com> +CC: Herbert Xu <herbert@gondor.apana.org.au> +CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> +CC: Ivan Delalande <colona@arista.com> +CC: Jakub Kicinski <kuba@kernel.org> +CC: Leonard Crestez <cdleonard@gmail.com> +CC: Paolo Abeni <pabeni@redhat.com> +CC: Salam Noureddine <noureddine@arista.com> +CC: Shuah Khan <skhan@linuxfoundation.org> +CC: linux-crypto(a)vger.kernel.org + Hi Dmitry, -url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 +Thank you for the patch! Perhaps something to improve: + +[auto build test WARNING on e34cfee65ec891a319ce79797dda18083af33a76] + +url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 base: e34cfee65ec891a319ce79797dda18083af33a76 -config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp@intel.com/config ) +:::::: branch date: 4 days ago +:::::: commit date: 4 days ago +config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp(a)intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable @@ -15,6 +47,20 @@ net/ipv4/tcp_output.c:686 tcp_options_write() error: we previously assumed 'tp' vim +/maclen +640 net/ipv4/tcp_output.c +331fca4315efa3b Martin KaFai Lau 2020-08-20 594 +67edfef78639573 Andi Kleen 2009-07-21 595 /* Write previously computed TCP options to the packet. +67edfef78639573 Andi Kleen 2009-07-21 596 * +67edfef78639573 Andi Kleen 2009-07-21 597 * Beware: Something in the Internet is very sensitive to the ordering of +fd6149d332973ba Ilpo Järvinen 2008-10-23 598 * TCP options, we learned this through the hard way, so be careful here. +fd6149d332973ba Ilpo Järvinen 2008-10-23 599 * Luckily we can at least blame others for their non-compliance but from +8e3bff96afa6736 stephen hemminger 2013-12-08 600 * inter-operability perspective it seems that we're somewhat stuck with +fd6149d332973ba Ilpo Järvinen 2008-10-23 601 * the ordering which we have been using if we want to keep working with +fd6149d332973ba Ilpo Järvinen 2008-10-23 602 * those broken things (not that it currently hurts anybody as there isn't +fd6149d332973ba Ilpo Järvinen 2008-10-23 603 * particular reason why the ordering would need to be changed). +fd6149d332973ba Ilpo Järvinen 2008-10-23 604 * +fd6149d332973ba Ilpo Järvinen 2008-10-23 605 * At least SACK_PERM as the first option is known to lead to a disaster +fd6149d332973ba Ilpo Järvinen 2008-10-23 606 * (but it may well be that other scenarios fail similarly). +fd6149d332973ba Ilpo Järvinen 2008-10-23 607 */ ea66758c1795cef Paolo Abeni 2022-05-04 608 static void tcp_options_write(struct tcphdr *th, struct tcp_sock *tp, 85df6b860d509a9 Dmitry Safonov 2022-08-18 609 struct tcp_out_options *opts, 85df6b860d509a9 Dmitry Safonov 2022-08-18 610 struct tcp_ao_key *ao_key) @@ -34,9 +80,6 @@ bd0388ae7707502 William Allen Simpson 2009-12-02 619 opts->hash_location = ( 85df6b860d509a9 Dmitry Safonov 2022-08-18 624 u8 maclen; 33ad798c924b4a1 Adam Langley 2008-07-19 625 85df6b860d509a9 Dmitry Safonov 2022-08-18 @626 if (tp) { - -Can "tp" really be NULL? Everything else assumes it can't. - 85df6b860d509a9 Dmitry Safonov 2022-08-18 627 struct tcp_ao_info *ao_info; 85df6b860d509a9 Dmitry Safonov 2022-08-18 628 85df6b860d509a9 Dmitry Safonov 2022-08-18 629 ao_info = rcu_dereference_check(tp->ao_info, @@ -49,14 +92,8 @@ Can "tp" really be NULL? Everything else assumes it can't. 85df6b860d509a9 Dmitry Safonov 2022-08-18 636 (ao_key->sndid << 8) | 85df6b860d509a9 Dmitry Safonov 2022-08-18 637 (ao_info->rnext_key->rcvid)); 85df6b860d509a9 Dmitry Safonov 2022-08-18 638 } - -"maclen" not initialized on else path. - 85df6b860d509a9 Dmitry Safonov 2022-08-18 639 opts->hash_location = (__u8 *)ptr; 85df6b860d509a9 Dmitry Safonov 2022-08-18 @640 ptr += maclen / sizeof(*ptr); - -Uninitialized. - 85df6b860d509a9 Dmitry Safonov 2022-08-18 641 if (unlikely(maclen % sizeof(*ptr))) { 85df6b860d509a9 Dmitry Safonov 2022-08-18 642 memset(ptr, TCPOPT_NOP, sizeof(*ptr)); 85df6b860d509a9 Dmitry Safonov 2022-08-18 643 ptr++; @@ -103,9 +140,6 @@ bd0388ae7707502 William Allen Simpson 2009-12-02 678 if (unlikely(OPTION_WSCA 33ad798c924b4a1 Adam Langley 2008-07-19 684 33ad798c924b4a1 Adam Langley 2008-07-19 685 if (unlikely(opts->num_sack_blocks)) { 33ad798c924b4a1 Adam Langley 2008-07-19 @686 struct tcp_sack_block *sp = tp->rx_opt.dsack ? - -Unchecked dereference. - 33ad798c924b4a1 Adam Langley 2008-07-19 687 tp->duplicate_sack : tp->selective_acks; 40efc6fa179f440 Stephen Hemminger 2006-01-03 688 int this_sack; 40efc6fa179f440 Stephen Hemminger 2006-01-03 689 @@ -151,14 +185,9 @@ Unchecked dereference. 60e2a7780793bae Ursula Braun 2017-10-25 729 smc_options_write(ptr, &options); eda7acddf8080bb Peter Krystad 2020-01-21 730 ea66758c1795cef Paolo Abeni 2022-05-04 731 mptcp_options_write(th, ptr, tp, opts); - ^^ -Not checked here either. - 60e2a7780793bae Ursula Braun 2017-10-25 732 } +60e2a7780793bae Ursula Braun 2017-10-25 733 -- 0-DAY CI Kernel Test Service -https://01.org/lkp -_______________________________________________ -kbuild mailing list -- kbuild@lists.01.org -To unsubscribe send an email to kbuild-leave@lists.01.org +https://01.org/lkp diff --git a/a/content_digest b/N1/content_digest index 09c198f..158d644 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,38 +1,46 @@ - "ref\020220818170005.747015-12-dima@arista.com\0" - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0[kbuild] Re: [PATCH 11/31] net/tcp: Add TCP-AO sign to outgoing packets\0" - "Date\0Mon, 22 Aug 2022 15:03:40 +0300\0" - "To\0kbuild@lists.01.org" - Dmitry Safonov <dima@arista.com> - Eric Dumazet <edumazet@google.com> - David S. Miller <davem@davemloft.net> - " linux-kernel@vger.kernel.org\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - netdev@vger.kernel.org - Dmitry Safonov <dima@arista.com> - Andy Lutomirski <luto@amacapital.net> - Ard Biesheuvel <ardb@kernel.org> - Bob Gilligan <gilligan@arista.com> - David Ahern <dsahern@kernel.org> - Eric Biggers <ebiggers@kernel.org> - Francesco Ruggeri <fruggeri@arista.com> - Herbert Xu <herbert@gondor.apana.org.au> - Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> - Ivan Delalande <colona@arista.com> - Jakub Kicinski <kuba@kernel.org> - Leonard Crestez <cdleonard@gmail.com> - Paolo Abeni <pabeni@redhat.com> - Salam Noureddine <noureddine@arista.com> - Shuah Khan <skhan@linuxfoundation.org> - " linux-crypto@vger.kernel.org\0" - "\00:1\0" + "From\0kernel test robot <lkp@intel.com>\0" + "Subject\0Re: [PATCH 11/31] net/tcp: Add TCP-AO sign to outgoing packets\0" + "Date\0Mon, 22 Aug 2022 19:22:35 +0800\0" + "To\0kbuild@lists.01.org\0" + "\01:1\0" "b\0" + "BCC: lkp(a)intel.com\n" + "CC: kbuild-all(a)lists.01.org\n" + "In-Reply-To: <20220818170005.747015-12-dima@arista.com>\n" + "References: <20220818170005.747015-12-dima@arista.com>\n" + "TO: Dmitry Safonov <dima@arista.com>\n" + "TO: Eric Dumazet <edumazet@google.com>\n" + "TO: \"David S. Miller\" <davem@davemloft.net>\n" + "CC: netdev(a)vger.kernel.org\n" + "TO: linux-kernel(a)vger.kernel.org\n" + "CC: Dmitry Safonov <dima@arista.com>\n" + "CC: Andy Lutomirski <luto@amacapital.net>\n" + "CC: Ard Biesheuvel <ardb@kernel.org>\n" + "CC: Bob Gilligan <gilligan@arista.com>\n" + "CC: David Ahern <dsahern@kernel.org>\n" + "CC: Eric Biggers <ebiggers@kernel.org>\n" + "CC: Francesco Ruggeri <fruggeri@arista.com>\n" + "CC: Herbert Xu <herbert@gondor.apana.org.au>\n" + "CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>\n" + "CC: Ivan Delalande <colona@arista.com>\n" + "CC: Jakub Kicinski <kuba@kernel.org>\n" + "CC: Leonard Crestez <cdleonard@gmail.com>\n" + "CC: Paolo Abeni <pabeni@redhat.com>\n" + "CC: Salam Noureddine <noureddine@arista.com>\n" + "CC: Shuah Khan <skhan@linuxfoundation.org>\n" + "CC: linux-crypto(a)vger.kernel.org\n" + "\n" "Hi Dmitry,\n" "\n" - "url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 \n" + "Thank you for the patch! Perhaps something to improve:\n" + "\n" + "[auto build test WARNING on e34cfee65ec891a319ce79797dda18083af33a76]\n" + "\n" + "url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628\n" "base: e34cfee65ec891a319ce79797dda18083af33a76\n" - "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp@intel.com/config )\n" + ":::::: branch date: 4 days ago\n" + ":::::: commit date: 4 days ago\n" + "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp(a)intel.com/config)\n" "compiler: gcc-11 (Debian 11.3.0-5) 11.3.0\n" "\n" "If you fix the issue, kindly add following tag where applicable\n" @@ -45,6 +53,20 @@ "\n" "vim +/maclen +640 net/ipv4/tcp_output.c\n" "\n" + "331fca4315efa3b Martin KaFai Lau 2020-08-20 594 \n" + "67edfef78639573 Andi Kleen 2009-07-21 595 /* Write previously computed TCP options to the packet.\n" + "67edfef78639573 Andi Kleen 2009-07-21 596 *\n" + "67edfef78639573 Andi Kleen 2009-07-21 597 * Beware: Something in the Internet is very sensitive to the ordering of\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 598 * TCP options, we learned this through the hard way, so be careful here.\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 599 * Luckily we can at least blame others for their non-compliance but from\n" + "8e3bff96afa6736 stephen hemminger 2013-12-08 600 * inter-operability perspective it seems that we're somewhat stuck with\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 601 * the ordering which we have been using if we want to keep working with\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 602 * those broken things (not that it currently hurts anybody as there isn't\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 603 * particular reason why the ordering would need to be changed).\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 604 *\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 605 * At least SACK_PERM as the first option is known to lead to a disaster\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 606 * (but it may well be that other scenarios fail similarly).\n" + "fd6149d332973ba Ilpo J\303\244rvinen 2008-10-23 607 */\n" "ea66758c1795cef Paolo Abeni 2022-05-04 608 static void tcp_options_write(struct tcphdr *th, struct tcp_sock *tp,\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 609 \t\t\t struct tcp_out_options *opts,\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 610 \t\t\t struct tcp_ao_key *ao_key)\n" @@ -64,9 +86,6 @@ "85df6b860d509a9 Dmitry Safonov 2022-08-18 624 \t\tu8 maclen;\n" "33ad798c924b4a1 Adam Langley 2008-07-19 625 \n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 @626 \t\tif (tp) {\n" - "\n" - "Can \"tp\" really be NULL? Everything else assumes it can't.\n" - "\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 627 \t\t\tstruct tcp_ao_info *ao_info;\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 628 \n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 629 \t\t\tao_info = rcu_dereference_check(tp->ao_info,\n" @@ -79,14 +98,8 @@ "85df6b860d509a9 Dmitry Safonov 2022-08-18 636 \t\t\t\t (ao_key->sndid << 8) |\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 637 \t\t\t\t (ao_info->rnext_key->rcvid));\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 638 \t\t}\n" - "\n" - "\"maclen\" not initialized on else path.\n" - "\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 639 \t\topts->hash_location = (__u8 *)ptr;\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 @640 \t\tptr += maclen / sizeof(*ptr);\n" - "\n" - "Uninitialized.\n" - "\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 641 \t\tif (unlikely(maclen % sizeof(*ptr))) {\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 642 \t\t\tmemset(ptr, TCPOPT_NOP, sizeof(*ptr));\n" "85df6b860d509a9 Dmitry Safonov 2022-08-18 643 \t\t\tptr++;\n" @@ -133,9 +146,6 @@ "33ad798c924b4a1 Adam Langley 2008-07-19 684 \n" "33ad798c924b4a1 Adam Langley 2008-07-19 685 \tif (unlikely(opts->num_sack_blocks)) {\n" "33ad798c924b4a1 Adam Langley 2008-07-19 @686 \t\tstruct tcp_sack_block *sp = tp->rx_opt.dsack ?\n" - "\n" - "Unchecked dereference.\n" - "\n" "33ad798c924b4a1 Adam Langley 2008-07-19 687 \t\t\ttp->duplicate_sack : tp->selective_acks;\n" "40efc6fa179f440 Stephen Hemminger 2006-01-03 688 \t\tint this_sack;\n" "40efc6fa179f440 Stephen Hemminger 2006-01-03 689 \n" @@ -181,16 +191,11 @@ "60e2a7780793bae Ursula Braun 2017-10-25 729 \tsmc_options_write(ptr, &options);\n" "eda7acddf8080bb Peter Krystad 2020-01-21 730 \n" "ea66758c1795cef Paolo Abeni 2022-05-04 731 \tmptcp_options_write(th, ptr, tp, opts);\n" - " ^^\n" - "Not checked here either.\n" - "\n" "60e2a7780793bae Ursula Braun 2017-10-25 732 }\n" + "60e2a7780793bae Ursula Braun 2017-10-25 733 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" - "https://01.org/lkp \n" - "_______________________________________________\n" - "kbuild mailing list -- kbuild@lists.01.org\n" - To unsubscribe send an email to kbuild-leave@lists.01.org + https://01.org/lkp -dfb386effbb7c270d8d5fcfa959ca5a3653f7191913b3e2208d304a4c22bf3c9 +f63f2b2c24c44be25b964609565346b1416bbe599072e486f3fa1839e407ec20
diff --git a/a/1.txt b/N2/1.txt index f7513de..363eeb6 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -2,7 +2,7 @@ Hi Dmitry, url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 base: e34cfee65ec891a319ce79797dda18083af33a76 -config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp@intel.com/config ) +config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp(a)intel.com/config ) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable @@ -160,5 +160,5 @@ Not checked here either. 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ -kbuild mailing list -- kbuild@lists.01.org -To unsubscribe send an email to kbuild-leave@lists.01.org +kbuild mailing list -- kbuild(a)lists.01.org +To unsubscribe send an email to kbuild-leave(a)lists.01.org diff --git a/a/content_digest b/N2/content_digest index 09c198f..c298808 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,37 +2,14 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[kbuild] Re: [PATCH 11/31] net/tcp: Add TCP-AO sign to outgoing packets\0" "Date\0Mon, 22 Aug 2022 15:03:40 +0300\0" - "To\0kbuild@lists.01.org" - Dmitry Safonov <dima@arista.com> - Eric Dumazet <edumazet@google.com> - David S. Miller <davem@davemloft.net> - " linux-kernel@vger.kernel.org\0" - "Cc\0lkp@intel.com" - kbuild-all@lists.01.org - netdev@vger.kernel.org - Dmitry Safonov <dima@arista.com> - Andy Lutomirski <luto@amacapital.net> - Ard Biesheuvel <ardb@kernel.org> - Bob Gilligan <gilligan@arista.com> - David Ahern <dsahern@kernel.org> - Eric Biggers <ebiggers@kernel.org> - Francesco Ruggeri <fruggeri@arista.com> - Herbert Xu <herbert@gondor.apana.org.au> - Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> - Ivan Delalande <colona@arista.com> - Jakub Kicinski <kuba@kernel.org> - Leonard Crestez <cdleonard@gmail.com> - Paolo Abeni <pabeni@redhat.com> - Salam Noureddine <noureddine@arista.com> - Shuah Khan <skhan@linuxfoundation.org> - " linux-crypto@vger.kernel.org\0" - "\00:1\0" + "To\0kbuild-all@lists.01.org\0" + "\01:1\0" "b\0" "Hi Dmitry,\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Add-TCP-AO-support/20220819-010628 \n" "base: e34cfee65ec891a319ce79797dda18083af33a76\n" - "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp@intel.com/config )\n" + "config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220822/202208221901.Fs6wW5Jd-lkp(a)intel.com/config )\n" "compiler: gcc-11 (Debian 11.3.0-5) 11.3.0\n" "\n" "If you fix the issue, kindly add following tag where applicable\n" @@ -190,7 +167,7 @@ "0-DAY CI Kernel Test Service\n" "https://01.org/lkp \n" "_______________________________________________\n" - "kbuild mailing list -- kbuild@lists.01.org\n" - To unsubscribe send an email to kbuild-leave@lists.01.org + "kbuild mailing list -- kbuild(a)lists.01.org\n" + To unsubscribe send an email to kbuild-leave(a)lists.01.org -dfb386effbb7c270d8d5fcfa959ca5a3653f7191913b3e2208d304a4c22bf3c9 +b032dba0cf6e3a1ba4aa11c9ec942650d33d7b021a6f51d07fc406de44e21506
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.