From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA3FC28D13 for ; Tue, 23 Aug 2022 01:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238913AbiHWBkd (ORCPT ); Mon, 22 Aug 2022 21:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234840AbiHWBka (ORCPT ); Mon, 22 Aug 2022 21:40:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A68235A3FB for ; Mon, 22 Aug 2022 18:40:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48DC1B81A25 for ; Tue, 23 Aug 2022 01:40:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1A34C433D6; Tue, 23 Aug 2022 01:40:25 +0000 (UTC) Date: Mon, 22 Aug 2022 21:40:24 -0400 From: Steven Rostedt To: LKML Cc: Linus Torvalds , Frederic Weisbecker , "Paul E. McKenney" , Peter Zijlstra , Jiri Olsa , Thomas Gleixner Subject: Re: [BUG v6.0-rc2] lockdep splat on ct_kernel_enter() Message-ID: <20220822214024.216fa85d@rorschach.local.home> In-Reply-To: <20220822204825.3e88b1a4@rorschach.local.home> References: <20220822164404.57952727@gandalf.local.home> <20220822182850.32f91017@gandalf.local.home> <20220822183836.6b80976f@gandalf.local.home> <20220822204825.3e88b1a4@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Aug 2022 20:48:25 -0400 Steven Rostedt wrote: > On Mon, 22 Aug 2022 18:38:36 -0400 > Steven Rostedt wrote: > > > > The warning happens with the commit, and does not for the commit just > > > before it is applied. > > > > > > > Nevermind, I tested the wrong kernel (the grub reboot failed to boot to the > > new kernel). But it did give me a different lockdep splat when I tested the > > right kernel :-/ > > > > I'll investigate some more. > > I was close. It was this commit: > > ed4ae5eff4b3 ("rcu: Apply noinstr to rcu_idle_enter() and rcu_idle_exit()") > > that causes the new error message. > And this patch (which is wrong, but will at least let my tests finish testing my code) makes the warning go away. -- Steve diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 9a5edab5558c..14147d31e651 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -896,13 +896,13 @@ static void noinstr rcu_eqs_exit(bool user) * If you add or remove a call to rcu_idle_exit(), be sure to test with * CONFIG_RCU_EQS_DEBUG=y. */ -void noinstr rcu_idle_exit(void) +void rcu_idle_exit(void) { unsigned long flags; - raw_local_irq_save(flags); + local_irq_save(flags); rcu_eqs_exit(false); - raw_local_irq_restore(flags); + local_irq_restore(flags); } EXPORT_SYMBOL_GPL(rcu_idle_exit);