From: Kanchan Joshi <joshi.k@samsung.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: asml.silence@gmail.com, io-uring@vger.kernel.org, anuj20.g@samsung.com
Subject: Re: [PATCH] io_uring: fix submission-failure handling for uring-cmd
Date: Tue, 23 Aug 2022 22:17:16 +0530 [thread overview]
Message-ID: <20220823164716.GA3046@test-zns> (raw)
In-Reply-To: <ceaf9d3f-7588-a64c-0661-79133222f443@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Tue, Aug 23, 2022 at 09:47:39AM -0600, Jens Axboe wrote:
>On 8/23/22 9:10 AM, Kanchan Joshi wrote:
>> If ->uring_cmd returned an error value different from -EAGAIN or
>> -EIOCBQUEUED, it gets overridden with IOU_OK. This invites trouble
>> as caller (io_uring core code) handles IOU_OK differently than other
>> error codes.
>> Fix this by returning the actual error code.
>
>Not sure if this is strictly needed, as the cqe error is set just
>fine. But I guess some places also check return value of the issue
>path.
So I was testing iopoll support and ran into this issue - submission
failed (expected one), control came back to this point, error code
got converted to IOU_OK, and it started polling endlessly for a command
that never got submitted.
io_issue_sqe continued to invoke io_iopoll_req_issued() rather than
bailing out.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-08-23 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220823152018epcas5p3141ae99b73ba495f1501723d7834ee32@epcas5p3.samsung.com>
2022-08-23 15:10 ` [PATCH] io_uring: fix submission-failure handling for uring-cmd Kanchan Joshi
2022-08-23 15:47 ` Jens Axboe
2022-08-23 16:47 ` Kanchan Joshi [this message]
2022-08-23 17:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823164716.GA3046@test-zns \
--to=joshi.k@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.