All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next] docs: fix the table in admin-guide/sysctl/net.rst
Date: Tue, 23 Aug 2022 18:04:54 -0700	[thread overview]
Message-ID: <20220823180454.463f8a8b@kernel.org> (raw)
In-Reply-To: <20220824104144.466e50b1@canb.auug.org.au>

On Wed, 24 Aug 2022 10:41:43 +1000 Stephen Rothwell wrote:
> On Tue, 23 Aug 2022 16:09:06 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > The table marking length needs to be adjusted after removal
> > and reshuffling.
> > 
> > Fixes: 1202cdd66531 ("Remove DECnet support from kernel")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > --
> > CC: Stephen Hemminger <stephen@networkplumber.org>
> 
> How about this instead so that everything lines up nicely:

Thanks for reviewing, seems like I misunderstood the warning
and fixed it accidentally :o

Should I trim the first 'Content' column to the min required length as
well? Commit 1202cdd66531 (which is in -next only) reshuffled the
entire table anyway so we won't be preserving any history by not
trimming.

> diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
> index 82879a9d5683..871031462e83 100644
> --- a/Documentation/admin-guide/sysctl/net.rst
> +++ b/Documentation/admin-guide/sysctl/net.rst
> @@ -31,18 +31,18 @@ see only some of them, depending on your kernel's configuration.
>  
>  Table : Subdirectories in /proc/sys/net
>  
> - ========= =================== = ========== ==================
> - Directory Content               Directory  Content
> - ========= =================== = ========== ==================
> + ========= =================== = ========= ===================
> + Directory Content               Directory Content
> + ========= =================== = ========= ===================
>   802       E802 protocol         mptcp     Multipath TCP
>   appletalk Appletalk protocol    netfilter Network Filter
> - ax25      AX25                  netrom     NET/ROM
> + ax25      AX25                  netrom    NET/ROM
>   bridge    Bridging              rose      X.25 PLP layer
>   core      General parameter     tipc      TIPC
>   ethernet  Ethernet protocol     unix      Unix domain sockets
>   ipv4      IP version 4          x25       X.25 protocol
>   ipv6      IP version 6
> - ========= =================== = ========== ==================
> + ========= =================== = ========= ===================
>  
>  1. /proc/sys/net/core - Network core options
>  ============================================
> 


  reply	other threads:[~2022-08-24  1:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 23:09 [PATCH net-next] docs: fix the table in admin-guide/sysctl/net.rst Jakub Kicinski
2022-08-24  0:41 ` Stephen Rothwell
2022-08-24  1:04   ` Jakub Kicinski [this message]
2022-08-24  2:10     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823180454.463f8a8b@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.