All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: improve ARM trusted firmware fixup
Date: Tue, 23 Aug 2022 23:57:36 +0200	[thread overview]
Message-ID: <20220823235736.7545824b@windsurf> (raw)
In-Reply-To: <20220810074547.2833007-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

+James in Cc as he did the initial genrandconfig fixups for
arm-trusted-firmware.

On Wed, 10 Aug 2022 09:45:47 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Improve commit 541e794a959914d1189570c3674908eb5db08ce8 by adding a
> custom case to make sure that a random configuration with an empty
> platform for arm-trusted-firmware doesn't fail:
> 
> make_helpers/plat_helpers.mk:15: *** "Error: Unknown platform. Please use PLAT=<platform name> to specify the platform".  Stop.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/1b67220008223d1bcbe70b76d643f9d04362ba6b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  utils/genrandconfig | 4 ++++
>  1 file changed, 4 insertions(+)

I've applied to master. But if I'm not mistaken, this change means that
arm-trusted-firmware will never be built by the autobuilders, as
BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM will always be empty in the
random configurations that are generated. This means that the rest of
the arm-trusted-firmware fixups in genrandconfig are useless, no?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-23 21:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10  7:45 [Buildroot] [PATCH 1/1] utils/genrandconfig: improve ARM trusted firmware fixup Fabrice Fontaine
2022-08-23 21:57 ` Thomas Petazzoni via buildroot [this message]
2022-09-17 14:27 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823235736.7545824b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.