From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
mkubecek@suse.cz, johannes@sipsolutions.net,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 2/6] netlink: add helper for extack attr presence checking
Date: Tue, 23 Aug 2022 21:50:20 -0700 [thread overview]
Message-ID: <20220824045024.1107161-3-kuba@kernel.org> (raw)
In-Reply-To: <20220824045024.1107161-1-kuba@kernel.org>
Being able to check attribute presence and set extack
if not on one line is handy, add a helper.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
include/linux/netlink.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 24f9fece7599..d20007ad7e26 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -139,6 +139,17 @@ struct netlink_ext_ack {
} \
} while (0)
+#define NL_REQ_ATTR_CHECK(extack, nest, tb, type) ({ \
+ struct nlattr **__tb = (tb); \
+ u32 __attr = (type); \
+ int __retval; \
+ \
+ __retval = !__tb[__attr]; \
+ if (__retval) \
+ NL_SET_ERR_ATTR_MISS((extack), (nest), __attr); \
+ __retval; \
+})
+
static inline void nl_set_extack_cookie_u64(struct netlink_ext_ack *extack,
u64 cookie)
{
--
2.37.2
next prev parent reply other threads:[~2022-08-24 4:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 4:50 [PATCH net-next 0/6] netlink: support reporting missing attributes Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 1/6] netlink: add support for ext_ack " Jakub Kicinski
2022-08-24 8:09 ` Johannes Berg
2022-08-24 8:13 ` Johannes Berg
2022-08-24 16:36 ` Jakub Kicinski
2022-08-24 4:50 ` Jakub Kicinski [this message]
2022-08-24 4:50 ` [PATCH net-next 3/6] genetlink: add helper for checking required attrs and use it in devlink Jakub Kicinski
2022-08-24 19:44 ` Johannes Berg
2022-08-24 22:46 ` Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 4/6] devlink: use missing attribute ext_ack Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 5/6] ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 6/6] ethtool: report missing header via ext_ack in the default handler Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824045024.1107161-3-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.