From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jesse Van Gavere <jesseevg@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt6/qt6serialport: add package
Date: Wed, 24 Aug 2022 12:38:52 +0200 [thread overview]
Message-ID: <20220824123852.489214fa@windsurf> (raw)
In-Reply-To: <20220824094900.3639681-1-jesseevg@gmail.com>
Hello,
On Wed, 24 Aug 2022 11:49:00 +0200
Jesse Van Gavere <jesseevg@gmail.com> wrote:
> Signed-off-by: Jesse Van Gavere <jesseevg@gmail.com>
Wow, great, someone interested in Qt6! I've applied your patch to our
next branch, with some changes. See below.
> ---
> package/qt6/Config.in | 1 +
> package/qt6/qt6serialport/Config.in | 11 ++++++
> package/qt6/qt6serialport/qt6serialport.hash | 9 +++++
> package/qt6/qt6serialport/qt6serialport.mk | 41 ++++++++++++++++++++
> 4 files changed, 62 insertions(+)
You forgot to add an entry to the DEVELOPERS file for this new package,
so I've added that. This way you will receive e-mail notifications if
we have build failures on qt6serialport, or if new versions become
available upstream.
> diff --git a/package/qt6/qt6serialport/qt6serialport.mk b/package/qt6/qt6serialport/qt6serialport.mk
> new file mode 100644
> index 0000000000..5bfae1ca0c
> --- /dev/null
> +++ b/package/qt6/qt6serialport/qt6serialport.mk
> @@ -0,0 +1,41 @@
> +################################################################################
> +#
> +# qt6serialport
> +#
> +################################################################################
> +
> +QT6SERIALPORT_VERSION = $(QT6_VERSION)
> +QT6SERIALPORT_SITE = $(QT6_SITE)
> +QT6SERIALPORT_SOURCE = qtserialport-$(QT6_SOURCE_TARBALL_PREFIX)-$(QT6SERIALPORT_VERSION).tar.xz
> +QT6SERIALPORT_INSTALL_STAGING = YES
> +QT6SERIALPORT_LICENSE = GPL-2.0+ or LGPL-3.0, GPL-3.0 with exception(tools), GFDL-1.3 (docs)
^^^ missing space her
> +QT6SERIALPORT_LICENSE_FILES = LICENSE.GPL2 LICENSE.GPL3 LICENSE.GPL3-EXCEPT LICENSE.LGPL3 LICENSE.FDL
> +QT6SERIALPORT_CONF_OPTS += \
+= was not needed here, a simple = was enough.
> + -GNinja \
This option was intended with spaces instead of one tab.
> + -DQT_HOST_PATH=$(HOST_DIR) \
> + -DBUILD_SHARED_LIBS=ON \
This option is not needed, it's passed by the cmake-package infrastructure already.
> + -DBUILD_WITH_PCH=OFF \
> + -DQT_BUILD_EXAMPLES=OFF \
> + -DQT_BUILD_TESTS=OFF
> +
> +QT6SERIALPORT_DEPENDENCIES = \
> + host-pkgconf \
> + host-ninja \
These options were intended with spaces instead of one tab.
> + qt6base
> +
> +QT6SERIALPORT_INSTALL_STAGING = YES
This was already present earlier in your .mk file.
Again, thanks for this contribution!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-24 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 9:49 [Buildroot] [PATCH 1/1] package/qt6/qt6serialport: add package Jesse Van Gavere
2022-08-24 10:38 ` Thomas Petazzoni via buildroot [this message]
2022-08-24 11:27 ` Jesse Van Gavere
2022-08-24 11:31 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824123852.489214fa@windsurf \
--to=buildroot@buildroot.org \
--cc=jesseevg@gmail.com \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.