From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Gal Pressman <gal@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] ice: support FEC automatic disable
Date: Thu, 25 Aug 2022 10:30:27 -0700 [thread overview]
Message-ID: <20220825103027.53fed750@kernel.org> (raw)
In-Reply-To: <CO1PR11MB50893710E9CA4C720815384ED6729@CO1PR11MB5089.namprd11.prod.outlook.com>
On Thu, 25 Aug 2022 16:57:50 +0000 Keller, Jacob E wrote:
> > Sorry, I misinterpreted your previous reply, somehow I thought you
> > quoted option (3), because my fallible reading of mlx5 was that it
> > accepts multiple flags.
> >
> > (First) option 2 is fine.
>
> Even though existing behavior doesn't do that for ice right now and
> wouldn't be able to do that properly with old firmware?
Update your FW seems like a reasonable thing to ask customers to do.
Are there cables already qualified for the old FW which would switch
to No FEC under new rules?
Can you share how your FW picks the mode exactly?
There must be _some_ standardization here, because we're talking about
<5m cables, so we can safely assume it's linking to a ToR switch.
next prev parent reply other threads:[~2022-08-25 17:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 15:04 [PATCH net-next 0/2] ice: support FEC automatic disable Jacob Keller
2022-08-23 15:04 ` [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set_fecparam Jacob Keller
2022-08-23 15:06 ` Simon Horman
2022-08-23 22:13 ` Jakub Kicinski
2022-08-24 17:27 ` Keller, Jacob E
2022-08-23 15:04 ` [PATCH net-next 2/2] ice: add support for Auto FEC with FEC disabled via ETHTOOL_SFECPARAM Jacob Keller
2022-08-23 22:17 ` Jakub Kicinski
2022-08-24 17:29 ` Keller, Jacob E
2022-08-24 21:29 ` Keller, Jacob E
2022-08-24 22:47 ` Jakub Kicinski
2022-08-24 22:53 ` Keller, Jacob E
2022-08-24 23:02 ` Jakub Kicinski
2022-08-24 23:13 ` Keller, Jacob E
2022-08-24 23:32 ` Jakub Kicinski
2022-08-24 13:35 ` [PATCH net-next 0/2] ice: support FEC automatic disable Gal Pressman
2022-08-24 16:25 ` Jakub Kicinski
2022-08-25 7:08 ` Gal Pressman
2022-08-24 17:40 ` Keller, Jacob E
2022-08-25 7:08 ` Gal Pressman
2022-08-25 16:29 ` Jakub Kicinski
2022-08-25 16:57 ` Keller, Jacob E
2022-08-25 17:30 ` Jakub Kicinski [this message]
2022-08-25 17:51 ` Keller, Jacob E
2022-08-25 20:34 ` Jakub Kicinski
2022-08-25 21:04 ` Keller, Jacob E
2022-08-26 0:38 ` Jacob Keller
2022-08-26 1:01 ` Jakub Kicinski
2022-08-26 17:51 ` Jacob Keller
2022-08-26 23:57 ` Jakub Kicinski
2022-08-28 10:42 ` Gal Pressman
2022-08-29 7:11 ` Keller, Jacob E
2022-08-29 11:21 ` Gal Pressman
2022-08-29 18:10 ` Jacob Keller
2022-08-30 20:09 ` Jacob Keller
2022-08-30 21:44 ` Jakub Kicinski
2022-08-30 23:09 ` Keller, Jacob E
2022-08-31 11:01 ` Gal Pressman
2022-08-31 17:36 ` Jakub Kicinski
2022-09-01 11:52 ` Gal Pressman
2022-09-05 11:25 ` Gal Pressman
2022-08-31 20:15 ` Jacob Keller
2022-09-01 11:51 ` Gal Pressman
2022-09-01 17:59 ` Keller, Jacob E
2022-09-07 3:44 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825103027.53fed750@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.