From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
kernel test robot <lkp@intel.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, David Jander <david@protonic.nl>,
Luka Perkov <luka.perkov@sartura.hr>,
Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH net-next v2 6/7] ethtool: add interface to interact with Ethernet Power Equipment
Date: Thu, 25 Aug 2022 11:10:19 -0700 [thread overview]
Message-ID: <20220825111019.1dc3dae0@kernel.org> (raw)
In-Reply-To: <20220825130211.3730461-7-o.rempel@pengutronix.de>
On Thu, 25 Aug 2022 15:02:10 +0200 Oleksij Rempel wrote:
> +enum ethtool_podl_pse_admin_state {
> + ETHTOOL_PODL_PSE_ADMIN_STATE_UNKNOWN = 1,
Why define UNKNOWN.. as 1? No real objection here, just in my head
somehow UNKNOWN = 0 or just start from 1.
> + ETHTOOL_PODL_PSE_ADMIN_STATE_DISABLED,
> + ETHTOOL_PODL_PSE_ADMIN_STATE_ENABLED,
> +
> + /* add new constants above here */
> + ETHTOOL_PODL_PSE_ADMIN_STATE_COUNT
Why define count for a value enum like this? For attrs we define it
because it's used to size tables, don't think anyone will size tables
based on states.
There's a bunch of kdoc warnings in the patches as well.
next prev parent reply other threads:[~2022-08-25 18:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:02 [PATCH net-next v2 0/7] add generic PSE support Oleksij Rempel
2022-08-25 13:02 ` [PATCH net-next v2 1/7] dt-bindings: net: pse-dt: add bindings for generic PSE controller Oleksij Rempel
2022-08-25 22:27 ` Andrew Lunn
2022-08-26 7:49 ` Oleksij Rempel
2022-08-27 14:48 ` Andrew Lunn
2022-08-27 15:12 ` Oleksij Rempel
2022-08-27 16:11 ` Andrew Lunn
2022-08-25 13:02 ` [PATCH net-next v2 2/7] dt-bindings: net: phy: add PoDL PSE property Oleksij Rempel
2022-08-25 13:02 ` [PATCH net-next v2 3/7] net: add framework to support Ethernet PSE and PDs devices Oleksij Rempel
2022-08-25 13:02 ` [PATCH net-next v2 4/7] net: mdiobus: fwnode_mdiobus_register_phy() rework error handling Oleksij Rempel
2022-08-25 13:02 ` [PATCH net-next v2 5/7] net: mdiobus: search for PSE nodes by parsing PHY nodes Oleksij Rempel
2022-08-25 13:11 ` Russell King (Oracle)
2022-08-25 13:02 ` [PATCH net-next v2 6/7] ethtool: add interface to interact with Ethernet Power Equipment Oleksij Rempel
2022-08-25 18:07 ` Jakub Kicinski
2022-08-25 18:56 ` Oleksij Rempel
2022-08-25 18:10 ` Jakub Kicinski [this message]
2022-08-25 18:47 ` Oleksij Rempel
2022-08-25 13:02 ` [PATCH net-next v2 7/7] net: pse-pd: add generic PSE driver Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825111019.1dc3dae0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.