From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com
Subject: Re: [patch net-next] net: devlink: stub port params cmds for they are unused internally
Date: Thu, 25 Aug 2022 18:11:37 -0700 [thread overview]
Message-ID: <20220825181137.4a83b6e2@kernel.org> (raw)
In-Reply-To: <20220825082628.1285458-1-jiri@resnulli.us>
On Thu, 25 Aug 2022 10:26:28 +0200 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> Follow-up the removal of unused internal api of port params made by
> commit 42ded61aa75e ("devlink: Delete not used port parameters APIs")
> and stub the commands and add extack message to tell the user what is
> going on.
>
> If later on port params are needed, could be easily re-introduced,
> but until then it is a dead code.
>
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Why no extack on the dump, tho? Wouldn't iproute2 do dumps mostly?
With that answered/addressed:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2022-08-26 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 8:26 [patch net-next] net: devlink: stub port params cmds for they are unused internally Jiri Pirko
2022-08-26 1:11 ` Jakub Kicinski [this message]
2022-08-26 8:16 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825181137.4a83b6e2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.