All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: <sgoutham@marvell.com>, <lcherian@marvell.com>,
	<gakula@marvell.com>, <jerinj@marvell.com>, <hkelam@marvell.com>,
	<sbhatta@marvell.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>,
	<netdev@vger.kernel.org>
Subject: Re: [net-next PATCH V3] octeontx2-pf: Add egress PFC support
Date: Thu, 25 Aug 2022 19:55:44 -0700	[thread overview]
Message-ID: <20220825195544.391577b2@kernel.org> (raw)
In-Reply-To: <20220825044242.1737126-1-sumang@marvell.com>

On Thu, 25 Aug 2022 10:12:42 +0530 Suman Ghosh wrote:
> As of now all transmit queues transmit packets out of same scheduler
> queue hierarchy. Due to this PFC frames sent by peer are not handled
> properly, either all transmit queues are backpressured or none.
> To fix this when user enables PFC for a given priority map relavant
> transmit queue to a different scheduler queue hierarcy, so that
> backpressure is applied only to the traffic egressing out of that TXQ.

Does not build at all now:

ERROR: modpost: drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf: 'otx2_pfc_txschq_update' exported twice. Previous export was in drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicpf.ko
ERROR: modpost: "otx2_txschq_config" [drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf.ko] undefined!
ERROR: modpost: "otx2_smq_flush" [drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf.ko] undefined!

  reply	other threads:[~2022-08-26  2:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  4:42 [net-next PATCH V3] octeontx2-pf: Add egress PFC support Suman Ghosh
2022-08-26  2:55 ` Jakub Kicinski [this message]
2022-08-26  5:23   ` [EXT] " Suman Ghosh
2022-08-26  8:12     ` Suman Ghosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220825195544.391577b2@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=lcherian@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=sumang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.