From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9348BECAAD2 for ; Fri, 26 Aug 2022 08:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FfziefYh2mydlnYJ9gfyfitiX0j0nEI81GxEovdRMAE=; b=g60P3gRzoz5W/N wLN/ak3OomKpq3D3UWcvu2kR8OJsIp1fBPH2NNr39CpNOCguB7Mb9jAdCAJXtYMhzOeuiBIdhgOS4 Qev7yRb3AxKrfOSWUwfjtTT/4KXb9OpfRhku574UIyb29VbXASTupMeTCCwBp/qMj7X9g+Pmn9dT3 ZvacIQODQX4u3njwgskHfxpO8P0SsudbbMVwnFExgKuYjjs7ARVG4jnUp5WOyZ/wFGNo+ZUEwuOQa aPLP6C+kIEE5NtXIbNBNhLv4u34VxY4braecvtWcubJyDwnfNM9cV5MKpXQLFJgg8vqwsh/gmNYjC uvncYW0i8Y83xf8mHSCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRUVi-00GsKY-Ll; Fri, 26 Aug 2022 08:16:14 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRUVg-00GsFB-4c for linux-riscv@lists.infradead.org; Fri, 26 Aug 2022 08:16:13 +0000 Received: by mail-ej1-x631.google.com with SMTP id gb36so1708020ejc.10 for ; Fri, 26 Aug 2022 01:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=vSLa1x3yM/LYq8duQfSkPR7UjODiLbU3hMPX4a6qvnM=; b=UqyAlLYFjk8ZZXCZkUAkMzFHX94KU2J+l4l4rJrrQqciOEX6BHzsNxrwAFkdpANkj1 DpFc90cp+HrdEdqAcWeb9GHE5MNqBYWVLf0ATbQGWJ5/VRMnMRmSqujnVkjPqAx5zwRN LeTyDNz/rscKZ8eplAnrC+SXS6utmYet2gqkNKUVIzbH02r3pVXxmUoYUVbScvNBSSHs a4KUorsMpqnXHyxa6s2S/svK0lbqMdlZi/h5op4aZqHk88SCZznn1RjaUNth/wqZmiN3 U/O2G8zqGMEln7g3snEQbSw+ueJYb6Rje+GWy2Y1OACAxfY7qEkOA2oMJyqQAveB0Ab5 P/bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=vSLa1x3yM/LYq8duQfSkPR7UjODiLbU3hMPX4a6qvnM=; b=yVtkbo67ODrZjkt0Br3z7B0/rXTUzdgzHPexE3I6CGSA+VHIp+d76bT+zqSopWUqkW ThxHJ+QdxDBbHT775IhxkjBHqUQDwEvF8j0ckTAA8aoTNQf0Q0Hc9XiY6BpbBFyYeu5/ kSCW8Uhs5m5CVpoR3sOl/nZbv+OJHjT+X7ZqpsAYZvWa1GPLdv6S3g2YzXKOq4DlNTaH N1Qajx+D7yeUyNH5OrzThI4vbkMMOJFZPiIiHVvQJyBGbnDIdpZjmYIfQOVDIuciOG/7 sjUI76sJwmYwiGlA+s/AP9pdHTEcsY/7MGcmq4/BFgFlkT/Qrp0idoI/bAwKxvMkZihD 0SjA== X-Gm-Message-State: ACgBeo2Vqp1Z3kO3fd4F6EXI4+F4OovMWI8LvLRSmFC2GnfesqpZIwWk SclRE1BATh3ep3x/iGrmwrpkDw== X-Google-Smtp-Source: AA6agR7QQFuPvk2/UcrqfPRvBVDgErUw2JqMJaaJBD2nyOQrRspsGSM+8O8zg2pcCsGFDSNrUvWSeg== X-Received: by 2002:a17:907:2854:b0:740:2574:1f33 with SMTP id el20-20020a170907285400b0074025741f33mr883705ejc.105.1661501769444; Fri, 26 Aug 2022 01:16:09 -0700 (PDT) Received: from localhost (cst2-173-67.cust.vodafone.cz. [31.30.173.67]) by smtp.gmail.com with ESMTPSA id a3-20020a1709063e8300b0072b3406e9c2sm601689ejj.95.2022.08.26.01.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 01:16:08 -0700 (PDT) Date: Fri, 26 Aug 2022 10:16:07 +0200 From: Andrew Jones To: Tong Tiangen Cc: Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Conor.Dooley@microchip.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, Guohanjun Subject: Re: [PATCH -next v2 2/2] riscv: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support Message-ID: <20220826081607.ci42sbffrmsfhk2w@kamzik> References: <20220815032025.2685516-1-tongtiangen@huawei.com> <20220815032025.2685516-3-tongtiangen@huawei.com> <20220825110602.bog5mjpascvikwxx@kamzik> <7718a9bc-e976-daeb-f490-e7b5190e50b6@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7718a9bc-e976-daeb-f490-e7b5190e50b6@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_011612_199080_3897B814 X-CRM114-Status: GOOD ( 22.79 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMjYsIDIwMjIgYXQgMDI6NDQ6NDhQTSArMDgwMCwgVG9uZyBUaWFuZ2VuIHdy b3RlOgo+IAo+IAo+IOWcqCAyMDIyLzgvMjUgMTk6MDYsIEFuZHJldyBKb25lcyDlhpnpgZM6Cj4g PiBPbiBNb24sIEF1ZyAxNSwgMjAyMiBhdCAwMzoyMDoyNUFNICswMDAwLCBUb25nIFRpYW5nZW4g d3JvdGU6Cj4gPiA+IEN1cnJlbnRseSwgVGhlIGV4dGFibGUgdHlwZSBFWF9UWVBFX1VBQ0NFU1Nf RVJSX1pFUk8gaXMgdXNlZCBieQo+ID4gPiBfX2dldC9wdXRfa2VybmVsX25vZmF1bHQoKSwgYnV0 IHRob3NlIGhlbHBlcnMgYXJlIG5vdCB1YWNjZXNzIHR5cGUsIHNvIHdlCj4gPiA+IGFkZCBhIG5l dyBleHRhYmxlIHR5cGUgRVhfVFlQRV9LQUNDRVNTX0VSUl9aRVJPIHdoaWNoIGNhbiBiZSB1c2Vk IGJ5Cj4gPiA+IF9fZ2V0L3B1dF9rZXJuZWxfbm9fZmF1bHQoKS4KPiA+ID4gCj4gPiA+IE9ubHkg cmVmYWN0b3IgY29kZSB3aXRob3V0IGFueSBmdW5jdGlvbmFsIGNoYW5nZXMuCj4gPiAKPiA+IFRo aXMgaXNuJ3QgcXVpdGUgdHJ1ZS4gX19nZXQvcHV0X2tlcm5lbF9ub2ZhdWx0IG5vdyBzZXRzIGEg ZGlmZmVyZW50Cj4gPiBleHRhYmxlIHR5cGUgKGFzIHRoZSBjb21taXQgbWVzc2FnZSBzYXlzKS4g QnV0LCBub3RoaW5nIHNwZWNpYWwgc2VlbXMKPiA+IHRvIGJlIGRvbmUgd2l0aCB0aGF0LCBzbyB0 aGVyZSdzIGVmZmVjdGl2ZWx5IG5vIGZ1bmN0aW9uYWwgY2hhbmdlLiBDYW4KPiA+IHlvdSBwbGVh c2UgZWxhYm9yYXRlIG9uIHRoZSBtb3RpdmF0aW9uIGZvciB0aGlzIGNoYW5nZT8gV2hlcmUgd2ls bCB0aGUKPiA+IEtBQ0NFU1MgdHlwZSBuZWVkIHRvIGJlIGRpc3Rpbmd1aXNoZWQgZnJvbSB0aGUg VUFDQ0VTUyB0eXBlPwo+IAo+IFRoZSBpbnRyb2R1Y3Rpb24gb2YgRVhfVFlQRV9LQUNDRVNTX0VS Ul9aRVJPIGRvZXMgbm90IGNoYW5nZSBhbnkgZnVuY3Rpb24sCj4gYnV0IG1ha2VzIGEgY29ycmVj dCBkaXN0aW5jdGlvbiBpbiB0aGUgYWN0dWFsIHR5cGUsIGluZGljYXRpbmcgdGhhdCB0aGVyZQo+ IGFyZSBpbmRlZWQgc29tZSBrYWNjZXNzIGVudHJpZXMgaW4gZXh0YWJsZS4gSSB0aGluayB0aGlz IG9wdGltaXphdGlvbiBpcwo+IG1vcmUgY2xlYXIgYW5kIHJlYXNvbmFibGUuCgpXZWxsLCBjcmVh dGluZyBuZXcgdHlwZXMsIGp1c3QgZm9yIG5ldyB0eXBlIHNha2UsIGp1c3QgYmxvYXRzIGNvZGUu Cgo+IAo+IEEgZmV3IHdlZWtzIGFnbywgSSBkaWQgc29tZXRoaW5nIHNpbWlsYXIgb24gYXJtNjRb MV0uIEkgdGhpbmsgdGhpcwo+IG9wdGltaXphdGlvbiBjYW4gYWxzbyBiZSB1c2VkIG9uIHJpc2N2 Lgo+IAo+IFdlIGNhbiBkbyBzb21lIGZlYXR1cmVzIHRoYXQgYXJlIHVzZWQgb24gdWFjY3NzIGJ1 dCBub3QgYXBwbGljYWJsZSBvbgo+IGthY2Nlc3MgaW4gdGhlIGZ1dHVyZVsyXS4KPiAKPiBbMV0K PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjIwNjIxMDcyNjM4LjEyNzM1OTQtMi10 b25ndGlhbmdlbkBodWF3ZWkuY29tLwo+IFsyXWh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwv MjAyMjA4MTIwNzA1NTcuMTAyODQ5OS00LXRvbmd0aWFuZ2VuQGh1YXdlaS5jb20vCj4gCgpUaGlz IGlzIHBhcnQgb2YgdGhlIGluZm9ybWF0aW9uLCBidXQgSSBoYWQgYWxyZWFkeSBmb3VuZCB0aGlz LiBXaGF0J3MKc3RpbGwgbWlzc2luZyB0byBtZSBhcmUgdGhlIHJpc2N2IHBhdGNoZXMsIG9yIGF0 IGxlYXN0IGEgcmlzY3YgcGxhbiwgZm9yCmFjdHVhbGx5IGltcGxlbWVudGluZyBzb21ldGhpbmcg d2hpY2ggcmVxdWlyZXMga2FjY2VzcyBhbmQgdWFjY2VzcyB0byBoYXZlCmRpc3RpbmN0IHR5cGVz LgoKVGhhbmtzLApkcmV3CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 571CAECAAD2 for ; Fri, 26 Aug 2022 08:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343594AbiHZIQP (ORCPT ); Fri, 26 Aug 2022 04:16:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245046AbiHZIQM (ORCPT ); Fri, 26 Aug 2022 04:16:12 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91D843332 for ; Fri, 26 Aug 2022 01:16:10 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id sd33so1723727ejc.8 for ; Fri, 26 Aug 2022 01:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc; bh=vSLa1x3yM/LYq8duQfSkPR7UjODiLbU3hMPX4a6qvnM=; b=UqyAlLYFjk8ZZXCZkUAkMzFHX94KU2J+l4l4rJrrQqciOEX6BHzsNxrwAFkdpANkj1 DpFc90cp+HrdEdqAcWeb9GHE5MNqBYWVLf0ATbQGWJ5/VRMnMRmSqujnVkjPqAx5zwRN LeTyDNz/rscKZ8eplAnrC+SXS6utmYet2gqkNKUVIzbH02r3pVXxmUoYUVbScvNBSSHs a4KUorsMpqnXHyxa6s2S/svK0lbqMdlZi/h5op4aZqHk88SCZznn1RjaUNth/wqZmiN3 U/O2G8zqGMEln7g3snEQbSw+ueJYb6Rje+GWy2Y1OACAxfY7qEkOA2oMJyqQAveB0Ab5 P/bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc; bh=vSLa1x3yM/LYq8duQfSkPR7UjODiLbU3hMPX4a6qvnM=; b=4gjChEc074v7G8l/MhPNdGxu8k1NQ0hsMTwkgilwuOiRZ8r6+UZ0pjKLlOeXPc0mON lYFOpIxTuiYvgWqsIgCi3nRKwNlGetX17ldeZvJsg4xmP7jQVkJ4T5li4/HItCp81xEf f7+7Wu9f5VOF0BnKOVCqZefHvJiGFxa1pAdDd40WRoV33j+VVhZgWP088E1UDsmHBmLq II/QGyCKLrMw03U16XVEFtXwIuOQLkh0LFxaJb+SuVd5BwqzgnDMXhvDttJtxLKNAP9A IymZE5allfEGzsLCQaJO6HxScLNvFhhIUB1AK8DDjFwoKjSbhiVZHf7/N1+dc+tSecIA 15cg== X-Gm-Message-State: ACgBeo0uYUYRH4iBspAVtRfQAUnmJCzbB6ooIydTKCwEgSv2dMP7wnn8 ZI44xr5e6BqKNb2nqwxnAk4Rvw== X-Google-Smtp-Source: AA6agR7QQFuPvk2/UcrqfPRvBVDgErUw2JqMJaaJBD2nyOQrRspsGSM+8O8zg2pcCsGFDSNrUvWSeg== X-Received: by 2002:a17:907:2854:b0:740:2574:1f33 with SMTP id el20-20020a170907285400b0074025741f33mr883705ejc.105.1661501769444; Fri, 26 Aug 2022 01:16:09 -0700 (PDT) Received: from localhost (cst2-173-67.cust.vodafone.cz. [31.30.173.67]) by smtp.gmail.com with ESMTPSA id a3-20020a1709063e8300b0072b3406e9c2sm601689ejj.95.2022.08.26.01.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 01:16:08 -0700 (PDT) Date: Fri, 26 Aug 2022 10:16:07 +0200 From: Andrew Jones To: Tong Tiangen Cc: Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , Conor.Dooley@microchip.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, Guohanjun Subject: Re: [PATCH -next v2 2/2] riscv: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support Message-ID: <20220826081607.ci42sbffrmsfhk2w@kamzik> References: <20220815032025.2685516-1-tongtiangen@huawei.com> <20220815032025.2685516-3-tongtiangen@huawei.com> <20220825110602.bog5mjpascvikwxx@kamzik> <7718a9bc-e976-daeb-f490-e7b5190e50b6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7718a9bc-e976-daeb-f490-e7b5190e50b6@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 02:44:48PM +0800, Tong Tiangen wrote: > > > 在 2022/8/25 19:06, Andrew Jones 写道: > > On Mon, Aug 15, 2022 at 03:20:25AM +0000, Tong Tiangen wrote: > > > Currently, The extable type EX_TYPE_UACCESS_ERR_ZERO is used by > > > __get/put_kernel_nofault(), but those helpers are not uaccess type, so we > > > add a new extable type EX_TYPE_KACCESS_ERR_ZERO which can be used by > > > __get/put_kernel_no_fault(). > > > > > > Only refactor code without any functional changes. > > > > This isn't quite true. __get/put_kernel_nofault now sets a different > > extable type (as the commit message says). But, nothing special seems > > to be done with that, so there's effectively no functional change. Can > > you please elaborate on the motivation for this change? Where will the > > KACCESS type need to be distinguished from the UACCESS type? > > The introduction of EX_TYPE_KACCESS_ERR_ZERO does not change any function, > but makes a correct distinction in the actual type, indicating that there > are indeed some kaccess entries in extable. I think this optimization is > more clear and reasonable. Well, creating new types, just for new type sake, just bloats code. > > A few weeks ago, I did something similar on arm64[1]. I think this > optimization can also be used on riscv. > > We can do some features that are used on uaccss but not applicable on > kaccess in the future[2]. > > [1] > https://lore.kernel.org/lkml/20220621072638.1273594-2-tongtiangen@huawei.com/ > [2]https://lore.kernel.org/lkml/20220812070557.1028499-4-tongtiangen@huawei.com/ > This is part of the information, but I had already found this. What's still missing to me are the riscv patches, or at least a riscv plan, for actually implementing something which requires kaccess and uaccess to have distinct types. Thanks, drew