From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3703ECAAD4 for ; Sat, 27 Aug 2022 01:01:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 301FD60A94; Sat, 27 Aug 2022 01:01:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 301FD60A94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1661562104; bh=nt4uPPzWn8CLZY1rH4NzvVBdOnjQw9y5shyV/Ak7HBU=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=lyDPqaRT4jbnCBW6H9n/GauJ9+nz9hzlFHP7Wp6waRqF4H+UEo21i0UA6Rri81UFm x+9WWPPGmPKo6xE33rfqeFCN786nBXn/ssiudm1RQkt6QIZW8/ccoE6A6b/sv6cS0o UPeG7f/YUiZnKbZ9TFwCjg6njvzxK/jdK0v2TDhgGcEVl8AJikI7aD4yaHy8nUQ0je NhxTmqX1zBEV7xXHwosG8STymAwi7c7Jgdaa/pb4UTeHXtC6mEU/a5Hp3/jK6hdGAL CQfI+Ij7xdGZMPAgF6KQ59ShvGH2eZPskP6NsxPxx6nusgoIQhflqjFTesMvvjBqxq Ks11zqvWEvwmQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oaQL3DGKhuXl; Sat, 27 Aug 2022 01:01:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 4B53360AD0; Sat, 27 Aug 2022 01:01:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4B53360AD0 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 870EE1C2745 for ; Sat, 27 Aug 2022 01:01:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6001660AD0 for ; Sat, 27 Aug 2022 01:01:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6001660AD0 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lxDrser_oRxQ for ; Sat, 27 Aug 2022 01:01:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 94F9660A94 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp3.osuosl.org (Postfix) with ESMTPS id 94F9660A94 for ; Sat, 27 Aug 2022 01:01:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7E788B83366; Sat, 27 Aug 2022 01:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41CD4C43470; Sat, 27 Aug 2022 01:01:35 +0000 (UTC) Date: Fri, 26 Aug 2022 18:01:34 -0700 From: Jakub Kicinski To: Jiri Pirko Message-ID: <20220826180134.24b3648a@kernel.org> In-Reply-To: References: <20220826110059.119927-1-wojciech.drewek@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661562096; bh=t8uJtVYGVJrGtCLnX/H7b8u7UYthosyQkxfbjmbRSTY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fOrsCGHE6DeI7Q1LkvEeK5VxiWNF103FkLlU4Lz0cUKkOnBfvmRQmqX7FP05r9Eni fYKJCf+VHsn14T0BGzPraU2rs0pVSdHZwB0W9OvV+ALXUfd/bwO/pksHcnNN/aaH9K INR8iXe8Jn6Hi55Y3VuFIAWrU3e5Y9a/X5WtG8jJwNnrj6OtyFmTRTnwr64yakiksC X6lJdYWoU2kp8Ypg5ID88G0fu4j+4WR1KzaZL6cPDP223pVHEDijS4YdxVDWagtqtl UHv1lczMAKEjigEKYMvLsHwo7Ng4633V3suGzMAlKqVGXO6blEkYibSXPdOzQebhYC djZdmCHN/ZeYQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fOrsCGHE Subject: Re: [Intel-wired-lan] [RFC PATCH net-next 0/5] ice: L2TPv3 offload support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "simon.horman@corigine.com" , "kurt@linutronix.de" , "komachi.yoshiki@gmail.com" , "jchapman@katalix.com" , "edumazet@google.com" , "boris.sukholitko@broadcom.com" , "louis.peens@corigine.com" , "gnault@redhat.com" , "intel-wired-lan@lists.osuosl.org" , "vladbu@nvidia.com" , "pabeni@redhat.com" , "pablo@netfilter.org" , "baowen.zheng@corigine.com" , "maksym.glubokiy@plvision.eu" , "paulb@nvidia.com" , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 26 Aug 2022 16:34:34 +0200 Jiri Pirko wrote: > >Sorry, I'll include more precise description in the next version. > >DDP (Dynamic Device Personalization) is a firmware package that contains definitions > >protocol's headers and packets. It allows you to add support for the new protocol to the > >NIC card without rebooting. If the DDP package does not support L2TPv3 then hw offload > >will not work, however sw offload will still work. > > Hmm, so it is some FW part? Why do we care about it here in patchset > description? We generally encourage people to put as much context in the commit messages and cover letters as possible. Nothing wrong with saying that a specific parser microcode is needed, IMHO. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D44ECAAD5 for ; Sat, 27 Aug 2022 01:02:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231738AbiH0BBo (ORCPT ); Fri, 26 Aug 2022 21:01:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbiH0BBj (ORCPT ); Fri, 26 Aug 2022 21:01:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A00D41AF14 for ; Fri, 26 Aug 2022 18:01:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 629F9B8334C for ; Sat, 27 Aug 2022 01:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41CD4C43470; Sat, 27 Aug 2022 01:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661562096; bh=t8uJtVYGVJrGtCLnX/H7b8u7UYthosyQkxfbjmbRSTY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fOrsCGHE6DeI7Q1LkvEeK5VxiWNF103FkLlU4Lz0cUKkOnBfvmRQmqX7FP05r9Eni fYKJCf+VHsn14T0BGzPraU2rs0pVSdHZwB0W9OvV+ALXUfd/bwO/pksHcnNN/aaH9K INR8iXe8Jn6Hi55Y3VuFIAWrU3e5Y9a/X5WtG8jJwNnrj6OtyFmTRTnwr64yakiksC X6lJdYWoU2kp8Ypg5ID88G0fu4j+4WR1KzaZL6cPDP223pVHEDijS4YdxVDWagtqtl UHv1lczMAKEjigEKYMvLsHwo7Ng4633V3suGzMAlKqVGXO6blEkYibSXPdOzQebhYC djZdmCHN/ZeYQ== Date: Fri, 26 Aug 2022 18:01:34 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: "Drewek, Wojciech" , "netdev@vger.kernel.org" , "Lobakin, Alexandr" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "marcin.szycik@linux.intel.com" , "michal.swiatkowski@linux.intel.com" , "kurt@linutronix.de" , "boris.sukholitko@broadcom.com" , "vladbu@nvidia.com" , "komachi.yoshiki@gmail.com" , "paulb@nvidia.com" , "baowen.zheng@corigine.com" , "louis.peens@corigine.com" , "simon.horman@corigine.com" , "pablo@netfilter.org" , "maksym.glubokiy@plvision.eu" , "intel-wired-lan@lists.osuosl.org" , "jchapman@katalix.com" , "gnault@redhat.com" Subject: Re: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support Message-ID: <20220826180134.24b3648a@kernel.org> In-Reply-To: References: <20220826110059.119927-1-wojciech.drewek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 26 Aug 2022 16:34:34 +0200 Jiri Pirko wrote: > >Sorry, I'll include more precise description in the next version. > >DDP (Dynamic Device Personalization) is a firmware package that contains definitions > >protocol's headers and packets. It allows you to add support for the new protocol to the > >NIC card without rebooting. If the DDP package does not support L2TPv3 then hw offload > >will not work, however sw offload will still work. > > Hmm, so it is some FW part? Why do we care about it here in patchset > description? We generally encourage people to put as much context in the commit messages and cover letters as possible. Nothing wrong with saying that a specific parser microcode is needed, IMHO.