From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D163ECAAD6 for ; Fri, 26 Aug 2022 18:49:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C73EB847E8; Fri, 26 Aug 2022 20:49:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="VNBT+I9c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 08CE88419C; Fri, 26 Aug 2022 20:49:34 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1CCC784903 for ; Fri, 26 Aug 2022 20:49:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id y18so1930909qtv.5 for ; Fri, 26 Aug 2022 11:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=qBhCXgMHFGKMmLSOSxWKFGxJaDMgayHazEgwmXPmvb0=; b=VNBT+I9cujwwzGzMM0dThbeHfTXH7YVsTqWFB0mqqD/cxW+Qu/tkyoRgsbXWTNcSeW Es9g/v9c8qWmKv7HBw4sL9qnKZXiBVUGrIQcO+OJYmK5X0YooXJd5I+bhWkc/lXmbuQP 5fuagLQFu1suo2Ch//RLYXGa/FjPOwKjxp62Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=qBhCXgMHFGKMmLSOSxWKFGxJaDMgayHazEgwmXPmvb0=; b=aL9mUlfRgLkXrFpdazR/Kn7sSd9ulShLqTeHNNEB1gYK2eDbeSzWnhtZFuIQ8nwQ2K SCUlB+JUA99YHwFbmFl/ttTHl0Y35+JHke4SRr/fsgW5MjmykF5FFmJNdb7Vrgzppnle 9EgshuGVq2hNOGI8TARl4OOgLo98vpPBmPcUF66a6izLeodfFaEqFVCfx+kCGJS8dCMr /1iozJ8FTmg9ow6yh6eyyuqmOX/azYykxuDjI5xW3ij4qIbnJOKsrxalHxVbNbYbzCaK uHH09xpEYZbDhVVueLmDomYGFqo6VlLDdAhh2A0lfN0yYgkya6wIC2AuesJR0/+f5/HE Mu+A== X-Gm-Message-State: ACgBeo2hG9TpG7XMNPvVYke50tqpKXM8F4xRpiH+WLqiomeTAf84izGH MG6TwqL33qF/ZIUjA3FF1QjqRA== X-Google-Smtp-Source: AA6agR4fIfgR1yzd2e3pIWQrVBYf09un78Ro9gc7sVCoeod99FyQiIthWguUS6Vg6IozyGzFfSWQZQ== X-Received: by 2002:ac8:4e4a:0:b0:343:7e05:d2a8 with SMTP id e10-20020ac84e4a000000b003437e05d2a8mr916494qtw.67.1661539768673; Fri, 26 Aug 2022 11:49:28 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id u187-20020a3760c4000000b006bb9e4b96e6sm276907qkb.24.2022.08.26.11.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 11:49:28 -0700 (PDT) Date: Fri, 26 Aug 2022 14:49:26 -0400 From: Tom Rini To: Andrew Davis Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 3/4] firmware: ti_sci: Remove inline keyword from functions Message-ID: <20220826184926.GK7942@bill-the-cat> References: <20220726012506.19368-1-afd@ti.com> <20220726012506.19368-4-afd@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hlh2aiwFLCZwGcpw" Content-Disposition: inline In-Reply-To: <20220726012506.19368-4-afd@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Hlh2aiwFLCZwGcpw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 25, 2022 at 08:25:05PM -0500, Andrew Davis wrote: > The inline hint is not needed here, the compiler will do the right thing > based on if we are compiling for speed or for code size. In this case the > inline causes this function to be placed inside each callsite which is > not the right thing to do for either speed nor size. There is no > performance benefit to this due to the larger function size reducing > cache locality, but there is a huge size penalty. Remove inline keyword. >=20 > Signed-off-by: Andrew Davis Applied to u-boot/next, thanks! --=20 Tom --Hlh2aiwFLCZwGcpw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMJFbUACgkQFHw5/5Y0 tywGTwv6A2p1bNh0Lfead/RjNhr2ATL5EPA8+zv0q4WslpSAtM/ms2QqUVby0CYo 7LSj6kXXGR3NViH5jwENQkvDf195+ZMbeDBuGACVR1ZEl04vMEObgU1ZhsOnhiJw vzRl2U5CHUcqtVEj/B/FW8R7/a4NWPTFFXDNhFuBeYBoltr3w7FLIIXuu2SsMArh ETvHqYFnyx88ncMMD5BVuAbxEaYn9UItaQN4e8wiZRYuFmPwSWpAl7wHr7U/BTpr KNlfxEUsY3YL4lLgxXvabvNHWhky9qv5bSQjuMUVcG1IFcrcKOP25oRk4Nyooysz ULvOMNtK7VL2S4qD8PmUeGm8TgT+100MCwBukN2TQhNXvEuZ+aR+mvCT2pT0WJfQ Rh2lGdEKj+Jout3oA9HIWm4C4OrNlpLmkzzahT/lN0cTT6cvKyuwDaotPJwiyAj8 dxI+QJyMx9c3R4Nr2XWGKQapQvms4/FC2QDQ4LZLUC6xC/4ZjqFkApVU3uBA8bZV wSGpHnIh =C7rk -----END PGP SIGNATURE----- --Hlh2aiwFLCZwGcpw--