From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D7EFECAAD4 for ; Sat, 27 Aug 2022 01:57:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236715AbiH0B5c (ORCPT ); Fri, 26 Aug 2022 21:57:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230416AbiH0B5a (ORCPT ); Fri, 26 Aug 2022 21:57:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54BB18688B for ; Fri, 26 Aug 2022 18:57:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7401B8337D for ; Sat, 27 Aug 2022 01:57:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74B7FC433C1; Sat, 27 Aug 2022 01:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661565445; bh=NCw0TYEu61DEtV+6zYWSn180C5XepjHldGOnNGJvFHA=; h=Date:To:From:Subject:From; b=zE4S9UzUlpfxcp7OtYqLwyCljGxKIdBqx5bSsUFG4HbK2YnI7PHgmic/DsJwUsOdl hQ88oXMi1pbzFmfOKL5Ap4lsSZHvVrOqAyeeWgEtWuzX1eyxsl0Cd+yuu1jV9RTSqv U5kaL73GUSl58mgSsOYqxM2ry8YZLSy24gsTXyzQ= Date: Fri, 26 Aug 2022 18:57:24 -0700 To: mm-commits@vger.kernel.org, yury.norov@gmail.com, vbabka@suse.cz, sander@svanheule.net, rostedt@goodmis.org, peterz@infradead.org, nathan@kernel.org, mingo@redhat.com, mhiramat@kernel.org, luc.vanoostenryck@gmail.com, linux@rasmusvillemoes.dk, jpoimboe@kernel.org, Jason@zx2c4.com, isabbasso@riseup.net, edumazet@google.com, dan.j.williams@intel.com, arnd@arndb.de, bvanassche@acm.org, akpm@linux-foundation.org From: Andrew Morton Subject: + overflow-tracing-define-the-is_signed_type-macro-once.patch added to mm-nonmm-unstable branch Message-Id: <20220827015725.74B7FC433C1@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: overflow, tracing: define the is_signed_type() macro once has been added to the -mm mm-nonmm-unstable branch. Its filename is overflow-tracing-define-the-is_signed_type-macro-once.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/overflow-tracing-define-the-is_signed_type-macro-once.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Bart Van Assche Subject: overflow, tracing: define the is_signed_type() macro once Date: Fri, 26 Aug 2022 09:21:16 -0700 There are two definitions of the is_signed_type() macro: one in and a second definition in . As suggested by Linus Torvalds, move the definition of the is_signed_type() macro into the header file. Change the definition of the is_signed_type() macro to make sure that it does not trigger any sparse warnings with future versions of sparse for bitwise types. See also: https://lore.kernel.org/all/CAHk-=whjH6p+qzwUdx5SOVVHjS3WvzJQr6mDUwhEyTf6pJWzaQ@mail.gmail.com/ https://lore.kernel.org/all/CAHk-=wjQGnVfb4jehFR0XyZikdQvCZouE96xR_nnf5kqaM5qqQ@mail.gmail.com/ Link: https://lkml.kernel.org/r/20220826162116.1050972-3-bvanassche@acm.org Signed-off-by: Bart Van Assche Cc: Arnd Bergmann Cc: Dan Williams Cc: Eric Dumazet Cc: Ingo Molnar Cc: Isabella Basso Cc: "Jason A. Donenfeld" Cc: Josh Poimboeuf Cc: Luc Van Oostenryck Cc: Masami Hiramatsu Cc: Nathan Chancellor Cc: Peter Zijlstra Cc: Rasmus Villemoes Cc: Sander Vanheule Cc: Steven Rostedt Cc: Vlastimil Babka Cc: Yury Norov Signed-off-by: Andrew Morton --- include/linux/compiler.h | 6 ++++++ include/linux/overflow.h | 1 - include/linux/trace_events.h | 2 -- 3 files changed, 6 insertions(+), 3 deletions(-) --- a/include/linux/compiler.h~overflow-tracing-define-the-is_signed_type-macro-once +++ a/include/linux/compiler.h @@ -240,6 +240,12 @@ static inline void *offset_to_ptr(const #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) /* + * Whether 'type' is a signed type or an unsigned type. Supports scalar types, + * bool and also pointer types. + */ +#define is_signed_type(type) (((type)(-1)) < (__force type)1) + +/* * This is needed in functions which generate the stack canary, see * arch/x86/kernel/smpboot.c::start_secondary() for an example. */ --- a/include/linux/overflow.h~overflow-tracing-define-the-is_signed_type-macro-once +++ a/include/linux/overflow.h @@ -30,7 +30,6 @@ * https://mail-index.netbsd.org/tech-misc/2007/02/05/0000.html - * credit to Christian Biere. */ -#define is_signed_type(type) (((type)(-1)) < (type)1) #define __type_half_max(type) ((type)1 << (8*sizeof(type) - 1 - is_signed_type(type))) #define type_max(T) ((T)((__type_half_max(T) - 1) + __type_half_max(T))) #define type_min(T) ((T)((T)-type_max(T)-(T)1)) --- a/include/linux/trace_events.h~overflow-tracing-define-the-is_signed_type-macro-once +++ a/include/linux/trace_events.h @@ -814,8 +814,6 @@ extern int trace_add_event_call(struct t extern int trace_remove_event_call(struct trace_event_call *call); extern int trace_event_get_offsets(struct trace_event_call *call); -#define is_signed_type(type) (((type)(-1)) < (type)1) - int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set); int trace_set_clr_event(const char *system, const char *event, int set); int trace_array_set_clr_event(struct trace_array *tr, const char *system, _ Patches currently in -mm which might be from bvanassche@acm.org are testing-selftests-add-tests-for-the-is_signed_type-macro.patch overflow-tracing-define-the-is_signed_type-macro-once.patch