All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Raphael Pavlidis <raphael.pavlidis@googlemail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Raphael Pavlidis <raphael.pavlidis@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/slirp4netns: new package
Date: Sat, 27 Aug 2022 14:08:37 +0200	[thread overview]
Message-ID: <20220827120837.GV37358@scaer> (raw)
In-Reply-To: <a7ed0285-fea7-16f6-6ef8-9ff93fee1461@googlemail.com>

Raphael, All,

On 2022-08-27 12:57 +0200, Raphael Pavlidis via buildroot spake thusly:
> Can I do something, so this patch is accepted? :)

Just a little nudge... ;-)

> On 14.06.22 20:01, Raphael Pavlidis wrote:
> >slirp4netns is for user-mode networking for unprivileged network
> >namespace.
> >
> >Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>

Applied to next, thanks.

You forgot to add an entry in the DEVELOPERS file, and I forgot to
commit-amend my change, so I pushed a follow-up commit to add it.

Regards,
Yann E. MORIN.

> >---
> >Changes v1 -> v2:
> >   - Fix typo in SLIRP4NETNS_LICENSE_FILES
> >
> >  package/Config.in                    |  1 +
> >  package/slirp4netns/Config.in        | 20 ++++++++++++++++++++
> >  package/slirp4netns/slirp4netns.hash |  3 +++
> >  package/slirp4netns/slirp4netns.mk   | 15 +++++++++++++++
> >  4 files changed, 39 insertions(+)
> >  create mode 100644 package/slirp4netns/Config.in
> >  create mode 100644 package/slirp4netns/slirp4netns.hash
> >  create mode 100644 package/slirp4netns/slirp4netns.mk
> >
> >diff --git a/package/Config.in b/package/Config.in
> >index 3b089166da..216e04e98b 100644
> >--- a/package/Config.in
> >+++ b/package/Config.in
> >@@ -1903,6 +1903,7 @@ menu "Networking"
> >  	source "package/rtmpdump/Config.in"
> >  	source "package/siproxd/Config.in"
> >  	source "package/slirp/Config.in"
> >+	source "package/slirp4netns/Config.in"
> >  	source "package/snmppp/Config.in"
> >  	source "package/sofia-sip/Config.in"
> >  	source "package/sysrepo/Config.in"
> >diff --git a/package/slirp4netns/Config.in b/package/slirp4netns/Config.in
> >new file mode 100644
> >index 0000000000..22414dfbc9
> >--- /dev/null
> >+++ b/package/slirp4netns/Config.in
> >@@ -0,0 +1,20 @@
> >+config BR2_PACKAGE_SLIRP4NETNS
> >+	bool "slirp4netns"
> >+	depends on BR2_USE_MMU # libcap, libglib2, slirp
> >+	depends on BR2_USE_WCHAR # libglib2, slirp
> >+	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, slirp
> >+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS # libseccomp
> >+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # libseccomp
> >+	select BR2_PACKAGE_LIBCAP
> >+	select BR2_PACKAGE_LIBGLIB2
> >+	select BR2_PACKAGE_LIBSECCOMP
> >+	select BR2_PACKAGE_SLIRP
> >+	help
> >+	  User-mode networking for unprivileged network namespaces.
> >+
> >+	  https://github.com/rootless-containers/slirp4netns
> >+
> >+comment "slirp4netns needs a toolchain w/ wchar, threads, headers >= 3.17"
> >+	depends on BR2_USE_MMU
> >+	depends on BR2_PACKAGE_LIBSECCOMP_ARCH_SUPPORTS
> >+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
> >diff --git a/package/slirp4netns/slirp4netns.hash b/package/slirp4netns/slirp4netns.hash
> >new file mode 100644
> >index 0000000000..e3115c1be0
> >--- /dev/null
> >+++ b/package/slirp4netns/slirp4netns.hash
> >@@ -0,0 +1,3 @@
> >+# Locally computed:
> >+sha256  b584edde686d3cfbac210cbdb93c4b0ba5d8cc0a6a4d92b9dfc3c5baec99c727  slirp4netns-1.2.0.tar.gz
> >+sha256  58db3cfabf8ec806bc060e54ab5466a31de4a3ae80fe4a8aa02fb6b1c053c93f  COPYING
> >diff --git a/package/slirp4netns/slirp4netns.mk b/package/slirp4netns/slirp4netns.mk
> >new file mode 100644
> >index 0000000000..7ff594cc44
> >--- /dev/null
> >+++ b/package/slirp4netns/slirp4netns.mk
> >@@ -0,0 +1,15 @@
> >+################################################################################
> >+#
> >+# slirp4netns
> >+#
> >+################################################################################
> >+
> >+SLIRP4NETNS_VERSION = 1.2.0
> >+SLIRP4NETNS_SITE = $(call github,rootless-containers,slirp4netns,v$(SLIRP4NETNS_VERSION))
> >+SLIRP4NETNS_LICENSE = GPL-2.0
> >+SLIRP4NETNS_LICENSE_FILES = COPYING
> >+SLIRP4NETNS_DEPENDENCIES = libcap libglib2 libseccomp slirp
> >+
> >+SLIRP4NETNS_AUTORECONF = YES
> >+
> >+$(eval $(autotools-package))
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-27 12:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 17:50 [Buildroot] [PATCH 1/1] package/slirp4netns: new package Raphael Pavlidis via buildroot
2022-06-14 18:01 ` [Buildroot] [PATCH v2] " Raphael Pavlidis via buildroot
2022-08-27 10:57   ` Raphael Pavlidis via buildroot
2022-08-27 12:08     ` Yann E. MORIN [this message]
2022-08-29 18:55       ` Raphael Pavlidis
2022-08-29 19:48         ` Yann E. MORIN
2022-08-29 21:46           ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220827120837.GV37358@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=raphael.pavlidis@gmail.com \
    --cc=raphael.pavlidis@googlemail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.