From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B34FECAAD2 for ; Mon, 29 Aug 2022 09:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbiH2Jes (ORCPT ); Mon, 29 Aug 2022 05:34:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbiH2Jen (ORCPT ); Mon, 29 Aug 2022 05:34:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A60BF5C977; Mon, 29 Aug 2022 02:34:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E42A60F61; Mon, 29 Aug 2022 09:34:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0E6C433C1; Mon, 29 Aug 2022 09:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661765672; bh=Ha7dPQQt8ROs3mVSwSdR/iJAj2vnJKDi274nVUfFx2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ShdId/P+BPxRRnzSDYp5021K7jSBepOheJ/pdQpDzhMHQ32qy9qvSSLsJCHViqOq3 XX7WezEX/OF5wV62UETeyglC2ZTASTy8+MU/4/Odt6mrcmc0DMQaQmMJDo5rRryRwK 4f+o88jXTy7AgDvOIhQHe7MC09u2giYqUYlBFXlsXOVdUXHJ4cDNwkIrv17kC9Oi7E gWbbJ0uxZsG9V9zFi0pe/3lp8vxS2zVaGkxJ5PKp2PSMOLHi7NF593NVbx9zbQLIsa 4jUXJbT705B3r7ynAHDZ6CYO5GonMavGdhrVIuWDS56pTiBjv+BEybs6qiX5pcnnE9 FCk4vNLB1QQQw== Received: by pali.im (Postfix) id 12D687DE; Mon, 29 Aug 2022 11:34:29 +0200 (CEST) Date: Mon, 29 Aug 2022 11:34:28 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Thomas Petazzoni , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: aardvark: Add support for PCI Bridge Subsystem Vendor ID on emulated bridge Message-ID: <20220829093428.4danatwennps55dr@pali> References: <20220711221823.12154-1-pali@kernel.org> <20220711225915.13896-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Monday 29 August 2022 11:31:32 Lorenzo Pieralisi wrote: > On Tue, Jul 12, 2022 at 12:59:15AM +0200, Pali Rohár wrote: > > Register with Subsystem Device/Vendor ID is at offset 0x2c. Export is via > > emulated bridge. > > "Export it..." I suppose. Yes, it is a typo :-( > So in short, this patch enables support for the Subsystem Device/Vendor > ID - by reading it in the PCI controller config space and storing it > in the emulated bridge control structures, so that it is exposed in > the respective PCI capability. Yes, it reads it from internal aardvark registers and stores it into the emulated bridge config space. > Correct ? > > Thanks, > Lorenzo > > > After this change Subsystem ID is visible in lspci output at line: > > > > Capabilities: [40] Subsystem > > > > Signed-off-by: Pali Rohár > > > > --- > > Changes in v2: > > * Fix wrong rebase, do not add PCIE_CORE_EXP_ROM_BAR_REG > > --- > > drivers/pci/controller/pci-aardvark.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > index 74511f015168..060936ef01fe 100644 > > --- a/drivers/pci/controller/pci-aardvark.c > > +++ b/drivers/pci/controller/pci-aardvark.c > > @@ -32,6 +32,7 @@ > > #define PCIE_CORE_DEV_ID_REG 0x0 > > #define PCIE_CORE_CMD_STATUS_REG 0x4 > > #define PCIE_CORE_DEV_REV_REG 0x8 > > +#define PCIE_CORE_SSDEV_ID_REG 0x2c > > #define PCIE_CORE_PCIEXP_CAP 0xc0 > > #define PCIE_CORE_ERR_CAPCTL_REG 0x118 > > #define PCIE_CORE_ERR_CAPCTL_ECRC_CHK_TX BIT(5) > > @@ -982,6 +983,8 @@ static int advk_sw_pci_bridge_init(struct advk_pcie *pcie) > > /* Indicates supports for Completion Retry Status */ > > bridge->pcie_conf.rootcap = cpu_to_le16(PCI_EXP_RTCAP_CRSVIS); > > > > + bridge->subsystem_vendor_id = advk_readl(pcie, PCIE_CORE_SSDEV_ID_REG) & 0xffff; > > + bridge->subsystem_id = advk_readl(pcie, PCIE_CORE_SSDEV_ID_REG) >> 16; > > bridge->has_pcie = true; > > bridge->data = pcie; > > bridge->ops = &advk_pci_bridge_emul_ops; > > -- > > 2.20.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DEA8ECAAD4 for ; Mon, 29 Aug 2022 09:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DMVD4kxC0NA3LIoHIK/r70fI43sPE6TtFsYF/vzz61s=; b=jArH/iM1xvMf27 nXG1ebblrJZqSNBpV18+PtyoFWOIRjS7u7CEx+lZQs4heEJ+1SIc9O6HSMoIpVJYfNRRXbmUO5sSh sHkwiJ2z6PxYomM255lQqeyfB7d3spqvYxals6OHjCFuHRXMAY5efkJAXbJjG2kGbG8B3lCEeCqxu R+aVyybwAQ2j3ymJYVCQYK8WIzj4UyZ5t8d1MslpYoSD1Pa/Ghf8lFyhJYLo41oquWa0stjNKRJFi gFJH1uEjmhFQMvTatjCLpzltpIUr7tGf6+S3tVCE3S1Wh/quJts5cOc9L7dK02BxAjyZuXGoTmY5V ymx1LraItkyDwD6W3Hpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSbBW-006nTu-EJ; Mon, 29 Aug 2022 09:35:58 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSbAA-006mXZ-Nk for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 09:34:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5B67AB80E22; Mon, 29 Aug 2022 09:34:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0E6C433C1; Mon, 29 Aug 2022 09:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661765672; bh=Ha7dPQQt8ROs3mVSwSdR/iJAj2vnJKDi274nVUfFx2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ShdId/P+BPxRRnzSDYp5021K7jSBepOheJ/pdQpDzhMHQ32qy9qvSSLsJCHViqOq3 XX7WezEX/OF5wV62UETeyglC2ZTASTy8+MU/4/Odt6mrcmc0DMQaQmMJDo5rRryRwK 4f+o88jXTy7AgDvOIhQHe7MC09u2giYqUYlBFXlsXOVdUXHJ4cDNwkIrv17kC9Oi7E gWbbJ0uxZsG9V9zFi0pe/3lp8vxS2zVaGkxJ5PKp2PSMOLHi7NF593NVbx9zbQLIsa 4jUXJbT705B3r7ynAHDZ6CYO5GonMavGdhrVIuWDS56pTiBjv+BEybs6qiX5pcnnE9 FCk4vNLB1QQQw== Received: by pali.im (Postfix) id 12D687DE; Mon, 29 Aug 2022 11:34:29 +0200 (CEST) Date: Mon, 29 Aug 2022 11:34:28 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Thomas Petazzoni , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: aardvark: Add support for PCI Bridge Subsystem Vendor ID on emulated bridge Message-ID: <20220829093428.4danatwennps55dr@pali> References: <20220711221823.12154-1-pali@kernel.org> <20220711225915.13896-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_023435_238335_D56F4C85 X-CRM114-Status: GOOD ( 23.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uZGF5IDI5IEF1Z3VzdCAyMDIyIDExOjMxOjMyIExvcmVuem8gUGllcmFsaXNpIHdyb3Rl Ogo+IE9uIFR1ZSwgSnVsIDEyLCAyMDIyIGF0IDEyOjU5OjE1QU0gKzAyMDAsIFBhbGkgUm9ow6Fy IHdyb3RlOgo+ID4gUmVnaXN0ZXIgd2l0aCBTdWJzeXN0ZW0gRGV2aWNlL1ZlbmRvciBJRCBpcyBh dCBvZmZzZXQgMHgyYy4gRXhwb3J0IGlzIHZpYQo+ID4gZW11bGF0ZWQgYnJpZGdlLgo+IAo+ICJF eHBvcnQgaXQuLi4iIEkgc3VwcG9zZS4KClllcywgaXQgaXMgYSB0eXBvIDotKAoKPiBTbyBpbiBz aG9ydCwgdGhpcyBwYXRjaCBlbmFibGVzIHN1cHBvcnQgZm9yIHRoZSBTdWJzeXN0ZW0gRGV2aWNl L1ZlbmRvcgo+IElEIC0gYnkgcmVhZGluZyBpdCBpbiB0aGUgUENJIGNvbnRyb2xsZXIgY29uZmln IHNwYWNlIGFuZCBzdG9yaW5nIGl0Cj4gaW4gdGhlIGVtdWxhdGVkIGJyaWRnZSBjb250cm9sIHN0 cnVjdHVyZXMsIHNvIHRoYXQgaXQgaXMgZXhwb3NlZCBpbgo+IHRoZSByZXNwZWN0aXZlIFBDSSBj YXBhYmlsaXR5LgoKWWVzLCBpdCByZWFkcyBpdCBmcm9tIGludGVybmFsIGFhcmR2YXJrIHJlZ2lz dGVycyBhbmQgc3RvcmVzIGl0IGludG8gdGhlCmVtdWxhdGVkIGJyaWRnZSBjb25maWcgc3BhY2Uu Cgo+IENvcnJlY3QgPwo+IAo+IFRoYW5rcywKPiBMb3JlbnpvCj4gCj4gPiBBZnRlciB0aGlzIGNo YW5nZSBTdWJzeXN0ZW0gSUQgaXMgdmlzaWJsZSBpbiBsc3BjaSBvdXRwdXQgYXQgbGluZToKPiA+ IAo+ID4gICBDYXBhYmlsaXRpZXM6IFs0MF0gU3Vic3lzdGVtCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+Cj4gPiAKPiA+IC0tLQo+ID4gQ2hhbmdl cyBpbiB2MjoKPiA+ICogRml4IHdyb25nIHJlYmFzZSwgZG8gbm90IGFkZCBQQ0lFX0NPUkVfRVhQ X1JPTV9CQVJfUkVHCj4gPiAtLS0KPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJk dmFyay5jIHwgMyArKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPiAK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jIGIv ZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwo+ID4gaW5kZXggNzQ1MTFmMDE1 MTY4Li4wNjA5MzZlZjAxZmUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVy L3BjaS1hYXJkdmFyay5jCj4gPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJk dmFyay5jCj4gPiBAQCAtMzIsNiArMzIsNyBAQAo+ID4gICNkZWZpbmUgUENJRV9DT1JFX0RFVl9J RF9SRUcJCQkJCTB4MAo+ID4gICNkZWZpbmUgUENJRV9DT1JFX0NNRF9TVEFUVVNfUkVHCQkJCTB4 NAo+ID4gICNkZWZpbmUgUENJRV9DT1JFX0RFVl9SRVZfUkVHCQkJCQkweDgKPiA+ICsjZGVmaW5l IFBDSUVfQ09SRV9TU0RFVl9JRF9SRUcJCQkJCTB4MmMKPiA+ICAjZGVmaW5lIFBDSUVfQ09SRV9Q Q0lFWFBfQ0FQCQkJCQkweGMwCj4gPiAgI2RlZmluZSBQQ0lFX0NPUkVfRVJSX0NBUENUTF9SRUcJ CQkJMHgxMTgKPiA+ICAjZGVmaW5lICAgICBQQ0lFX0NPUkVfRVJSX0NBUENUTF9FQ1JDX0NIS19U WAkJCUJJVCg1KQo+ID4gQEAgLTk4Miw2ICs5ODMsOCBAQCBzdGF0aWMgaW50IGFkdmtfc3dfcGNp X2JyaWRnZV9pbml0KHN0cnVjdCBhZHZrX3BjaWUgKnBjaWUpCj4gPiAgCS8qIEluZGljYXRlcyBz dXBwb3J0cyBmb3IgQ29tcGxldGlvbiBSZXRyeSBTdGF0dXMgKi8KPiA+ICAJYnJpZGdlLT5wY2ll X2NvbmYucm9vdGNhcCA9IGNwdV90b19sZTE2KFBDSV9FWFBfUlRDQVBfQ1JTVklTKTsKPiA+ICAK PiA+ICsJYnJpZGdlLT5zdWJzeXN0ZW1fdmVuZG9yX2lkID0gYWR2a19yZWFkbChwY2llLCBQQ0lF X0NPUkVfU1NERVZfSURfUkVHKSAmIDB4ZmZmZjsKPiA+ICsJYnJpZGdlLT5zdWJzeXN0ZW1faWQg PSBhZHZrX3JlYWRsKHBjaWUsIFBDSUVfQ09SRV9TU0RFVl9JRF9SRUcpID4+IDE2Owo+ID4gIAli cmlkZ2UtPmhhc19wY2llID0gdHJ1ZTsKPiA+ICAJYnJpZGdlLT5kYXRhID0gcGNpZTsKPiA+ICAJ YnJpZGdlLT5vcHMgPSAmYWR2a19wY2lfYnJpZGdlX2VtdWxfb3BzOwo+ID4gLS0gCj4gPiAyLjIw LjEKPiA+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=