From: Kees Cook <keescook@chromium.org>
To: Robert Elliott <elliott@hpe.com>
Cc: mpe@ellerman.id.au, nanya@linux.vnet.ibm.com,
asahiroy@kernel.org, michal.lkml@markovi.net, corbet@lwn.net,
ndesaulniers@google.com, linux-hardening@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs/core-api: expand Fedora instructions for GCC plugins
Date: Mon, 29 Aug 2022 12:25:59 -0700 [thread overview]
Message-ID: <202208291225.A0D3FAFC@keescook> (raw)
In-Reply-To: <20220827193836.2582079-1-elliott@hpe.com>
On Sat, Aug 27, 2022 at 02:38:36PM -0500, Robert Elliott wrote:
> In Fedora 36, cross-compiling an allmodconfig configuration
> for other architectures on x86 fails with this problem:
>
> In file included from ../scripts/gcc-plugins/gcc-common.h:95,
> from ../scripts/gcc-plugins/latent_entropy_plugin.c:78:
> /usr/lib/gcc/aarch64-linux-gnu/12/plugin/include/builtins.h:23:10: fatal
> error: mpc.h: No such file or directory
> 23 | #include <mpc.h>
> | ^~~~~~~
> compilation terminated.
>
> In that distro, that header file is available in the separate
> libmpc-devel package.
>
> Although future versions of Fedora might correctly mark
> that dependency, mention this additional package.
>
> To help detect such problems ahead of time, describe the
> gcc -print-file-name=plugin
> command that is used by scripts/gcc-plugins/Kconfig to detect
> plugins [1].
>
> [1] https://lore.kernel.org/lkml/CAHk-=wjjiYjCp61gdAMpDOsUBU-A2hFFKJoVx5VAC7yV4K6WYg@xxxxxxxxxxxxxx/
>
> Fixes: 43e96ef8b70c50f ("docs/core-api: Add Fedora instructions for GCC plugins");
> Signed-off-by: Robert Elliott <elliott@hpe.com>
Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
Jon, do you want to take this since it's entirely in the .rst file?
--
Kees Cook
next prev parent reply other threads:[~2022-08-29 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 19:38 [PATCH] docs/core-api: expand Fedora instructions for GCC plugins Robert Elliott
2022-08-29 19:25 ` Kees Cook [this message]
2022-08-29 20:53 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208291225.A0D3FAFC@keescook \
--to=keescook@chromium.org \
--cc=asahiroy@kernel.org \
--cc=corbet@lwn.net \
--cc=elliott@hpe.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mpe@ellerman.id.au \
--cc=nanya@linux.vnet.ibm.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.