All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yang Ling <gnaygnil@gmail.com>
Subject: Re: [PATCH] MIPS: loongson32: ls1c: Fix hang during startup
Date: Mon, 29 Aug 2022 15:14:40 +0200	[thread overview]
Message-ID: <20220829131440.GA12409@alpha.franken.de> (raw)
In-Reply-To: <20220823111725.3134377-1-keguang.zhang@gmail.com>

On Tue, Aug 23, 2022 at 07:17:25PM +0800, Keguang Zhang wrote:
> From: Yang Ling <gnaygnil@gmail.com>
> 
> The RTCCTRL reg of LS1C is obselete.
> Writing this reg will cause system hang.
> 
> Fixes: 60219c563c9b6 ("MIPS: Add RTC support for Loongson1C board")
> Signed-off-by: Yang Ling <gnaygnil@gmail.com>
> Tested-by: Keguang Zhang <keguang.zhang@gmail.com>
> Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
>  arch/mips/loongson32/ls1c/board.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/loongson32/ls1c/board.c b/arch/mips/loongson32/ls1c/board.c
> index e9de6da0ce51..9dcfe9de55b0 100644
> --- a/arch/mips/loongson32/ls1c/board.c
> +++ b/arch/mips/loongson32/ls1c/board.c
> @@ -15,7 +15,6 @@ static struct platform_device *ls1c_platform_devices[] __initdata = {
>  static int __init ls1c_platform_init(void)
>  {
>  	ls1x_serial_set_uartclk(&ls1x_uart_pdev);
> -	ls1x_rtc_set_extclk(&ls1x_rtc_pdev);
>  
>  	return platform_add_devices(ls1c_platform_devices,
>  				   ARRAY_SIZE(ls1c_platform_devices));
> 
> base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      reply	other threads:[~2022-08-29 13:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 11:17 [PATCH] MIPS: loongson32: ls1c: Fix hang during startup Keguang Zhang
2022-08-29 13:14 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829131440.GA12409@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=gnaygnil@gmail.com \
    --cc=keguang.zhang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.