From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2AD3ECAAD4 for ; Mon, 29 Aug 2022 22:08:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8920B163E; Tue, 30 Aug 2022 00:07:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8920B163E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661810900; bh=hha+rQcnlZzZOY1umtz1sH6o5W3YKInJwbRszuXYHwQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ModJqGWjI7S8S1QESdqBdhSr/p2F7r81EpUOqUDqlxYhlECPa386usJ50HhpQuz6v Oe61Ejp/tnICU1GU9uMompN/JNDHz9Q227zOyb+s23ZK2drzy2eYJBi73W8vMQC7Sn +FQeoJuVKc1QFPSutbLBn4a8qNhq7W7jfzCuCoks= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0C1F1F8016C; Tue, 30 Aug 2022 00:07:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2DD22F801F7; Tue, 30 Aug 2022 00:07:28 +0200 (CEST) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E85ECF8012A for ; Tue, 30 Aug 2022 00:07:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E85ECF8012A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kgkdmJX7" Received: by mail-pl1-x629.google.com with SMTP id x23so9290791pll.7 for ; Mon, 29 Aug 2022 15:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=k2Isl7E2TJrjz9RWvaLb1hVmrU1bdckrw7QzjwxtCok=; b=kgkdmJX7EizEvIXDuh3PyH9dF4tkinwEbVoInAmpJDW2RpLs7hLMkXJ04kArFIK4uw xJinRNSts20Fpeyl0cWOYrfKmZ93mkCktWz28aG7myBx5tzDJ3gL5KlNzCWRomOCtDQZ RUyqDuIw0xjEQayVF6Ia5ksfmxWePWZW1oRRQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=k2Isl7E2TJrjz9RWvaLb1hVmrU1bdckrw7QzjwxtCok=; b=Cl1G8NEXa5dnwkV8FL/g2r9+/LAlEOsewIa2OoCPpvVZx4UShT5B175tW4bMJCiKup m6IOBpTUjiyYNpnS47QOBM+hpjKgMVs/D4o3IEXv5jNC4lCaMO1IarGSs6ZtMSXqwa6k JbhZK5Ej4spOaBnQ9dKHH9Y/+iFp9o0YVAL5fQdB+NWqTNcY0FVqlbfsPyR3F9BxPtoJ N4K2sO1OubD+HHHDzDopMhVRj8M/Ex94xnDPl1MFnKA+9GVLFZ9IYoyXX7s+bGf8oiOF Wo4+vWj9CVxBM1HIeLUZ0S4aQ2VXTV/xPHbx1xIZdQ0Z7vWtnP8K9GqQiF0nkkKdt/U5 aGqg== X-Gm-Message-State: ACgBeo01y1eOfuzAZQkm6DJ4TeOqO7Rv/iu5O3gHzf0+jG5dbXgUyDXB JtazpeyvRu3ColI2zdoXwAiCVXipszaW9Q== X-Google-Smtp-Source: AA6agR4KrLR6NM3om4AqBBqcBSC2Rv/4c/jLw32zl1wdhvYKXC6KOo0sBiRaKJGSYNPNPGv75DjJ2Q== X-Received: by 2002:a17:902:c94d:b0:16d:c10a:650e with SMTP id i13-20020a170902c94d00b0016dc10a650emr17851903pla.29.1661810838390; Mon, 29 Aug 2022 15:07:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id md10-20020a17090b23ca00b001f24c08c3fesm7324164pjb.1.2022.08.29.15.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 15:07:17 -0700 (PDT) Date: Mon, 29 Aug 2022 15:07:16 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Subject: Re: [PATCH][next] ALSA: hda/hdmi: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Message-ID: <202208291507.FBA7EF4@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Aug 29, 2022 at 04:52:03PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length array > declaration in union audio_infoframe with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for a flexible-array member in a union. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D44BECAAD2 for ; Mon, 29 Aug 2022 22:07:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbiH2WHX (ORCPT ); Mon, 29 Aug 2022 18:07:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbiH2WHU (ORCPT ); Mon, 29 Aug 2022 18:07:20 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E25CEA2D9B for ; Mon, 29 Aug 2022 15:07:18 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id q3so6085243pjg.3 for ; Mon, 29 Aug 2022 15:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=k2Isl7E2TJrjz9RWvaLb1hVmrU1bdckrw7QzjwxtCok=; b=kgkdmJX7EizEvIXDuh3PyH9dF4tkinwEbVoInAmpJDW2RpLs7hLMkXJ04kArFIK4uw xJinRNSts20Fpeyl0cWOYrfKmZ93mkCktWz28aG7myBx5tzDJ3gL5KlNzCWRomOCtDQZ RUyqDuIw0xjEQayVF6Ia5ksfmxWePWZW1oRRQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=k2Isl7E2TJrjz9RWvaLb1hVmrU1bdckrw7QzjwxtCok=; b=qTz/9ZDlFjVvHTXZyLbA7MXILKCeYrGs29SDUpq/8tfJGc6QwsWmLYKr6mZ4c4bJZW sUCGjWCwbqchmZ+wVu23DV37ltAkZytjup1+BvtFAIJIO9x5Vmlinst4MlERuGF+ajjJ yWKMvMBSdAx4zs8TKtsVVd7QNVvVn9R1RNVNojV7qufIMIo63gizxg+XSs13Ssg1w/e0 APPeFIcZM9wtVT6pTx6I54ga4Hzh+AR03tpqk3QdCqfQYvkmENvDjZvVmOMhb+Wlo83D h0Pgolc4/O4XIqeM/GF/MvEA1Z1NoyPUEVj01Ar1Eb32GlOm/kyK/5SqmVMxJ572wuD2 vAIA== X-Gm-Message-State: ACgBeo30WfrhP5AUR0LSxjVNelOn6lR7G8wUIOLIh7OidUC7O5WPBIz8 +8buWiCI4tQeObYm5RvTAjq9XjYSDhIFRw== X-Google-Smtp-Source: AA6agR4KrLR6NM3om4AqBBqcBSC2Rv/4c/jLw32zl1wdhvYKXC6KOo0sBiRaKJGSYNPNPGv75DjJ2Q== X-Received: by 2002:a17:902:c94d:b0:16d:c10a:650e with SMTP id i13-20020a170902c94d00b0016dc10a650emr17851903pla.29.1661810838390; Mon, 29 Aug 2022 15:07:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id md10-20020a17090b23ca00b001f24c08c3fesm7324164pjb.1.2022.08.29.15.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 15:07:17 -0700 (PDT) Date: Mon, 29 Aug 2022 15:07:16 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] ALSA: hda/hdmi: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Message-ID: <202208291507.FBA7EF4@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Mon, Aug 29, 2022 at 04:52:03PM -0500, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated and we are moving towards adopting > C99 flexible-array members, instead. So, replace zero-length array > declaration in union audio_infoframe with the new DECLARE_FLEX_ARRAY() > helper macro. > > This helper allows for a flexible-array member in a union. > > Link: https://github.com/KSPP/linux/issues/193 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook