Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Tue, Aug 30, 2022 at 09:48:28AM +0100, Marc Zyngier wrote:
> On 2022-08-30 09:44, Manivannan Sadhasivam wrote:
> > On Tue, Aug 30, 2022 at 09:26:51AM +0100, Marc Zyngier wrote:
> > > On 2022-08-30 09:12, Manivannan Sadhasivam wrote:
> > > > The IRQCHIP implementation used inside the gpiochips are not supposed to
> > > 
> > > lower case
> > > 
> > > > be changed during runtime. So let's make the one inside the spmi-gpio
> > > > gpiochip immutable.
> > > >
> > > > This fixes the below warning during boot:
> > > > gpio gpiochip0: (c440000.spmi:pmic@0:gpio@c000): not an immutable
> > > > chip, please consider fixing it!
> > > >
> > > > Separate callbacks need to be provided for irq_{mask/unmask} pointers
> > > > since
> > > > the callbacks are supposed to mask/unmask the corresponding parent IRQ
> > > > in
> > > > addition to changing the gpio_desc flags.
> > > 
> > > This is all part of the existing documentation, so I don't think
> > > this is really needed.
> > > 
> > 
> > Yes it is documented, but developers usually refer the commits doing the
> > similar
> > thing while doing these kind of conversions. For them, this text serves
> > as a
> > quick documentation.
> 
> If they can't be bothered to read the documentation, why would they
> consider reading unrelated commits?
> 
> > 
> > So I prefer to keep it in the commit message.
> 
> I still think this is pointless.
> 

Okay. I'll remove it in v3.

Thanks,
Mani

>         M.
> -- 
> Jazz is not dead. It just smells funny...

-- 
மணிவண்ணன் சதாசிவம்