From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1389DECAAD8 for ; Tue, 30 Aug 2022 18:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbiH3SBQ (ORCPT ); Tue, 30 Aug 2022 14:01:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbiH3SA6 (ORCPT ); Tue, 30 Aug 2022 14:00:58 -0400 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9849810F0; Tue, 30 Aug 2022 11:00:31 -0700 (PDT) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-11f4e634072so4341418fac.13; Tue, 30 Aug 2022 11:00:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=4umf5P0qSFO98IiufExn5Sdnahshv3yBAldzEjgn0j4=; b=vqZe6YOFZrMyWSAYRghd+R3eCyO25rkIlLnzpKyq3Z8IDoZt8u3gNON0elk0hbuMG9 RX4DLVQmHMVnIOdePS5dPMJj0KY1SANj/FMhAoR96F5iuwkM3jui3uzWbsA1pNyJn+Wq VpeXddjR72o+a4EcVye0pzRiJGV4bKJnQeXUxQAl+rvU16jTQs7I3A3trIaU4cKudo6v cJZdC0Yvlj8OypA9ywTmvqwZRlwMS1B2S+aL6lZM867Ct+Q3CekTnbNXzvHflWg0HHlb 7mZvkY9KTmifEbIP7CG+kE3YDDe+ox1AllxMe6XUG27tZCJpE+5WtXBOCBwps3Sx3syT oNxw== X-Gm-Message-State: ACgBeo2t8M1qatZKhF4ju1HeSMqnE9vBEIO+SshRO0k/Djg2ASLXN0W4 lP8TqSrltIGjPsAwNilcqg== X-Google-Smtp-Source: AA6agR5pm1v/qqg5BoLZtI0AcGW1KCa2e9nRD3jxB0Zc5BamYv40k7hzMg2PE3x0QwFLivkcj0gaGA== X-Received: by 2002:a54:4496:0:b0:343:2d07:fe01 with SMTP id v22-20020a544496000000b003432d07fe01mr9350204oiv.226.1661882429847; Tue, 30 Aug 2022 11:00:29 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q17-20020a9d6551000000b006370c0e5be0sm7861506otl.48.2022.08.30.11.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 11:00:29 -0700 (PDT) Received: (nullmailer pid 1763999 invoked by uid 1000); Tue, 30 Aug 2022 18:00:28 -0000 Date: Tue, 30 Aug 2022 13:00:28 -0500 From: Rob Herring To: Serge Semin Cc: Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , Krzysztof Kozlowski , Manish Narani , Serge Semin , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Dinh Nguyen , James Morse , Robert Richter , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH 02/13] dt-bindings: memory: snps: Add Baikal-T1 DDRC support Message-ID: <20220830180028.GA1758236-robh@kernel.org> References: <20220822191957.28546-1-Sergey.Semin@baikalelectronics.ru> <20220822191957.28546-3-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220822191957.28546-3-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Mon, Aug 22, 2022 at 10:19:45PM +0300, Serge Semin wrote: > Baikal-T1 DDR controller is based on the DW uMCTL2 DDRC IP-core v2.51a > with up to DDR3 protocol capability and 32-bit data bus + 8-bit ECC. There > are individual IRQs for each ECC and DFI events.The dedicated scrubber > clock source is absent since it's fully synchronous to the core clock. > In addition to that the DFI-DDR PHY CSRs can be accessed via a separate > registers space. Are you sure the phy and dfi irq shouldn't be a separate device? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4520C0502C for ; Tue, 30 Aug 2022 18:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3yuuF9IwOvc/g6wYFz2pXuQCpwVmyyBoJhS4lGs0A80=; b=CH0LYp+6Lccr9E KzOqPm6uIxwvw3f3oxh+4eGUqbuDPpa17EEjwktGzkoEZcRNSi9W5i09WrfCAbtC4p0KVTnV8/vtL a7L+hQ53p+whH1bREobbfeDac0W8vmNSIMzwjlbrz4s4iuFkBi2GsC1IMwRoHqWz+sMC5a5XP2dcV W2Hj56FBmqI+A+ORRL45FBl2OHUCULP68wpBOCFEaqMuGn6+0olBqGHsVQyeCUQzTR2OijeUELMuT oSeh25cvDhGvKqsXmhrugP0bPQzxrFagFqxw5YD8mKeaor7s2WoRIi6zLyEXahBc86l+7Gzrjg/td OKJUllyq8SO5Lm8OwAmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT5XR-0013Je-LX; Tue, 30 Aug 2022 18:00:38 +0000 Received: from mail-oa1-f50.google.com ([209.85.160.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT5XN-0013F0-MN for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 18:00:34 +0000 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-11f11d932a8so10189229fac.3 for ; Tue, 30 Aug 2022 11:00:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=4umf5P0qSFO98IiufExn5Sdnahshv3yBAldzEjgn0j4=; b=7fSb8uquXq+EnF1xUvIzSmY0O1ltwZbE7/pqiCX/Ml8zUv9UjoKP9oQ/InnZ/PN/Ih XeyHEaeDLBYC2acqKFmTjOlhBSLqwGGMIfSKwltIsHCpIdmyJ+mj0uMY7Fi3UUFaXxeg fGgfsyunq82lp+WhCkNTtExRDdSFjb9nGlHwLHloBu6BBqIKF7HNIeX0F5PjwDWufJUf OODvZRzSl45OZZCB9jyvOzRpskHfY0luMRWl7+EkoYfLnQDzFPWs7NqLOcjXPfJsDGZh BJq4ctyMxXoYVlBHvX/Lias60Mag3gbhkzj30Vo644O3h+R2Izg5XJUy1JpXkNPpUn+4 rDmg== X-Gm-Message-State: ACgBeo0VHGRgUf5RBdWg0oC7PjyW88JFpltFfIFz7TjBG/pKrwJq/dCd Svj0FMFG28C0ocUdd1FLog== X-Google-Smtp-Source: AA6agR5pm1v/qqg5BoLZtI0AcGW1KCa2e9nRD3jxB0Zc5BamYv40k7hzMg2PE3x0QwFLivkcj0gaGA== X-Received: by 2002:a54:4496:0:b0:343:2d07:fe01 with SMTP id v22-20020a544496000000b003432d07fe01mr9350204oiv.226.1661882429847; Tue, 30 Aug 2022 11:00:29 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q17-20020a9d6551000000b006370c0e5be0sm7861506otl.48.2022.08.30.11.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 11:00:29 -0700 (PDT) Received: (nullmailer pid 1763999 invoked by uid 1000); Tue, 30 Aug 2022 18:00:28 -0000 Date: Tue, 30 Aug 2022 13:00:28 -0500 From: Rob Herring To: Serge Semin Cc: Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , Krzysztof Kozlowski , Manish Narani , Serge Semin , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Dinh Nguyen , James Morse , Robert Richter , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH 02/13] dt-bindings: memory: snps: Add Baikal-T1 DDRC support Message-ID: <20220830180028.GA1758236-robh@kernel.org> References: <20220822191957.28546-1-Sergey.Semin@baikalelectronics.ru> <20220822191957.28546-3-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220822191957.28546-3-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_110033_754735_F55AFED4 X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 22, 2022 at 10:19:45PM +0300, Serge Semin wrote: > Baikal-T1 DDR controller is based on the DW uMCTL2 DDRC IP-core v2.51a > with up to DDR3 protocol capability and 32-bit data bus + 8-bit ECC. There > are individual IRQs for each ECC and DFI events.The dedicated scrubber > clock source is absent since it's fully synchronous to the core clock. > In addition to that the DFI-DDR PHY CSRs can be accessed via a separate > registers space. Are you sure the phy and dfi irq shouldn't be a separate device? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel