All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <mani@kernel.org>
To: Koen Vandeputte <koen.vandeputte@citymesh.com>
Cc: mhi@lists.linux.dev, Koen Vandeputte <koen.vandeputte@ncentric.com>
Subject: Re: [PATCH] bus: mhi: host: always print detected modem name
Date: Wed, 31 Aug 2022 13:45:44 +0530	[thread overview]
Message-ID: <20220831081544.GB5076@thinkpad> (raw)
In-Reply-To: <20220819083615.251960-1-koen.vandeputte@ncentric.com>

On Fri, Aug 19, 2022 at 10:36:15AM +0200, Koen Vandeputte wrote:
> This harmless print provides a very easy way of knowing
> if the modem is detected properly during probing.
> 
> Promote it to an informational print so no hassle is required
> enabling kernel debugging info to obtain it.
> 
> The rationale here is that:
> On a lot of low-storage embedded devices, extensive kernel
> debugging info is not always present as this would
> increase it's size to much causing partition size issues.
> 
> Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>

While applying this patch, checkpatch.pl complains that the email addresses
mismatch.

From:/Signed-off-by: email address mismatch: 'From: Koen Vandeputte <koen.vandeputte@citymesh.com>'
!= 'Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>'

Can you please fix it and resend?

Thanks,
Mani


> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..51e2b901bae0 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	struct mhi_controller *mhi_cntrl;
>  	int err;
>  
> -	dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
> +	dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
>  
>  	/* mhi_pdev.mhi_cntrl must be zero-initialized */
>  	mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), GFP_KERNEL);
> -- 
> 2.34.1
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

      parent reply	other threads:[~2022-08-31  8:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  8:36 [PATCH] bus: mhi: host: always print detected modem name Koen Vandeputte
2022-08-19 13:24 ` Jeffrey Hugo
2022-08-19 13:54   ` Koen Vandeputte
2022-08-29 17:37 ` Manivannan Sadhasivam
2022-08-30 17:45   ` Loic Poulain
2022-08-31  8:15 ` Manivannan Sadhasivam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220831081544.GB5076@thinkpad \
    --to=mani@kernel.org \
    --cc=koen.vandeputte@citymesh.com \
    --cc=koen.vandeputte@ncentric.com \
    --cc=mhi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.