From: Kees Cook <keescook@chromium.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Isabella Basso <isabbasso@riseup.net>,
kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Dan Williams <dan.j.williams@intel.com>,
Eric Dumazet <edumazet@google.com>,
Ingo Molnar <mingo@redhat.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sander Vanheule <sander@svanheule.net>,
Steven Rostedt <rostedt@goodmis.org>,
Vlastimil Babka <vbabka@suse.cz>,
Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH 1/2] testing/selftests: Add tests for the is_signed_type() macro
Date: Wed, 31 Aug 2022 10:53:50 -0700 [thread overview]
Message-ID: <202208311053.B1C87B1B@keescook> (raw)
In-Reply-To: <3bd708e6-2cee-9177-5453-f6b152ec762c@acm.org>
On Mon, Aug 29, 2022 at 08:30:54PM -0700, Bart Van Assche wrote:
> On 8/29/22 19:33, Isabella Basso wrote:
> > > +#include <kunit/test.h>
> > > +#include <linux/overflow.h>
> >
> > Nit: I don’t know if that makes a huge difference but you might include
> > `<linux/compiler.h>` directly to make the final object smaller. Of course, that
> > would ideally be a change happening in 2/2 but that was already merged :).
>
> Right, that could have been done in patch 2/2 but I think this can also be
> done as a follow-up patch. I'm not sure what Kees prefers?
A follow-up would be easier for me. And perhaps could include Rasmus's
suggestions too?
--
Kees Cook
next prev parent reply other threads:[~2022-08-31 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 16:21 [PATCH 0/2] Define is_signed_type() once Bart Van Assche
2022-08-26 16:21 ` [PATCH 1/2] testing/selftests: Add tests for the is_signed_type() macro Bart Van Assche
2022-08-29 19:30 ` Kees Cook
2022-08-30 2:33 ` Isabella Basso
2022-08-30 3:30 ` Bart Van Assche
2022-08-31 17:53 ` Kees Cook [this message]
2022-08-30 9:41 ` Rasmus Villemoes
2022-09-06 22:42 ` Bart Van Assche
2022-09-06 22:48 ` Rasmus Villemoes
2022-08-26 16:21 ` [PATCH 2/2] overflow, tracing: Define the is_signed_type() macro once Bart Van Assche
2022-08-29 19:30 ` Kees Cook
2022-08-29 19:36 ` [PATCH 0/2] Define is_signed_type() once Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208311053.B1C87B1B@keescook \
--to=keescook@chromium.org \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=dan.j.williams@intel.com \
--cc=edumazet@google.com \
--cc=isabbasso@riseup.net \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sander@svanheule.net \
--cc=vbabka@suse.cz \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.